Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anTG6-0005iq-OT for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Apr 2016 15:51:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1anTG5-0006rg-LL for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Apr 2016 15:51:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1anTG5-0006rX-2l for pgadmin-hackers@postgresql.org; Tue, 05 Apr 2016 15:51:13 +0000 Received: from mail-io0-x235.google.com ([2607:f8b0:4001:c06::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1anTG0-0007Rx-EL for pgadmin-hackers@postgresql.org; Tue, 05 Apr 2016 15:51:12 +0000 Received: by mail-io0-x235.google.com with SMTP id g185so23861917ioa.2 for ; Tue, 05 Apr 2016 08:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=7SYbw3a0rkWxbqBUgmkYnQ7QV4vlkTj4eWX9VNT8jwM=; b=h/uBl66LHeUMfKi9T7tCMrm/0rUr62yGWFmeaw5dEMAvXe+rr5htFAmj2+LjzTdzMK aepfygciqLMDyj2Srhe/c4vLggoPeQcVnkD8ePJdofZC6c2aHl2kjpX9foVd7qidz8yq 9rmblZUJkJON8dcsng5LGu5uw+6UlH3UMw4dm3FZ7lEr68ttLaRP3B1ELlJGPQIW/Sq1 lqfj3PFjLkxSTl+nYlaJhuhz0b+cNShGxOLPWr1oHiACklUgxLATvAekM1v3ArcfkN2L cq33VQ3pI1BQ7JnYljG41A37iMs67YVGVitaOPZhZu3p+cHWGoFUz+jBEISkLSu1UpkG 3lDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=7SYbw3a0rkWxbqBUgmkYnQ7QV4vlkTj4eWX9VNT8jwM=; b=R16l6M+5NnL9ZDFC+IVIGecYfXEJ8oqml05WL5zAIZWS8miaVGczjvx7AHNNkka301 y+mkWjgalsd1/TCpPdmaSPUqQt1J53woI+0eyoLzU6jGtaxdV4wGusn92E/e7BYTe0WQ pt6QqpTmJQiZ46INeaEeDICGAQdZa8uWFV69WhiadMywobWwMBuP/2Hl/R+qcRif3F1F OjfncxBE/z/1FIJP8zHkvCzRLcUw4LN39eNIpxAuQzCzVWGYei0rBCz5VGww90DOKn7x 8P4RhD1JU8DlqbcgRYGMoCpX8uiIRjBl2TSkIAawTDs4yVi2Dfmlwpkb3FBsFivp+Mxh iWBQ== X-Gm-Message-State: AD7BkJJOATpNmgvjSCS5FJAQ1xR8TRjJuoxGBwdaDBO7uNfU+64x1epsRL7AxhsRxLWZoQ6kJn/ImuLgBK3WJA== MIME-Version: 1.0 X-Received: by 10.107.43.17 with SMTP id r17mr11185578ior.156.1459871466475; Tue, 05 Apr 2016 08:51:06 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Tue, 5 Apr 2016 08:51:06 -0700 (PDT) In-Reply-To: References: Date: Tue, 5 Apr 2016 16:51:06 +0100 Message-ID: Subject: Re: Patch: Added select2cell editor for backgrid [pgAdmin4] From: Dave Page To: Ashesh Vashi Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113a495e2d7c85052fbed0e5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113a495e2d7c85052fbed0e5 Content-Type: text/plain; charset=UTF-8 I've reverted the change to overrides.css that this patch made as it was that that was causing the padding issue on backgrid that we noted this morning when looking at the debugger. +} + +.select2-cell .select2-container > .backgrid th, .backgrid td +{ + padding: 0px; Please fix in a less blanket way. On Mon, Apr 4, 2016 at 11:07 AM, Ashesh Vashi wrote: > Thanks - committed with small changes. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Mon, Apr 4, 2016 at 1:09 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> PFA updated patch. >> >> Regards, >> Murtuza >> >> >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Fri, Apr 1, 2016 at 3:08 PM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> We have added Select2Cell Editor for backgrid, eariler as it was not >>>> present & causing issue in rendering in subnode control. >>>> >>> Looks good to me, but - have some feedback. >>> 1. Can you please mention - why do we need 'openOnEnter: false' in >>> select2 options? >>> 2. There is a difference between UI, when rendered from the editor, and >>> from the Select2Cell. (I can see padding, when the Cell is rendered, but - >>> not when editor is rendered.) >>> >>> Can you please fix this two? >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113a495e2d7c85052fbed0e5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I've reverted the change to overrides.css that this pa= tch made as it was that that was causing the padding issue on backgrid that= we noted this morning when looking at the debugger.

+}
+
+.select2-cell .select2-container > .backgrid= th, .backgrid td
+{
+ =C2=A0 =C2=A0padding: 0px;
=

Please fix in a less blanket way.

On Mon, Apr 4, 2016 a= t 11:07 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com>= ; wrote:
Thanks -= committed with small changes.


On Mon, Apr 4,= 2016 at 1:09 PM, Murtuza Zabuawala <murtuza.zabuawala@en= terprisedb.com> wrote:
Hi,

PFA updated patch.

=
Regards,
Murtuza



<= div dir=3D"ltr">--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Comp= any

On Fri, Apr 1, 2016 at 3:08= PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala <= span dir=3D"ltr"><murtuza.zabuawala@enterprisedb.com> wrote:<= br>

=
Hi,

We have added Select2Cell Editor fo= r backgrid, eariler as it was not present & causing issue in rendering = in subnode control.
Looks good to me, but - ha= ve some feedback.
1. Can you please mention - why do we need '= ;openOnEnter: false' in select2 options?
2. There is a differ= ence between UI, when rendered from the editor, and from the Select2Cell. (= I can see padding, when the Cell is rendered, but - not when editor is rend= ered.)

Can you please fix this two?

=

--

<= p style=3D"margin:0pt">Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/ashes= hvashi



--
Regards,
= Murtuz= a Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=







--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y
--001a113a495e2d7c85052fbed0e5--