Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erKRf-0003jq-Ha for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 09:24:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erKRd-00014v-O4 for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 09:24:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erKRd-00014l-Df for pgadmin-hackers@lists.postgresql.org; Thu, 01 Mar 2018 09:24:09 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erKRU-0002WH-1h for pgadmin-hackers@postgresql.org; Thu, 01 Mar 2018 09:24:08 +0000 Received: by mail-wm0-x242.google.com with SMTP id t74so10218694wme.3 for ; Thu, 01 Mar 2018 01:23:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WArA22aN50My8zkUb578jcO6pBsC2Z0IukR2gXnYark=; b=Rnk29rdzo5BgJqxwGgTglQSxSZfinI4R0RGjTMdeF3WZncum3jkALn0rATYDVVrBIi KF+n5Dy7iKtbM/kZJcU+NKsU0oJLQKH7nTGxdYjtQp1IO6Fy4F1LZ/KIBGa6kzFbx3KQ MDfOaUGAGG9AJ9W+WxKEhJsWuEVem/Lp68fGdkqUYK9eE00geLeT550eVoBY+A/6eNMC qsrwt1LYXQho8iykBK38YsCAl4KeLxboH7KxrNrQW5LZArH8ivmnm+EQ1l73jr/QD88/ 810hJQVvMnL1b9xLvPvl1Kl71QidKglNchybQFSoRrNjHj84qZKAcPB03vSoCxvvQu68 CjmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WArA22aN50My8zkUb578jcO6pBsC2Z0IukR2gXnYark=; b=JDdRuS7IbdDkEvug2IWhdBONWSVyhuYxo781d2r4IQquqLazZVGBKKyQriPEknE0wg ZzrS+oyGxCZ+jAxUCIw9jPwArfxUQs0BZoZthMKMbtm/opgyZABJrUkLIJsmNKxitPtC bKjdHqC9eABgdIcxhnNXeIVQ8Qw9m32i17bdyi/J+LEMwDoZQXs0dQn1ndzRY+7igWKr iqI3fnUxCUXken1d+HNoGVlRI1yOINGlwTzX7xE0pSHZ57bva5pE9TpD8ehSHwlA7A0d 681e+6LYJE06BLhyL79RwmM3RV+bSCS2oVfi9gM77tTFA5mfiSAMYzgi/Hoycrw38DOy BUbA== X-Gm-Message-State: APf1xPA8oEMjFku98vOc0Z8swmjHqN1e0/uJloFGZlDcChtYQsrxb3/w k5gMomMCHUE4XQzS2S2Pq1ZVl4yZdDFXfYahzjbSuw== X-Google-Smtp-Source: AG47ELt3+BS1yGPXQSlL6TdzPFDmUN9X4y5HRSJ7FA+kPDx88RrlWwB2Y9aq0sb8zgPdd2jLY/HSh0NXuUZsm5hLy18= X-Received: by 10.28.41.3 with SMTP id p3mr1230163wmp.140.1519896238352; Thu, 01 Mar 2018 01:23:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.34.212 with HTTP; Thu, 1 Mar 2018 01:23:55 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Thu, 1 Mar 2018 09:23:55 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI To: Joao De Almeida Pereira Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114e3cc66200e10566566bb1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114e3cc66200e10566566bb1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 28, 2018 at 3:10 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello Murtuza, > I do not have the pgAgent installed so it was a little it hard to test > this. > FWIW, you don't need to install pgAgent to test this - you can just load the SQL file I sent into your maintenance database, and that should enable all the pgAgent features in pgAdmin. Obviously jobs won't get run, but you'll be able to create them and edit them. > After looking into the code I think we are missing some testing coverage > around the pga_job Javascript part so that we can catch these problems. > Even some code extraction can be done around the pg_jobset change > +1 > > Nevertheless I passed the patch through our CI and it is all green > > Thanks > Joao > > On Wed, Feb 28, 2018 at 5:36 AM Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> I have found the issue, it was in Backform control itself :) >> Issue: We were passing today's date value as minDate option in pgAgent >> schedule schema while rendering the control, So when server was sending >> previous datetime value it was not displaying it causing sync problem. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala > enterprisedb.com> wrote: >> >>> =E2=80=8BThanks Dave, I'll look into it. >>> =E2=80=8B >>> >>> >>> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala >>> enterprisedb.com> wrote: >>>> >>>>> I'm not able to re-produce the issue, Could you hard refresh and try >>>>> again? >>>>> >>>> >>>> I still see it. >>>> >>>> >>>>> >>>>> If possible could you please provide exact steps? >>>>> >>>> >>>> Attached is a dump of my test pgagent schema. >>>> >>>> 1) Load the schema dump into the maintenance database >>>> 2) Connect pgAdmin >>>> 3) Browse to pgAgent Jobs >>>> 4) Right-click Properties, and select the Schedules tab >>>> 5) Open the subnode for sched1 >>>> >>>> >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page wrote: >>>>> >>>>>> Sorry - here it is. >>>>>> >>>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala < >>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> Could you please send screenshot? >>>>>>> >>>>>>> -- >>>>>>> Regards, >>>>>>> Murtuza Zabuawala >>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> Still not quite right - see the attached screenshot which is the >>>>>>>> result of simply viewing the properties of an existing job. Note t= hat the >>>>>>>> start time is shown in the grid but not the subnode control. >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala < >>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Dave, >>>>>>>>> >>>>>>>>> As validation related patch was committed with RM#3148 [ Sorry >>>>>>>>> about that I forgot to checkout :) ] >>>>>>>>> PFA patch to fix the issues you mentioned, I have also removed >>>>>>>>> extra error message from sub node collection control and made it = optional >>>>>>>>> via flag. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Regards, >>>>>>>>> Murtuza Zabuawala >>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala < >>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> PFA patch to fix the issue where user was not able to create >>>>>>>>>>> pgAgent job from UI without entering End date in schedule secti= on. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Whilst this does resolve the validation issue, there are still = a >>>>>>>>>> couple of other related problems, as can be seen in the attached >>>>>>>>>> screenshots: >>>>>>>>>> >>>>>>>>>> - The Start date/time in the subnode control doesn't seem to be >>>>>>>>>> properly synchronised with the value in the grid. >>>>>>>>>> >>>>>>>>>> - If you leave the End date/time blank (but maybe click into it >>>>>>>>>> first), the grid will show "Invalid date". >>>>>>>>>> >>>>>>>>>> It's possible there are other oddities as well - please check >>>>>>>>>> carefully for anything else. >>>>>>>>>> >>>>>>>>>> Thanks. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114e3cc66200e10566566bb1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Feb 28, 2018 at 3:10 PM, Joao De Almeida Pereira <j= dealmeidapereira@pivotal.io> wrote:
Hello Murtuza,
I do not have the pgAgent inst= alled so it was a little it hard to test this.

FWIW, you don't need to install pgAgent to test this - = you can just load the SQL file I sent into your maintenance database, and t= hat should enable all the pgAgent features in pgAdmin. Obviously jobs won&#= 39;t get run, but you'll be able to create them and edit them.
=C2=A0
After lo= oking into the code I think we are missing some testing coverage around the= pga_job Javascript part so that we can catch these problems.
Eve= n some code extraction can be done around the pg_jobset change
<= /blockquote>

+1
=C2=A0

Nevertheless I passed th= e patch through our CI and it is all green

Thanks<= /div>
Joao
<= /span>

On Wed, Feb 28, 2018 at 5:36 AM Murtuza Zabuawala = <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

I have found the issue, it was in Backform control itself = :)
Issue: = We were passing today's date value as minDate option in pgAgent schedul= e schema while rendering the control, So when server was sending previous d= atetime value it was not displaying it causing sync problem.

=
<= div dir=3D"ltr">--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company

=

On Tue, Feb= 27, 2018 at 8:39 PM, Murtuza Zabuawala <murtuza.zabuawal= a@enterprisedb.com> wrote:
=E2=80=8BThanks Dave, I'll look into it.
=E2=80=8B


On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I'm not able to re-produce the issue, Could yo= u hard refresh and try again?

I still see it.
=C2=A0
<= br>
If pos= sible could you please provide exact steps?
Attached is a dump of my test pgagent schema.

1) Load the schema dump into the maintenance database
2)= Connect pgAdmin
3) Browse to pgAgent Jobs
4) Right-cli= ck Properties, and select the Schedules tab
5) Open the subnode f= or sched1
=C2=A0

--
Regards,
<= font face=3D"verdana, sans-serif" color=3D"#444444">Murtuza Zabuawala
En= terpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise = PostgreSQL Company

<= /div>

On T= ue, Feb 27, 2018 at 5:30 PM, Dave Page <dpage@pgadmin.org> w= rote:
Sorry - here it is= .

On Tue, Fe= b 27, 2018 at 11:59 AM, Murtuza Zabuawala <murtuza.zabuaw= ala@enterprisedb.com> wrote:
Hi Dave,

Could you please send screenshot?
=
= --Regards,=
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterpris= edb.com
The Enterprise PostgreSQL Company
<= div><= img src=3D"https://drive.google.com/a/enterprisedb.com/uc?id=3D0B6jGeB3BfKR= MV0t4MEp0YnZCTTA&export=3Ddownload" width=3D"420" height=3D"31">

On Tue, Feb 27, 2018 at 5:24 PM, Dav= e Page <dpage@pgadmin.org> wrote:
Hi

Still not quite right - see = the attached screenshot which is the result of simply viewing the propertie= s of an existing job. Note that the start time is shown in the grid but not= the subnode control.

Thanks.

On Tue, Feb 27, 2018 at 8:= 26 AM, Murtuza Zabuawala <murtuza.zabuawala@enterpri= sedb.com> wrote:
= Hi Dave,

As validation related patch was committed with RM#3148 [ Sorry about = that I forgot to checkout :)=C2=A0]
PFA patch to fix the issues you mentioned, = I have also removed extra error message from sub node collection control an= d made it optional via flag.



--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= /font>


On Mon, Feb 26, 2018 at 10:14 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where user was not able to create = pgAgent job from UI without entering End date in schedule section.

=C2=A0Whilst this does resolve the vali= dation issue, there are still a couple of other related problems, as can be= seen in the attached screenshots:

- The Start dat= e/time in the subnode control doesn't seem to be properly synchronised = with the value in the grid.

- If you leave the End= date/time blank (but maybe click into it first), the grid will show "= Invalid date".

It'= s possible there are other oddities as well - please check carefully for an= ything else.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
=
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgs= nake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany

=


--
Dave = Page
Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company




--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a114e3cc66200e10566566bb1--