MIME-Version: 1.0
In-Reply-To: 
 <CA+Vc24rG9rERsphieMhGTPLSCajX=DUV2T_0rB6tK+WYz+V=+A@mail.gmail.com>
References: 
 <CA+Vc24rPt8BGgtZM5Pv4CARpw7t42A5aqQX5q0_QyWWOfgsGTA@mail.gmail.com>
 <CAHowoHbyxYrnROe+8BDBaf_Z8KneW95be8g-5OMZ4q5jFH28Ow@mail.gmail.com>
 <CA+OCxoyNGb4A6BLV=u4gBCCBzj+HT_5GKPmnmu91WAGrpkEZtg@mail.gmail.com>
 <CAHowoHYNQC5kovTvkVoYWRr6NCDvLY-8PsEMcJLsu-7z43VNeg@mail.gmail.com>
 <CA+OCxoy+miWFpGa6W=1t7swn8vPvDayKtNdGnYUdaYOPNEkQ2A@mail.gmail.com>
 <CAHowoHYZxQxVLxA0N8iKoVGN=0vahSxrc0Kd4LkqoOWQYUSmkQ@mail.gmail.com>
 <CAHowoHa4k7E6LBDaiuUFPBKOcsa_ML7M3KEhDZUsbR-KKujemw@mail.gmail.com>
 <CA+OCxow6adDHsG2VTtVbRQ2ybCOdKTanFGf1hNoVdn_Gt9Betw@mail.gmail.com>
 <CA+OCxozeqDfoAiJ4AYf-Hnoq5FTCwWVXcEE-h460H5-_RVg9jw@mail.gmail.com>
 <CAHowoHa32=Y8zjYjZ_DHLukxHFzJZ9kV6y1ErDUwfPaE5MNCrw@mail.gmail.com>
 <CA+Vc24rpjYertAeAqK0T5eXAe=oGOCg2y09gNshgamih1KrOMg@mail.gmail.com>
 <CA+OCxozuy8DMJq79FTmk5p86jW-Z_88i85Wx-yc2OYLg=FTznQ@mail.gmail.com>
 <CAHowoHbXL2wu2feErTTWhgmcM4=48KATZkvguGRiy-UNNW-mfQ@mail.gmail.com>
 <CA+OCxoymnnPU5N5VU37xNWBGLZUSrSshwQSVVy1ut++YqT6UQQ@mail.gmail.com>
 <CA+OCxoxZMuXOPiNEMbYCBPXaZYBquRpcNd2YpvfwbS1T8bUPzg@mail.gmail.com>
 <CA+Vc24pjFs=Qy4-eFq5bWUAzRfwZkictJ0GykxbNh3hz=1YcBw@mail.gmail.com>
 <CA+OCxozt9evQcAtsLhRvO0xYL7QKr6Gk=RMUzTJ_w0HfFYtVww@mail.gmail.com>
 <CA+Vc24r=B7+2nEMquJde0cCwRS66oEdQhB2BDAkMDzdGtPGtjg@mail.gmail.com>
 <CA+Vc24ornL=p=eepG+MOt2wAX+A29rhJyMYq-tgHkwLk0F40DQ@mail.gmail.com>
 <CA+OCxozsTtd+dTRV7=N+xD-0fD4_fPAq+iFrORPk3QU2mHo6UA@mail.gmail.com>
 <CA+Vc24p_Q9FGy3MGCHUd_HaGfHNmqkfqrqRV9HSkS7cSosTdFA@mail.gmail.com>
 <CA+OCxowRnWpS5sBRWFdL=cprJ4rU_bencj2VpbLx4YjtJg-TMQ@mail.gmail.com>
 <CA+Vc24rG9rERsphieMhGTPLSCajX=DUV2T_0rB6tK+WYz+V=+A@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 9 Feb 2017 14:28:43 +0000
Message-ID: 
 <CA+OCxoxvhPXStN2VLsdHAgetGwT3aSQDhf3c5eAgYh=KqOGSbw@mail.gmail.com>
Subject: Re: Acceptance Tests against a browser (WIP)
To: Atira Odhner <aodhner@pivotal.io>
Cc: George Gelashvili <ggelashvili@pivotal.io>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Thu, Feb 9, 2017 at 2:20 PM, Atira Odhner <aodhner@pivotal.io> wrote:
> Certainly.  We did mention the dependency in the email. Would it be better
> to mention it in the patch name?

I think the problem was that the way you phrased it, it sounded
optional ("an updated patch which does not include adding that test
helper in case you apply the show-tables patch first"). I think a
clear "This patch is dependent on patch Foo" would suffice.

> Is there a better way for us to manage
> these changes? On other open source projects, I've seen github mirrors set
> up so that changes can be pulled in like branches rather then as patch
> applies. That would have avoided this situation since the parent commit
> would be pulled in with the same SHA from either pull request branch and git
> would not see it as a conflict.
>
> I'm rather new to dealing with patch files like this so I would love some
> tips.

The Postgres project in general is quite conservative and stuck in
it's ways about how things are done (which is usually a good thing
considering you trust your data to the resulting code). We're used to
dealing with larger patchsets via the mailing list - typically as long
as you're clear about any dependencies, it shouldn't be a problem.
Some of us use tools like PyCharms for handling patches and helping
with reviews etc. which I guess replaces most, if not all of the
GitHub functionality over plain git.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers