Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3kh1-0002bg-Ji for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 15:51:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3kh0-0002r6-HN for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 15:51:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3kh0-0002qw-79 for pgadmin-hackers@lists.postgresql.org; Wed, 04 Apr 2018 15:51:22 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3kgv-0001VK-SB for pgadmin-hackers@postgresql.org; Wed, 04 Apr 2018 15:51:21 +0000 Received: by mail-wr0-x242.google.com with SMTP id s18so23480123wrg.9 for ; Wed, 04 Apr 2018 08:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TWNb+vJUIr75Krzj1nk67e1dBmpqZi+rHhUX3k/t0to=; b=AS3RL3Whha8FvU8u5VkY4vEXq8MAGiUU32l4CY+Xe7GPOawRTxY9l7LUnvhOzZAVj5 uNidM3tARWTpf39I805DVFOH4S18PVwlICEps+y2g0A19ItxEt7cVFY7MsFqWKFIDeoB ivIwuXCVJFBgolamOjH2MabnMw4tlw0+h2T4J+nwClTuwqAFtErOZJg5V1iybIrkmYLf ZrMcG1PH2uFVff5zqZMoCjhE6N0VoNnbu2P3i94KCKC5Jjc7K7D6a8QxdhFu1xsqJ5vV JjeN75X9vup0XYccFUxseXbV6azq6Z/uyq5NPvE+qCS6v7K/NtTl4mcUyPIRt9wqLu1m JD7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TWNb+vJUIr75Krzj1nk67e1dBmpqZi+rHhUX3k/t0to=; b=Il8wu6/wFhlL/h+pgzan7LqrXl7kSU+tvxfLmRcszczK06xVOL5Nw7kjKfurN7fBOS IXYmtrTraDMtoy7SmDkGspEweyV2VWEa0C9lcPSFY4v6xs5TbjKUll317lb/QdygaZ8q BLigWD68o/dHixjNwgtZMLCHT1C/4FK6kodDaHvhyhahIyjTSU099QUksgTK0sm26BBM 4Gaky4oXmDAoA2tYFx+z4Z51MzSPx2oj3llhDfJRZeTWsPT68ZKoub0dK3RKsuPR02Y6 dF0EKswH5etmsiuprUWmLcJG+jSUa3Z+Tic1EAB9H2+lqDuDI/zKDC323AJiGRAbip0U uL8Q== X-Gm-Message-State: AElRT7H9VYIew2esnWzhZbx01PN2iWpOKYKB1/xrMm5ki55rV2lbCSrk ZcfaHW/0tHRYz1cRHOWpF4tjLGrjwgqdbIebEjlsvA== X-Google-Smtp-Source: AIpwx486UspC8ZbzAHxR0rnKnK8bC1XKQp9ETQJYOot2GNYIyc/FzwNohmJ2kJtqzSZIuy2ItuhKy81Ppa2UqjBUBmw= X-Received: by 10.223.176.98 with SMTP id g31mr13045400wra.256.1522857076269; Wed, 04 Apr 2018 08:51:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 4 Apr 2018 08:51:15 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 4 Apr 2018 16:51:15 +0100 Message-ID: Subject: Re: [pgAdmin4][RM#3155] Allow user to lock the Layout To: Victoria Henry Cc: Ashesh Vashi , Murtuza Zabuawala , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113c9c40133f73056907cb9f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113c9c40133f73056907cb9f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 4, 2018 at 4:46 PM, Victoria Henry wrote: > Hi Hackers, > > We just reread the issue in Redmine, and our take is a little bit > different. Looks like the problem the person is complaining the tabs > sticking to the mouse when clicked. We also experience that problem while > developing. > There isn't just one issue. Various people have asked for the ability to lock the view in the configuration they like. > > How hard would it be to eliminate the Drag and Drop of tabs in the curren= t > implementation? > Do we think this might be a problem for the majority of the users? > When it comes to removing features, I don't really care about the majority. Creating annoyance or inconvenience by removing working, useful features for even a small percentage of users is not something I consider an option unless absolutely essential. > > Thanks > Victoria & Joao > > On Wed, Apr 4, 2018 at 10:41 AM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: >>>> >>>>> >>>>> >>>>> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> On Tue, Apr 3, 2018 at 9:03 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < >>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Thanks Joao for reviewing. >>>>>>>>>> >>>>>>>>>> PFA updated patch. >>>>>>>>>> >>>>>>>>>> On Tue, Apr 3, 2018 at 1:11 AM, Joao De Almeida Pereira < >>>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>>> >>>>>>>>>>> Hello, >>>>>>>>>>> >>>>>>>>>>> On Mon, Apr 2, 2018 at 10:07 AM Murtuza Zabuawala < >>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> =E2=80=8BHello, >>>>>>>>>>>> >>>>>>>>>>>> Please find updated patch, >>>>>>>>>>>> >>>>>>>>>>>> Now layout will be locked after user updates its preferences, = w >>>>>>>>>>>> e have used =E2=80=8B >>>>>>>>>>>> templated variable in the javascript file >>>>>>>>>>>> =E2=80=8B because we do not have preference module or preferen= ce cache >>>>>>>>>>>> available when the page loads and panels gets rendered, >>>>>>>>>>>> =E2=80=8BI >>>>>>>>>>>> =E2=80=8B also >>>>>>>>>>>> made changes in JS tests as per Joao's review comments. >>>>>>>>>>>> >>>>>>>>>>> Looks like everything is working when we change the lock. >>>>>>>>>>> As a personal preferences I would prefer to see this in at leas= t >>>>>>>>>>> 2 commits, one that is related to the preference issue and anot= her one that >>>>>>>>>>> is related to this story. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> All the tests are working, but he linter is failing: >>>>>>>>>>> >>>>>>>>>>> /tmp/build/4a5630c2/pivotal-rm-3155/web /tmp/build/4a5630c2 >>>>>>>>>>> >>>>>>>>>>> ./pgadmin/misc/__init__.py:78: [E303] too many blank lines (2) >>>>>>>>>>> >>>>>>>>>>> 1 E303 too many blank lines (2) >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> 1 >>>>>>>>>>> >>>>>>>>>> =E2=80=8BFixed=E2=80=8B >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> @Dave/Pivotal team, >>>>>>>>>>>> The given patch is working fine for all the Tabs/Panels (all >>>>>>>>>>>> the panels from main window as well as from Query tool and Deb= ugger) but >>>>>>>>>>>> I'm facing an issue while handling the Browser tree section, I= t is a wcDocer >>>>>>>>>>>> frame and >>>>>>>>>>>> not a wcDocker panel >>>>>>>>>>>> . Like >>>>>>>>>>>> wcDocker panel, wcDocker frame do not provide any API so that = a developer >>>>>>>>>>>> can prevent drag-drop functionality on it. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> It's not working fine for me. For example, if I put the SQL Panel >>>>>>>>> on it's own below the properties/stats panels (so it looks like p= gAdmin 3 >>>>>>>>> used to by default), and then lock the layout, I can un-dock the = SQL panel >>>>>>>>> into a dialogue, but then cannot re-dock it. I can do weird thing= s with the >>>>>>>>> browser tree as well, probably because it's a frame as you say. >>>>>>>>> >>>>>>>> >>>>>>>> =E2=80=8BThat is expected behaviour =E2=80=8Bbecause once you drag= the panel out of >>>>>>>> the group of Panels then it becomes individual Frame, That is what= the >>>>>>>> author of the wcDocker replied on my question, >>>>>>>> *"A panel must either be initialized as movable or non-movable fro= m >>>>>>>> the beginning and never changed because it generates a different >>>>>>>> arrangement of elements depending. This feature should only ever b= e used >>>>>>>> within the onCreate method of the panel. I should probably have be= en more >>>>>>>> clear about this limitation in the documentation."* >>>>>>>> >>>>>>>> >>>>>>> So does it become a panel again if a second panel is added to the >>>>>>> new tab group? >>>>>>> >>>>>> =E2=80=8BNo, it stays Frame.=E2=80=8B >>>>>> >>>>>> As far as I understand Panel needs a Frame to render itself if it is >>>>>> not attached to the main docker instance.=E2=80=8B >>>>>> >>>>>>> >>>>>>> There must be some way we can lock a tab that's not part of a group= . >>>>>>> >>>>>> At a moment there is no way of =E2=80=8B >>>>>> locking frames out of the box :( >>>>>> =E2=80=8B >>>>>> >>>>> >>>>> Hmm, so the question becomes: do we include the lock feature, but >>>>> rename it to "Lock Tabs" or something similar, or leave it out altoge= ther? >>>>> It clearly doesn't do everything we want right now. >>>>> >>>> =E2=80=8BI would say lets include the feature by adding warning note t= hat this >>>> feature works with default layout only, And I don't think most user wi= ll >>>> try to drag drop Browser panel =E2=80=8B >>>> anyway, meanwhile I'll check what changes are required in main source >>>> code to make the Frame lock. >>>> >>> >>> Anyone else have any thoughts on this? Personally I don't like includin= g >>> half-baked features. >>> >> +1 >> >> -- Thanks, Ashesh >> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113c9c40133f73056907cb9f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Apr 4, 2018 at 4:46 PM, Victoria Henry <vhenry@pivotal.io&= gt; wrote:
Hi Hac= kers,

We just reread the issue in Redmine, and our take = is a little bit different. Looks like the problem the person is complaining= the tabs sticking to the mouse when clicked. We also experience that probl= em while developing.

There isn&= #39;t just one issue. Various people have asked for the ability to lock the= view in the configuration they like.
=C2=A0

How hard would it be t= o eliminate the Drag and Drop of tabs in the current implementation?
<= div>Do we think this might be a problem for the majority of the users?

When it comes to removing features,= I don't really care about the majority. Creating annoyance or inconven= ience by removing working, useful features for even a small percentage of u= sers is not something I consider an option unless absolutely essential.
=C2=A0
Thanks
Victoria & Joao

On Wed, Apr 4, 2018 at 10:41 AM, Ashesh Vashi <= ;ashesh.= vashi@enterprisedb.com> wrote:
On Wed, Apr 4, 2018 at 8:= 09 PM, Dave Page <dpage@pgadmin.org> wrote:


On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
On Wed, Apr 4, 2018 at 5:00 PM, Dav= e Page <= dpage@pgadmin.org> wrote:


On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
On Wed, Apr 4, 2018 at 2:47 PM, Dave Page &= lt;dpage@pgadmin.org= > wrote:

On Wed, Apr 4, 2= 018 at 7:20 AM, Murtuza Zabuawala <murtuza.zabuawala@ente= rprisedb.com> wrote:
<= div dir=3D"ltr">
Hi Dave,

On Tue, Apr 3, 2018 at 9:03 PM, Dave P= age <dpage@pgadmin.org> wrote:
Hi

On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Thanks Joao for review= ing.

PFA updated patch.

On Tue, Apr 3, 2018 at 1:11 AM, Joao D= e Almeida Pereira <jdealmeidapereira@pivotal.io> = wrote:
Hello,

On Mon, Apr 2, = 2018 at 10:07 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com= > wrote:
=

=E2=80=8BHello,

<= font face=3D"verdana, sans-serif" color=3D"#444444">
Please find updated patch,=C2=A0

Now layout will be locked after user updates its preferences, w
<= /font>
e have used =E2=80=8B
temp= lated variable in the javascript file
<= /div>
=E2=80=8B because we do not have preference module or prefe= rence cache available when the page loads and panels gets rendered,=C2=A0=E2=80=8BI
=E2=80=8B also=C2=A0
made changes in JS tests as pe= r Joao's review comments.
Looks like everything is worki= ng when we change the lock.
As a personal preferences I would pre= fer to see this in at least 2 commits, one that is related to the preferenc= e issue and another one that is related to this story.

=

All the tests are working, but he linter is failing:
/tmp/build/4a5630c2/pivotal-rm-3155/web /tmp/build/4a5630c2=


./pgadmin/misc/__init__.py:78: [E303] too many blank lines (2)

1       E303 too many blank lines (2)=C2=A0



=
There must be some way we can lock a tab that's not part of a grou= p.
At a moment there = is no way of =E2=80=8B
locking frames ou= t of the box :(
=E2=80=8B




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpr= iseDB UK: http://= www.enterprisedb.com
The Enterprise PostgreSQL Company





--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a113c9c40133f73056907cb9f--