MIME-Version: 1.0
In-Reply-To: 
 <CACCA4P0pnDmhGhxs-0mQvLR4HRr+OinrJFg9m41oWmwkq4exKg@mail.gmail.com>
References: 
 <CACCA4P0pnDmhGhxs-0mQvLR4HRr+OinrJFg9m41oWmwkq4exKg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 7 Oct 2016 12:49:10 +0100
Message-ID: 
 <CA+OCxoxw6dE=5vfz368v+1uagruN_p6tu87qbgrsiVmDgyhf5A@mail.gmail.com>
Subject: Re: [Patch][pgAdmin4]: RM#1577 - Debug option for
 function/procedure under package node
To: Neel Patel <neel.patel@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, applied. Couple of questions/points:

- If there is no body for a procedure, the error is handled somewhat
ungracefully - the message is displayed without line breaks, and the
debugger panel is left empty. Can we make that a little nicer?

- In pgAdmin 3 there's a "Debug package initialiser?" option on the
parameter dialogue. Is that shown for appropriate packages? I don't
have an example to hand to test with.


On Fri, Oct 7, 2016 at 11:55 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch file which contains function/procedure debug
> support under package node. (RM #1577)
>
> Do review it and let me know for any comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers