public inbox for [email protected]  

help / color / mirror / Atom feed

[pgadmin4][patch] Correct issue on external tables
2+ messages / 2 participants
[nested] [flat]

* [pgadmin4][patch] Correct issue on external tables
@ 2018-06-19 20:16  Joao De Almeida Pereira <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Joao De Almeida Pereira @ 2018-06-19 20:16 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

You can find attached a patch that corrects the RM #3431.

When trying to retrieve the DDL of an external table and exceptions was
being raised.

Thanks
Joao


Attachments:

  [text/x-patch] RM_3431.patch (858B, 3-RM_3431.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql b/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql
index a7f64a5f..25ebf96c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql
@@ -48,7 +48,7 @@ OPTIONS (
 )
 {% endif %}
 ENCODING '{{ table.pgEncodingToChar }}'
-{% if table.rejectLimit and table.rejectLimit|length > 0 %}
+{% if table.rejectLimit and table.rejectLimit > 0 %}
 {%   if table.errorTableName and table.errorTableName|length > 0 %}
 LOG ERRORS {% endif %}SEGMENT REJECT LIMIT {{ table.rejectLimit }} {{ rejectionLimit }}
 {% endif %}


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgadmin4][patch] Correct issue on external tables
@ 2018-06-20 00:01  Dave Page <[email protected]>
  parent: Joao De Almeida Pereira <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2018-06-20 00:01 UTC (permalink / raw)
  To: Joao De Almeida Pereira <[email protected]>; +Cc: pgadmin-hackers

Thanks, patch applied.

On Tue, Jun 19, 2018 at 9:16 PM, Joao De Almeida Pereira <
[email protected]> wrote:

> Hi Hackers,
>
> You can find attached a patch that corrects the RM #3431.
>
> When trying to retrieve the DDL of an external table and exceptions was
> being raised.
>
> Thanks
> Joao
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2018-06-20 00:01 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-06-19 20:16 [pgadmin4][patch] Correct issue on external tables Joao De Almeida Pereira <[email protected]>
2018-06-20 00:01 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox