Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayfLe-0007gd-5i for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 May 2016 12:59:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ayfLd-000670-JT for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 May 2016 12:59:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ayfLP-0005kP-QJ for pgadmin-hackers@postgresql.org; Fri, 06 May 2016 12:59:00 +0000 Received: from mail-ig0-x22c.google.com ([2607:f8b0:4001:c05::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ayfLN-0001cL-2V for pgadmin-hackers@postgresql.org; Fri, 06 May 2016 12:58:58 +0000 Received: by mail-ig0-x22c.google.com with SMTP id u10so44586316igr.1 for ; Fri, 06 May 2016 05:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=T45LuCVMIzI8ZZJ9/QSs4c+MQzhDAmWZXw4XGdnW31M=; b=iB3jjEx8WabYDFUlWTmVDY/8+zwVjaNRBdxb9uTNRnbs2Au6Qr0XcYQJ2/g62D5vNx SyWt8V3lmfIh+Uf91MhPsjUdAR2MOjWfWCu0/Wpxn3LVszE31c6WXwKV2maj3dNQ/gLR XnL3dk4DbHsuX9kC4GRoY48bkuf+QDEOf+EoDz3uqVKZ0N+f9g6m8DAKMaxiR49V9pKj r7zZQvn9r85MdwAEuS/lwoEaokWUhfomcN9dsUT7G9QatPzjVAl8kgX7Es0bCzSRTf5H OvV4r4nAzcxrpOdyBzJmOY/TFi1WZOOjeJqd9dDdYcq8r71iXTEUW6e5yZfmZ2/YRDD8 dJVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=T45LuCVMIzI8ZZJ9/QSs4c+MQzhDAmWZXw4XGdnW31M=; b=YEGfVKKYs5JEuOQhSjR4Lzf+eEg35uXiF7ukvMcy1EqS8nCwQhO4CxvRA2DuceS5y6 lHAbr+0Dng8Nr8Re6xE5oLLCapG45HijMELZu+pC6t7ppcnTNem4fY/k09wxJ3yIcNxw R5lhTB7HFIDWKWeyHzn3sQtX6E/S9eRM6RwZvlIffUzULbQczrL+xNOTTz2jwSfwMCQe 28fCLBnO0rkTdHsz3i3hp+yoDCfld8jgGcRy2rgw26A0DfiOeWvfxZEsFpJjXTK4kOq2 QM9NoisBf7wzM7d2/JzyJbEYxzpRuTTX0sDECPscEvjinT9cRR706aXStWV6mKTEpwaM zoIA== X-Gm-Message-State: AOPr4FUxg94YjkriiR/L01C2arrS25CREaadRMAeXF4mCBvagSQxH+jrUYXFTJHUxlmMXXiTGyTJTf7DpdIfXw== MIME-Version: 1.0 X-Received: by 10.50.186.136 with SMTP id fk8mr10594813igc.11.1462539534978; Fri, 06 May 2016 05:58:54 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Fri, 6 May 2016 05:58:54 -0700 (PDT) In-Reply-To: References: Date: Fri, 6 May 2016 13:58:54 +0100 Message-ID: Subject: Re: PATCH: Fixed typo in Server node From: Dave Page To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks - applied. On Fri, May 6, 2016 at 11:14 AM, Murtuza Zabuawala wrote: > Hi, > > Looks like below given commit has left a typo in the code, I=E2=80=99m ge= tting error > while updating any Server node, > > Commit: > 0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page > 2016-05-05 16:42:16 +0100 377) > node=3Dself.blueprint.generate_browser_node( > > Error: > return method(*args, **kwargs) > File > "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/server= s/__init__.py", > line 385, in update > server_type=3D'pg' # default server type > TypeError: make_json_response() got an unexpected keyword argument =E2=80= =98node' > > > > PFA patch to fix the issue. > > > > Regards, > Murtuza > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --=20 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers