MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D9+eq8auZ9SVOhU12xtTy29YaGSHitHfyTNfXocTK+gdw@mail.gmail.com>
References: 
 <CAM5-9D9+eq8auZ9SVOhU12xtTy29YaGSHitHfyTNfXocTK+gdw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 5 Sep 2016 17:07:32 +0100
Message-ID: 
 <CA+OCxoxxtk-eQD8iKwbrMwMgX8EKtckEJbYGxNcVD5tzShpm2Q@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: Wrong listing of directories
 in File Manager in Windows Only.
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, applied.

On Mon, Sep 5, 2016 at 10:51 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Issue:
> FileManager: when Select File dialog is opened in query tool in Runtime
> Mode, it was listing wrong directory. instead it should list drives such as
> C:\, D:\, E:\ etc if no STORAGE_DIR path is set in config_local.py. This is
> a regression of RM 1937.
>
> Solution:
> we do list drives, If platform is Windows and If self.dir is set to None,
> but self.dir is set to empty string inside __init__ constructor. This is the
> reason it wasn't listing drives.
> I have taken care it in this patch and tested it for following platforms:
> Windows,
> Ubuntu and
> Mac.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers