Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNIYk-0000Fl-Bn for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 11:42:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNIYj-0005TY-V2 for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 11:42:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNIYW-00058t-TK for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 11:42:20 +0000 Received: from mail-io0-x234.google.com ([2607:f8b0:4001:c06::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bNIYT-0005nU-69 for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 11:42:20 +0000 Received: by mail-io0-x234.google.com with SMTP id q83so43665141iod.1 for ; Wed, 13 Jul 2016 04:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LF6YpvxCCEAbTMGvMKWQGtVEIO/sZ7moZ7EOh7zZsfE=; b=EOS1Nf2NCFcal1O5LahZHn6hQ1lJdskz22siq7Xm/FU05OHV6oAoMZ6QSelhNpVIf4 XBtvvWAo1Lhg7l3IhoeH97Eio09frrmJE+43A3El/IQ+7XFa85oA2HtpjQoHxm/ofOBl SpioWz5TlpsEj00anczBc1bI0rKALZB2CInbb1aZH4M6NuD3lUzUeAUTVqzhosRvMIHL 7OYjGfMdJuzXMwkMW1+mN3WWSFmflOjbZjF6IN8jI05lG0dGobefTmQiMikeZCds9szT N3Ozk60upv1jotVYVHE7AyeQq9Tqzn6nTkCDs/xnW05sbtINIvQHnd89V8nyKs120bQf 2DNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LF6YpvxCCEAbTMGvMKWQGtVEIO/sZ7moZ7EOh7zZsfE=; b=fD1ZyBoxGHICP+W9CEFpzLxg1gCY4nseB/1g/iEymofxZCdJlwts9cMnbGIQoyFZkq 0yd2UhhcvbI7pmud8BZcL8f68pTxcWb74F+0o2pej90yIsi+VpV5KCCSGML7UdDsPoVC Ca0Kk+9bNa7eA3zlUGD38jc81tfP9C6eyWL4iXVWEKluF/+QZYt7aLREDmSt4NZSwA1f AMPuDbvTVLUddii/OxKKT724fnl9f2pVW64aweX5Cn9mjKZMu57SJNBpmeVBJIM9F9Eb 0JK4sdYQsIO8R0nJKERMiMeSqLRgdU/kKvsLsheo9y9ICZa9rX+X4st3CrrBRT9kQ/vW x/7Q== X-Gm-Message-State: ALyK8tLyK2cI5HP0h2mvQYm1HCMVT5CLY+cLebpcahV+Y8+aLi2eowpu4V23LoMgSCPR8eHVNbYdTRIS5yeeAg== X-Received: by 10.107.201.138 with SMTP id z132mr7933364iof.156.1468410135546; Wed, 13 Jul 2016 04:42:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Wed, 13 Jul 2016 04:42:15 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 13 Jul 2016 12:42:15 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM#1420 - Reverse engineered SQL incomplete for Databases To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, applied. On Mon, Jul 11, 2016 at 10:58 AM, Surinder Kumar wrote: > Hi > > Please find attached patch with fix and review. > Included missing Create and Drop comments in generated sql query. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers