Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values
Date: Thu, 11 May 2017 09:59:30 +0100
Message-ID: <CA+OCxoxyPmmSHO=1EbJbbeEqFv-XN9eUEwA4hj4FG_qphGFwMQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozX9ea6b6a6Jmwgf5m0JNybZje5HGe27--bDg1t1LP8iA@mail.gmail.com>
References: <CAM5-9D_SSL81uT4AqsRr8WPABWA6S-iE34OxLb8YqfVN3myeJg@mail.gmail.com>
	<CA+OCxoySjV87N+YEkhXRzWaaGNCX4o+KuKnVGrYhLuWYeDx+SA@mail.gmail.com>
	<CAM5-9D8MdAqvix74_K+eMkeGkP7r4Aost1Uqz4hupMRPxwqzAw@mail.gmail.com>
	<CA+OCxoxkfbwJaWgCTTZ7eqrkv7Y49jU2EUmDsH_5raZqSFwZsA@mail.gmail.com>
	<CAM5-9D_ZEysH0ewuCoOoon18mim_G9r-2es=+MbyYXnsLqrTEw@mail.gmail.com>
	<CAM5-9D-kZEWrqgxr6-PyB_YVCdovJm8PpXGDpdfcpo65t_Sakg@mail.gmail.com>
	<CA+OCxoyFLFK9nxbpTGJ=f2em1D_fmmFUaxh7LgUeNGWQr3fj6w@mail.gmail.com>
	<CAM5-9D9Pm3bGgiv+fSjfr3Ouc-puMS3m6x4N+vGdELmWVJNcig@mail.gmail.com>
	<CA+OCxozDsoz0NX+4ywBH4gvyHQ2=Lk0f9QT8q2Mj0v=5p+5B_A@mail.gmail.com>
	<CAM5-9D-nWM3i-krc0KbOcAtDQNMefJs+xOFkgP0oaV84wPBbAw@mail.gmail.com>
	<CA+OCxoyNm6zP-=ozL2eTaGpsVgggkp5stU2ZyKhdTzspkAc8sQ@mail.gmail.com>
	<CAM5-9D_76iVD-C+80_7WL1y9skxo5ntmoQbKVOVaMb+0Xa90yg@mail.gmail.com>
	<CA+OCxowq-52VR5hTgBTGa3zGi6NVkAmM2AoGDLW2_wm_QdL0hA@mail.gmail.com>
	<CA+OCxox6_JojQkaujk4qE=egt5Zj6hYe0V33kLYTxQhPMH4H2Q@mail.gmail.com>
	<CAM5-9D8TfBb5YXvEcyd+1=oarWVYOFnN-DVYNx_N3zNRKPGbdg@mail.gmail.com>
	<CA+OCxoxGQfP-HXTfBF+hDLvkex1YDQA+Xovppt6ogT+H8juXGw@mail.gmail.com>
	<CAM5-9D9JdEim47AnTVKKhqOBJsbxoO+ufwE7FtPya9HmC6j8Zg@mail.gmail.com>
	<CA+OCxozX9ea6b6a6Jmwgf5m0JNybZje5HGe27--bDg1t1LP8iA@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Ooops, managed to hit send too soon.

... it leads to failed updates such as:

2017-05-11 09:55:47,570: SQL pgadmin: Execute (void) for server #1 -
CONN:2096775 (Query-id: 4540472):
UPDATE public.defaults SET
data_default_no_nulls = 'asas' WHERE
;
2017-05-11 09:55:47,577: ERROR pgadmin:
Failed to execute query (execute_void) for the server #1 - CONN:2096775
(Query-id: 4540472):
Error Message:ERROR:  syntax error at or near ";"
LINE 3: ;


On Thu, May 11, 2017 at 9:58 AM, Dave Page <[email protected]> wrote:

> Hi
>
> There seems to be couple of bugs in this;
>
> - When creating a new row with my test table, if I click in the id column,
> don't change anything, then click in another column, the ID column value
> changes from [default] to [null], making it impossible to save that row
> with the default value. In this case I would expect it to stay at [default]
> unless I explicitly entered a value.
>
> - When I add a new row, but leave the id as [default], the row is saved,
> but the [default] marker changes from gray to black (but only in the id
> column.
>
> - I'm able to edit a freshly added row immediately after saving but before
> refreshing. This shouldn't be allowed if we don't know what the primary key
> value is, as it leads to failed updates such as:
>
>
> On Wed, May 10, 2017 at 9:52 AM, Surinder Kumar <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> Please find attached patch for RM only.
>>
>> *Changes:*
>>
>>  - All formatters now handles both [null] and [default] values
>>
>>  - the cell values are validated on server side as in pgAdmin3.
>>
>>  - added light grey color for cells with [null] and [default]
>> placeholders.
>>
>> On Wed, May 10, 2017 at 2:12 PM, Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Wed, May 10, 2017 at 9:39 AM, Surinder Kumar <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> On Wed, May 10, 2017 at 2:06 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Any chance we can get this wrapped up today Surinder?
>>>>>
>>>> I have fixed RM case, I am currently writing its feature test cases
>>>> which is taking some time.
>>>> Should I send patch for RM case only? I will try to complete test
>>>> cases by today eod.
>>>>
>>>
>>> Yes please.
>>>
>>> Thanks!
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (25+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values
  In-Reply-To: <CA+OCxoxyPmmSHO=1EbJbbeEqFv-XN9eUEwA4hj4FG_qphGFwMQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox