Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpxSQ-0000KR-1n for pgadmin-hackers@arkaria.postgresql.org; Fri, 30 Sep 2016 13:02:30 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bpxSP-000559-Kx for pgadmin-hackers@arkaria.postgresql.org; Fri, 30 Sep 2016 13:02:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bpxSP-000551-9a for pgadmin-hackers@postgresql.org; Fri, 30 Sep 2016 13:02:29 +0000 Received: from mail-it0-x22d.google.com ([2607:f8b0:4001:c0b::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bpxSJ-0002NX-Te for pgadmin-hackers@postgresql.org; Fri, 30 Sep 2016 13:02:28 +0000 Received: by mail-it0-x22d.google.com with SMTP id r192so42899924ita.0 for ; Fri, 30 Sep 2016 06:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JKtwDy7Q3JGqPSOSO5/1PARHSFZzl/5FF4QBsfcU9Mk=; b=AwHRf5lBzbZVeMzcphvx7HW0Nz2trKox8K+ppgI7ViG/Dgnb746o7AZHaDfsneaBnB PWxDhlEsDlG6O8ySCfHexfIBA5sKfwtAWwjAySRLfW51SeFV/VzWgjGZrtYjvnRq/hxA jD02yDXe7p+vFuhcD7pIPeczI0eQjU9mEJcArL1RNMtSUnxtrTSTkrzq24u7M6JzpbCN qLZBC51g0PWPRHMBE1hTvfPfmKCC0s1iyHb5O41ryXzlVg4V3mITBngygUrLj6XNKSJz CgAIWoH8MM0UCxKIPJH4VZNStjk4Y/rB14gapNVgohDOZtspHaomehpfTL7P+6q8iQSv QeDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JKtwDy7Q3JGqPSOSO5/1PARHSFZzl/5FF4QBsfcU9Mk=; b=hy4ufXWBQZrVfFdFBosABABp7rtGZ5mzlvhfuq/iCC8v7gBhUpLOJf0ad3BGG7kuZv 16/ar7bVzIBHVhbXF4IZWBS1ztTpY56fFIl6+xzuhRHXkkltsbI5Gn0qqAut2OMfm0Qi M5D3Wjca3y4QWls9pZsD9Xtx/IlsqQ5W4ZtohKbZ+mnMl6zKqQNx9oGKc0IEyGN2mXFF fHLtQfaUj/Caj3KiW4VnQPHyj7ekZBsaaiV7EMZdTy3xIJwgTm3JfINrMMMwAG0q1LEZ TklFP5amNbN5NKiQ12iRAnAbC9CV76zW4nq5XRMQoXp+uALNM+F785hwmP3ZwSrJEdRW Cn4w== X-Gm-Message-State: AA6/9Rkdxudf5E2FHG8AiY3flaeEs74/BjEnB2b76G7moxJ4k8jNNzegiRvHFWxKkGJITdA6DhGaSg6bdeYRkQ== X-Received: by 10.107.11.101 with SMTP id v98mr8637714ioi.145.1475240541937; Fri, 30 Sep 2016 06:02:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Fri, 30 Sep 2016 06:02:21 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 30 Sep 2016 14:02:21 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Is there an RM for this? If not, can you create one please? I want to be sure we capture all notable changes in Redmine. Thanks! On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar wrote: > Hi > > When we add new server and enter an invalid port, it validates and display > error message, but sometimes it doesn't unset errorModel when a valid value > is entered. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers