Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ffOm8-0003jb-CU for pgadmin-hackers@arkaria.postgresql.org; Tue, 17 Jul 2018 12:08:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ffOm7-0001n7-4d for pgadmin-hackers@arkaria.postgresql.org; Tue, 17 Jul 2018 12:08:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ffOij-0007jy-Dx for pgadmin-hackers@lists.postgresql.org; Tue, 17 Jul 2018 12:04:45 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ffOif-0006C7-52 for pgadmin-hackers@postgresql.org; Tue, 17 Jul 2018 12:04:44 +0000 Received: by mail-wr1-x442.google.com with SMTP id j5-v6so988700wrr.8 for ; Tue, 17 Jul 2018 05:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+qGOFNBgJHyAf/kufm/76bUydChZvY4/aQDjpQUMleY=; b=atqci5ZcDs5gZvvhUrEpCwf5d9agnKSJjWPJ02S94cE93jGJi5OyIBtbesFzn9S/Sy +ssATaPb+grzrp/WFtykbQ0i5gRJ65xuncudOP7JPTaajgS0YW/H5XobQFEDeaLnvleB LqCdHY1hHQmLiRC7dzMl5gR6qzWvlHPRTALLlvRBxwSqpcFv+r1I8r6caDqKf0UI7qHL u3bkMcYXQgae/hvrCWbCq4IubfvqX+aN1SFSBWnNzNhN320UhTBghu8ZnLcNcIFvYEUP 5/vsP52lctXNzYwHscY1nMz20TIpfPH73DgmJEzSJuatoWEZ+dNd8TnptAoOfv4LtHGL 0/1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+qGOFNBgJHyAf/kufm/76bUydChZvY4/aQDjpQUMleY=; b=XSjpYhHt13T6OrRqT2gQyF0vQpVXrvWuN9H+z5avNj3Gya9Kx+TWGd8OlkmYTTyuOu SzZfZss44R+CpLmZMzW00VNjIG3zAoZ7ZMNEzXBi9CPK4vbyhzJ24oY6aZHhvpGbNdXk 5tZtMDfCP8gAbdW1RdSklJaVy6kzqgRj1beDsWSJdMsuhVCwDvDJgfU/NWjpAfTwONn9 Yfat3vt2xZ4skZHRn+PtvApyKNzFI6qO0qN7YMe7WFyAc1Yd+BT2CYcWaduN85gVSgb2 MhX992yYU0DbHjtkP8nVhdO8tvXFRp0mkiiPFKk5NyfwlbzxtsbW33pODhGMEYxP8JxW KJ3A== X-Gm-Message-State: AOUpUlFXCeo2OtM+9V3ndsGX4cziP18DENKH5VFDwWL5h4ndr1nYed/e mZ2i5WbzT/zMIHMXGI20M1uZ/DvsZRjXj1R6NIrUvg== X-Google-Smtp-Source: AAOMgpclsBzJS5ya3xmGRNlDQOpiko2LvO7LXNHLcX6s9ubWTiXUMzV/EHESrDNIoRk3jpzD+v40h41Htgn5S980bgY= X-Received: by 2002:adf:f091:: with SMTP id n17-v6mr1245084wro.49.1531829080395; Tue, 17 Jul 2018 05:04:40 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:89d1:0:0:0:0:0 with HTTP; Tue, 17 Jul 2018 05:04:39 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 17 Jul 2018 13:04:39 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d To: Akshay Joshi Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000031a4bc057130c000" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000031a4bc057130c000 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Tue, Jul 17, 2018 at 9:01 AM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the issue on Windows operating system with > "--format=d". > > On Fri, Jun 29, 2018 at 7:46 PM, Dave Page wrote: > >> Thanks, applied. >> >> On Fri, Jun 29, 2018 at 10:24 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached updated patch. >>> >>> Thanks, >>> Khushboo >>> >>> On Mon, Jun 25, 2018 at 8:07 PM, Dave Page wrote: >>> >>>> >>>> >>>> On Mon, Jun 25, 2018 at 3:33 PM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Mon, 25 Jun 2018, 19:47 Dave Page, wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi < >>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Please find the attached patch for RM #3309 - Backup does not work >>>>>>> with --format=d. >>>>>>> >>>>>>> Fixes in the patch : >>>>>>> >>>>>>> 1. Format = directory fix for Backup and Restore utilities >>>>>>> 2. Test cases for format = directory >>>>>>> 2. File manager fix - The selected directory was not properly >>>>>>> populated in the text box >>>>>>> >>>>>> >>>>>> The patch disables the file picker button if you select Directory >>>>>> format. This seems like poor behaviour; I think we need to modify the >>>>>> dialogue to allow a directory to be selected. >>>>>> >>>>>> >>>>> In the directory format, which ever the folder name given, that will >>>>> be created by pg_dump, so I have disabled it. >>>>> >>>> >>>> Sure, but I can't even browse to the location I want to put it now - I >>>> have to manually type in the path. We just need to allow selection of the >>>> directory that will contain the directory. >>>> >>>> >>> Fixed. >>> >>>> 3. Refactoring of File manager JS file >>>>>>> >>>>>> >>>>>> That's somewhat more readable. Can we add tests? >>>>>> >>>>> Will look into it. >>>>> >>>> >>>> Added. >>> >>>> Thanks. >>>> >>>> >>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000031a4bc057130c000 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Tue, Jul 17, 2018 at 9:01 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,=C2=A0

Att= ached is the patch to fix the issue on Windows operating system with "= --format=3Dd".

On Fri, Jun 29, 2018 at 7:46 PM, Dav= e Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Fri, Jun 29, 2018 at 10:24 AM, Khus= hboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

<= /div>
Please find the attached updated patch.

= Thanks,
Khushboo

On Mon, Jun 25, 2018 at 8:07 PM, Dave Page <dpage@p= gadmin.org> wrote:


On Mon, Jun 25, 2018 at 3:33 PM, Khushboo Vashi <khushboo.= vashi@enterprisedb.com> wrote:


On Mon, 25 Jun 2018, 19:47 Dave Page, <dpage@pgadmin.org> wrote:
Hi

On Mon, Jun 25, 2018 at 1:23 PM, K= hushboo Vashi <khushboo.vashi@enterprised= b.com> wrote:
Hi,

Please find the attached patch for RM #3309= - Backup does not work with --format=3Dd.

Fixes i= n the patch :

1. Format =3D directory fix for Back= up and Restore utilities
2. Test cases for format =3D directory
2. File manager fix - The selected directory was not properly popu= lated in the text box

The patch= disables the file picker button if you select Directory format. This seems= like poor behaviour; I think we need to modify the dialogue to allow a dir= ectory to be selected.
=C2=A0
In the directory format, which ever t= he folder name given, that will be created by pg_dump, so=C2=A0 I have disa= bled it.

Sure, but I can= 't even browse to the location I want to put it now - I have to manuall= y type in the path. We just need to allow selection of the directory that w= ill contain the directory.
=C2=A0
<= /div>
Fixed.=C2=A0
3. Refactoring of File manager JS= file

That's somewhat more = readable. Can we add tests?=C2=A0
Will look into it.

Added.=C2=A0
Thanks.
=C2=A0
--
Dave Page
Blog: = http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB = UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= br>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsna= ke

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany



<= /div>--
Akshay Joshi
Sr. Software Architect
<= br>

Phone: +91 20-3= 058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--00000000000031a4bc057130c000--