Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewo1c-0001XE-1B for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Mar 2018 11:59:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewo1a-0002po-U6 for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Mar 2018 11:59:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewo1a-0002oH-Is for pgadmin-hackers@lists.postgresql.org; Fri, 16 Mar 2018 11:59:54 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewo1W-0007uQ-Lg for pgadmin-hackers@postgresql.org; Fri, 16 Mar 2018 11:59:54 +0000 Received: by mail-wm0-x231.google.com with SMTP id a20so2435930wmd.1 for ; Fri, 16 Mar 2018 04:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nVTun2S0LMtyaGqu5dWu1RoEdO2zK/Fis0eD3S0udEI=; b=JKDpvjOoGFLMcU7YWkkVv9XjOkmls7qkd2mHtgx16wJpZ7rbwIVTjyLSsRtaWgUHXg L8KNNmgSOosfM6eb5nXYLkEBdfWxxrBU0eHEq8NQ6FTyMtADXrs1vRZphYnBRZ7Md7HF CdjsiQfR8AcR835fXe8mYYJQkfHBgdGjMyIwAL1/EQ7ftxCBhFay2mjOVzVviBnzLVyQ md8dwHKoJ1jEZ0lzIwrrWxxFbB79anJQV8tQjnMk19gw1WY2JN6DWJndZ4WKhhEChja8 wiu/ELyDhRMVu8HXJsRs+wdjR6Xt15Eu7idSUi3+AKNcH9cUjs9UMg8NQjkufnWzN+cM Livw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nVTun2S0LMtyaGqu5dWu1RoEdO2zK/Fis0eD3S0udEI=; b=mUoRWDs/0SQXZW5W33k0PMY4500lx8fPrsFgyHizS1LKmJkNMn4V77hXS/0eiG6q7g DDQAwxYppPzp3MyhzIluWWWdwhDmdRbNy/EymmxLo1rwUWT9T0K06/8U9bo2vV42ro8D rv3S3MYdsx0hl8N9eU2JjotLaMn7rWtgG8KLCyKF83fEepwYcH10SfDSkQOJKHK6j4y/ FS10kqW8xiVTUlFiPsOsZSYs1SaNeKdAgmXX/3MrC412tsdLzhhZvvd3kv6fY1CoDliJ +jZ3wAyouAq/t8t9S7Qh5phbbLeZNO4QcjCRQV9iDigY6g8Q6eBU4+gzMTONYa9hdIQq WhLQ== X-Gm-Message-State: AElRT7EY6T+zMUva3e+r1iWwV6M69xOzgVNUjHj1SaM88hiEjedwXB5Y 6dtMnnuTeRq42e/HiO93rWhN6e173HxR8BYJIGp1og== X-Google-Smtp-Source: AG47ELuGJjOEzdKgHkxCW/m1ID2+r91BsXoDmzVWoOCsCh3C2fthELCEdtKWtyscqdVF/kKqzZTvZShuIPsik+8hksw= X-Received: by 10.28.61.65 with SMTP id k62mr1665377wma.140.1521201589199; Fri, 16 Mar 2018 04:59:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 16 Mar 2018 04:59:48 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 16 Mar 2018 07:59:48 -0400 Message-ID: Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn To: Joao De Almeida Pereira Cc: Murtuza Zabuawala , Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114af6ce5b44730567865886" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114af6ce5b44730567865886 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Well config_local isn't part of the source tree, so it's easier to just ignore that. I'm happy with ignoring the migrations as well. On Friday, March 16, 2018, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello, > Personally I believe we should fix the config_local pep issues and just > ignore the migrations. Specially because the migration file should not ha= ve > a lot of python code. > > Thanks > > On Thu, Mar 15, 2018 at 3:32 PM Dave Page wrote: > >> On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala > enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Thu, Mar 15, 2018 at 9:42 PM, Dave Page wrote: >>> >>>> >>>> >>>> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala >>> enterprisedb.com> wrote: >>>> >>>>> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I have just noticed, we're ignoring migrations directory too. >>>>>>> Should we not also check code styling for migrations directory? >>>>>>> >>>>>> >>>>>> Yeah, I was going to ask about that :-). Is there a specific reason >>>>>> why we're ignoring the migrations Murtuza? >>>>>> >>>>> =E2=80=8BTo ease writing long SQL's. >>>>> >>>>> >>>> >>>> Perhaps we could just skip the long line check for those files? >>>> >>> =E2=80=8BWe have to create separate config for that and then run pycode= style >>> using that config for migration.=E2=80=8B >>> >>> =E2=80=8B1) pycodestyle --config=3D.pycodestyle >>> =E2=80=8B2) pycodestyle --config=3D.pycodestyle_migration >>> >>> something like that, Because I checked the documentation and I didn't >>> find any option to have single config file for individual directories. >>> >> >> Urgh. I suppose we could keep a config file in the migration directory, >> but even then, we'll get two sets of stats out for running two tests. >> >> >>> >>> >>>> >>>>> >>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> Ashesh Vashi >>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> >>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>> >>>>>>> >>>>>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> Ignore config_local.py and config_distro.py when running PEP-8 >>>>>>>> checks. >>>>>>>> >>>>>>>> Branch >>>>>>>> ------ >>>>>>>> master >>>>>>>> >>>>>>>> Details >>>>>>>> ------- >>>>>>>> https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdiff;= h=3D >>>>>>>> 53ae960aeba0dde6109b91c171f22758b1b04ebe >>>>>>>> >>>>>>>> Modified Files >>>>>>>> -------------- >>>>>>>> web/.pycodestyle | 2 +- >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114af6ce5b44730567865886 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Well config_local isn't part of the source tree, so it's easier to = just ignore that. I'm happy with ignoring the migrations as well.
On Friday, March 16, 2018, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello,
Personally I b= elieve we should fix the config_local pep issues and just ignore the migrat= ions. Specially because the migration file should not have a lot of python = code.

Thanks

On Thu, Mar 15, 2018 at 3:32 PM Dave Page <dpage@pgadmin.org> w= rote:
On Thu, Mar 15, 2018 at 12:25 P= M, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb= .com> wrote:
Hi Dav= e,
<= br>
On Thu= , Mar 15, 2018 at 9:42 PM, Dave Page <dpage@pgadmin.org> wro= te:
<= br>

On Thu, Mar 15= , 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@<= wbr>enterprisedb.com> wrote:
On Thu, Mar 15, 2018 at 4:53 PM, Dave Page = <dpage@pgadmin.= org> wrote:
<= div dir=3D"ltr">Hi

On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vas= hi@enterprisedb.com> wrote:
Hi,

I have jus= t noticed, we're ignoring migrations directory too.
Should we= not also check code styling for migrations directory?

Yeah, I was going to ask about that :-). Is the= re a specific reason why we're ignoring the migrations Murtuza?
=E2=80=8BTo ease writing lon= g SQL's.
=C2=A0

Perhaps we could just skip the long line check for those files?
=
=E2=80=8BWe have to create= separate config for that and then run pycodestyle using that config for mi= gration.=E2=80=8B
=C2=A0
=E2=80=8B1) pycodestyle --config=3D.pycodest= yle
= =E2=80=8B2)=C2=A0pycodestyle --config=3D.pycodestyle_migration

<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">something = like that, Because I checked the documentation and I didn't find any op= tion to have single config file for individual directories.=C2=A0

Urgh. I= suppose we could keep a config file in the migration directory, but even t= hen, we'll get two sets of stats out for running two tests.
=
=C2=A0

=C2=A0
=C2=A0

--

Thanks & Reg= ards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Po= stgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
Ignore config_local.py and config_distro.py when running= PEP-8 checks.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdiff;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe

Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)





--
Dave Pag= e
Blog: http:/= /pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprise= db.com
The Enterprise PostgreSQL Company

<= /font>



--
Dave Page
Blog: http://pgsnake.blogspot.com
T= witter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise P= ostgreSQL Company

=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company

--001a114af6ce5b44730567865886--