Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hW4sj-0007uh-SH for pgadmin-hackers@arkaria.postgresql.org; Wed, 29 May 2019 20:09:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hW4si-0004h3-6l for pgadmin-hackers@arkaria.postgresql.org; Wed, 29 May 2019 20:09:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hW4sh-0004gu-Ob for pgadmin-hackers@lists.postgresql.org; Wed, 29 May 2019 20:09:04 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hW4sa-0000cz-Gz for pgadmin-hackers@postgresql.org; Wed, 29 May 2019 20:09:02 +0000 Received: by mail-it1-x142.google.com with SMTP id i63so1381868ita.3 for ; Wed, 29 May 2019 13:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jnZS7CNcWSmrt4mB0MQDO5XPt7r66nIfZwbNXbk0mck=; b=HovOOw5ByGE6aDdWY5oby+IZ3k2X0cJu/8Gj0/c+IdKwqVzX5dZYrLCBjxu4oYVLCO A6un3bd5oUXAdmMVxzo+YvTjJ0N2XoiNA2SAg88uhKIzwrvTAJJtkW/W4MFfccfC1+6P AzHouHJZCdEDU5hl2mfHsBEFnTRCLoGoxDPESQHlTXFWKu7D0v6oO+WHszm7GINZcN/A hSjvG1ofgH5xqe8oF239x07XRmK0ZA7C92FdRR4V9VcT0r0W0oVEf5yf+/1JFpFXM5o2 Tf/m46fdx4gP1EYezbZ+2SvFusjnJ806HQwatdLv5GK3AE78MKRIpqVOccZlphVF6faF MOIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jnZS7CNcWSmrt4mB0MQDO5XPt7r66nIfZwbNXbk0mck=; b=EHbIVE0dAWuiQI/DJqdM5OAsyF8MompSbhheWIuLn8IQFcOssRK+GR3014bBWQFGbr PbtnQbXXXXKFnipfILX76rHGuNCtAbHtJ6zJQyNdxmHjg1GKQ2Q1yUMA6svVTaRUv/5v DcEzGPmcmujxkgbo5hT8WgodFER1dN12vt+K7jFy58qbzgYH7DOEmuXSwACRsBy+Pohv 1QGjlqx/o0dxpy0SVfjIF6ljCTbzPu6aEoX0IqTJOFDwRvPw3fKEjFs1Cu5WyIijC0Ci yGj6eaZMnBO5URfA/svJqc32yaX9csc4dBjoTq8s4Fc98TJdB1NfN2uacbhhP0ogJXF7 41Ig== X-Gm-Message-State: APjAAAWjuG1AVdfDMJG4A5ftJClDrUlKr0dlLTp5ZnvkrlB1hvdefd8S 5n7qmDUv0pNJnyisO5RAPPjuORpeUoHFyrBhpxeWqw== X-Google-Smtp-Source: APXvYqwjP8aqpS9f+aKWpu7sAOcdgzuNyoJABCoD6I5tyzGZ1uzsTvpmnJblk6W0SX+lDfGNQcDVdke7AXRWugvPGOg= X-Received: by 2002:a24:9d94:: with SMTP id f142mr31421itd.179.1559160535582; Wed, 29 May 2019 13:08:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 29 May 2019 16:08:42 -0400 Message-ID: Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility) To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000df24a4058a0c5945" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000df24a4058a0c5945 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > On Thu, May 23, 2019 at 1:31 PM Dave Page wrote: > >> Hi, >> >> On further testing, this doesn't seem to be working as expected. >> Alt+Shift+] or [ in the query tool are typing =E2=80=99 and =E2=80=9D an= d not changing the >> tab. If I switch to a non-input tab (e.g. History), they still don't wor= k. >> > I am not able to simulate the quotes problem, but I have made a few > corrections to fix the switching. > Attached is the updated patch, kindly review. > Alt+Shift+[ (or ]) don[t work at all for me now :-( > >> Alt+Shift+Tab changes the panel successfully though, and does cause the >> flash as expected. >> >> I'm using Chrome 74.0.3729.131 on Mojave. >> >> On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Attached is the updated patch with doc changes. >>> >>> On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is the patch to fix the accessibility issue in query tool. >>>>>> >>>>>> The query tool can be completely restructured unlike previously wher= e >>>>>> query tool used to stick at top and other tabs in the bottom. >>>>>> - I have added a new shortcut to switch between frames if in query >>>>>> tool the tab positions are changed. On switching the frames, the fra= me will >>>>>> blink to show it is focussed. >>>>>> - In the frame, you can switch tab same as previous. The tabs in SQL >>>>>> editor are cyclic now, which means if you execute shortcut to go rig= ht on >>>>>> the last tab then it will cycle to first tab. >>>>>> - I have also changed the default shortcut to switch between tabs >>>>>> from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we h= ave in >>>>>> browser tabs. >>>>>> - Similar changes done for debugger also. >>>>>> >>>>> >>>>> Shouldn't there be documentation changes to go with this? >>>>> >>>> Yes, definitely :P >>>> Will send the updated patch. >>>> >>>>> >>>>> Otherwise, it seems to work :-) >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000df24a4058a0c5945 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal &l= t;aditya.toshniwal@ent= erprisedb.com> wrote:
Hi,

On Thu, May 23, 2019 at 1:31 PM Dave Page <dpage@pgadmin.org&= gt; wrote:
Hi,

On fur= ther testing, this doesn't seem to be working as expected. Alt+Shift+] = or [ in the query tool are typing=C2=A0=E2=80=99 and =E2=80=9D and not chan= ging the tab. If I switch to a non-input tab (e.g. History), they still don= 't work.=C2=A0
I am not able to si= mulate the quotes problem, but I have made a few corrections to fix the swi= tching.
Attached is the updated patch, kindly review.= =C2=A0

Alt+Shift+[ (or ])= don[t work at all for me now :-(
=C2=A0

Alt+Shift+Tab changes the p= anel successfully though, and does cause the flash as expected.=C2=A0
=

I'm using Chrome=C2=A074.0.3729.131 on Mojave.

On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi,

=
Attached is the updated patch= with doc changes.

On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal &l= t;ad= itya.toshniwal@enterprisedb.com> wrote:
Hi,

On Tue, May 21, 2019 at 5:32= PM Dave Page <dp= age@pgadmin.org> wrote:
Hi

On Tue, May 21, 2019 at = 10:01 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:<= br>
Hi Hackers,

Attached is the patch to fix the access= ibility issue in query tool.

The query tool= can be completely restructured unlike previously where query tool used to = stick at top and other tabs in the bottom.=C2=A0
- I have added a new shortcut to switch between fr= ames if in query tool the tab positions are changed. On switching the frame= s, the frame will blink to show it is focussed.=C2=A0
- In the frame, you can switch tab same as pr= evious. The tabs in SQL editor are cyclic now, which means if you execute s= hortcut to go right on the last tab then it will cycle to first tab.
<= div style=3D"font-family:verdana,sans-serif">- I have also changed the defa= ult shortcut to switch between tabs from Shift+Ctrl+ArrowKeys to Shift+Ctrl= +[ and ] similar to what we have in browser tabs.
- Similar changes done for debugger also.

Shouldn't there be documentation c= hanges to go with this?=C2=A0
Yes, definitel= y :P
Will send the updated patch.=C2=A0

Otherwise, it seems to work :-)

--
Dave Pag= e
Blog: http:/= /pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprise= db.com
The Enterprise PostgreSQL Company


--
=
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseD= B India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Comp= lain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpr= iseDB UK: http://= www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000df24a4058a0c5945--