Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhcSx-0001Dw-CW for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 13:00:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bhcSw-0006b0-U6 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 13:00:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bhcSw-0006at-FG for pgadmin-hackers@postgresql.org; Wed, 07 Sep 2016 13:00:34 +0000 Received: from mail-it0-x236.google.com ([2607:f8b0:4001:c0b::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bhcSr-0000SU-8E for pgadmin-hackers@postgresql.org; Wed, 07 Sep 2016 13:00:33 +0000 Received: by mail-it0-x236.google.com with SMTP id e124so19249916ith.0 for ; Wed, 07 Sep 2016 06:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tLo134QmF2yDpD4yJcUFANSZLY7zpsjP/RmGhsSgIBM=; b=ounfY/CRKC/m4eQgCtfX98cvJSfaVI/xsBJhIJjElRk7/XdW5avUtorUawzMKk0Mra BuSBwCHTio3SW1KUNFrjnCA8gzF4hDpW7cP55KdM+eA+/aA/MzhrOIYJEzCHXMbFi1YG e21ET4HNGmdTwAYHBJv6EJIPTpl+t5oY17ediEpbumsE18oW8LG7P5b4kMBTKEYAywmU lbUZyASAev83dNzoG+LLYWk2Lbrs6flRSAGjeWOWbgZ6snNYFNw/3f6G576j+B9goW7o 6m2cA5qlMNRtE+r+0hi/LnkSesX9e/N8YchbAbX/e1KFwpzWLHpSQLLvNCE+mOKMVIsC TJjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tLo134QmF2yDpD4yJcUFANSZLY7zpsjP/RmGhsSgIBM=; b=kRnjBmTS3bAt61F54W1ulsumAXXuMedw//gjhyLCtx8y1Ti0NL5YQImOFeIElq0rCM QR563Gb1MY36iX2rE49sKWX7RB62laDWPMH34yQ1BsRxrwBCl9+pXhtPhUsBWE1tbZ4L bMUjtYyH4CEZnod2ChDUp/0uiE79ZhpQMx2vb/Zb0MfyI67jM6JaBMmp60EDGyg3LNdm 2yNgLWe+bYhVZIhjSyt0QyNjcym0y8TFZjvzaJuq8W6wPWV3b+lG/XZuHbaiaRaytR1A DBrCWtljpV75ivusNckrvmjToPZGc8X2AsFba+EqsG2f72qnlvhZNBzb2QX/OOQS2GwK WlXA== X-Gm-Message-State: AE9vXwP9zNm4mrUVAcD9rlkUQ7i175oY93vxU9bPvXuRwUQtxmddb/u7dumTU+Sp6iz8Qcd8p0ThBOx5U0+UHg== X-Received: by 10.36.117.79 with SMTP id y76mr5925450itc.35.1473253226582; Wed, 07 Sep 2016 06:00:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Wed, 7 Sep 2016 06:00:26 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 7 Sep 2016 14:00:26 +0100 Message-ID: Subject: Re: PATCH: Adding more confirmations in query tool (pgAdmin4) To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Hi On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add more confirmations in query tool before taking any actions > which might cause lose changes, > - Clearing editor > - Clearing history > - Load file data > RM#1666 > > Please review. Can you tweak it so that the confirmation is requested as soon as the open file button is clicked, rather than when a file is selected please? I think that's a little more 'normal' :-). Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers