MIME-Version: 1.0
In-Reply-To: 
 <CAFiP3vzLfX+8LYSgCvno3R=3kLkdnU7NR_hgwVC+OsT-i6FSCA@mail.gmail.com>
References: 
 <CAFiP3vxoqJ8Rd2fiXev2di1Se_WuyAZdMtUHcHG3HuHwk-vj0g@mail.gmail.com>
 <CA+OCxozZz4q4Cac8sS2wZ0OprfjOKQRqmSXQjHdd=-sBoVfsbA@mail.gmail.com>
 <CAFiP3vxfQ4=+zjLW9HR_dtYkbgfZLvKLnLZi-A3m4rbFH_A5xA@mail.gmail.com>
 <CAFiP3vznYPXdvmGj2J7i4S7e-BPUVWWUC5KFAK=Q7n6Nee5ThA@mail.gmail.com>
 <CA+OCxoza3djrtauF1VqSvqU1pXBr8gAzHD9xF1T37HbkbgEztA@mail.gmail.com>
 <CAFiP3vyTB+ceHGxwXn_w8RBmDQn9SVC3i+1kXhv=CD8UWr3=Xg@mail.gmail.com>
 <CA+OCxowGax9fd5YmTG3u82Ums0rwkETiXFQPuBokKBx_Br8BOA@mail.gmail.com>
 <CAG7mmozksaXEZv=Sz-f4vkHgDjn-_5LTBzP5=wP-+RNeCMVH3Q@mail.gmail.com>
 <CA+OCxoy=cO2feBinWxO8hMuUN3x9+DFeKkDZ-5hv=2NWfht-dw@mail.gmail.com>
 <CAFiP3vxq4-jHf0GALVH=eaQM5d+rrdu8Z49Q1ksL4ftKUzzVyQ@mail.gmail.com>
 <CA+OCxowSS8R1zh1jajhhN6ibtH4x1+w=xwY5i11_Ub7zCJ9JFQ@mail.gmail.com>
 <CAMjNa7e3vkEsiRGqt6kw3Z+z6v-z6Ox4-F0VmCDJEGW2pynWOg@mail.gmail.com>
 <CA+OCxoxbbVX6HZJVeXxRFhbkiG692RZx9WoWo=jmkv6gc79eRA@mail.gmail.com>
 <5767F4E1.6020308@kingston.net>
 <CA+OCxowW1+ezv93fdbvKtmper+jWOfs+XbgdCSMUJiH23xHQAA@mail.gmail.com>
 <CAFiP3vywwsR96uwDd-KzwF1Vc3DEaBnKWT5v4Sc6y3f-FstCGQ@mail.gmail.com>
 <CA+OCxowF=XkYmrv4uggjW=rWDyS71+ZFhf-sdB-+5beU0_o=jQ@mail.gmail.com>
 <CAFiP3vxp-Y0OYuDMYR7Fbe9g3j5EKSxvSk=iz3MmXeSjsSs+hw@mail.gmail.com>
 <CA+OCxozxp4ssW6=0YcY2dOY_htUsP2dPwi5ZXyONg3+FomScww@mail.gmail.com>
 <CAFiP3vzLfX+8LYSgCvno3R=3kLkdnU7NR_hgwVC+OsT-i6FSCA@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 30 Jun 2016 10:04:55 +0100
Message-ID: 
 <CA+OCxoy20eBO-z9jK9eNJQvoEYOCOQrB4hs-9rgLUc1V=hwN9w@mail.gmail.com>
Subject: Re: Fix for issue RM1336 [pgadmin4]
To: Harshal Dhumal <harshal.dhumal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi Harshal,

On Thu, Jun 30, 2016 at 7:59 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Somehow control key is mapped to Command key in Mac. So on Mac shortcuts are
> Shift+Command+E, Shift+Command+X, Shift+Command+A

OK, those work, but I think we need to take a step back here (partly
because Cmd+Shift+A seems to be Select All in CodeMirror on Mac). I've
committed the patch now, but changed Ctrl+Shift+A to Ctrl+Shift+N.

Can you please work on the following:

1) Create a table of shortcuts from our runtime, our web app, and
CodeMirror. This should list:

Component (e.g. runtime, CodeMirror, Query Tool)
Standard shortcut (e.g. Ctrl+Shift+A)
Mac shortcut (e.g. Cmd+Shift+A)
Function (e.g. Explain Analyze or Select All)

Let's make this as complete and accurate as possible, so it can be
included in the documentation, and used by us to select or
de-duplicate shortcuts.

2) Confirm that the shortcuts we're using in our runtime and web
application don't conflict with any in CodeMirror (or web browsers, in
the case of the web app).

3) Update the web application so the shortcuts are correctly displayed
on Mac automatically - e.g. the tooltips and menus should show
Cmd+Shift not Ctrl+Shift

4) Investigate #1360, and ensure that the CodeMirror shortcuts work
consistently between the runtime and browsers on all platforms.

5) Investigate any remaining shortcuts that don't work as expected.

Thanks, Dave.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers