Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etc2f-0008Dp-51 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:35:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etc2d-00083r-GD for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:35:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etc2d-00083g-9z for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 16:35:47 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etc2Z-0004Ak-VW for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 16:35:46 +0000 Received: by mail-wr0-x242.google.com with SMTP id p104so2793171wrc.12 for ; Wed, 07 Mar 2018 08:35:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=19r0qNM4j3pEfitygCkzJQee8VWCC2FwZKYNapWXwvQ=; b=DmzFqEBtLNkDyMGNDswUStYkN5Sl+1Q7cy/RGe4c5XFD8NC1lH7izXvg4AZXOyJdSh c9G9aGDFlpDVQmgASA6hb/JZn28g/RTJ2MQ856hNTsW5ZwSC3YFcYE/KDWNS+8MO/XzM RQTaARlVsQ0OQkIMc/PdIZgXFN1jt4IAKwF3ZaY5KPXxI4xsq6DfiTkBLbMMaK+51wqH Q8RmagHTWoKzZeysW41EJPWOahVkhOR4M0I5r4NxiFygi3KmOlr4nozx7r3KTSuy4nma J9BHWUPe9QhGoQd/mW3TuTwvPO3I0H5fIujckf4KAlEiUFmFTghRD3Qb39hP+1S/GJC5 PDJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=19r0qNM4j3pEfitygCkzJQee8VWCC2FwZKYNapWXwvQ=; b=iU/WOKXSl+t0GYC+7ojhAnKVVI8M9gOu5Em4rhFo4nHFv6FihPmu/KxRF4cwZqutso gZUsN1b/wZ7W4T0b4n5YR9lHaAPlRkXKengvYhBbfCgq599rX7GwZFwW/HDTzOpqmVky KwqU3XFXh2Rxnl897jQWFvVcoYnOPYKOSNBIN9pYOAUpZ6m/SGxETEVJEhjW6phDJTFD rloOLYOKvV+UboN5BAyF9U0EZdkfUTqvuMRFe+qhx86zbZYktH9MMx4PDcDy6CSJXuif Zz4tdaib4+O4HLn/voTER6/kecRXJCFDVgTY5QxVMVooHSf2wgRD7Coqt+W97vnyh2sk y35A== X-Gm-Message-State: APf1xPA1GNhOoRnjw1kURNE9IBbhF2oVw1mrCn++NBezWWBznOqs57eM RLNPBaytC0WXx93xzbSmJ+3hOCjUs3I0BVM/1iKbZOhe X-Google-Smtp-Source: AG47ELu+zBxK0v17xrL1WzBmTbEBaMQVQr9pZU+ZZrMgIRlyRevZq4DT3vqIH7mHSRzLYzJ1P35FC9ji95lm7NEAaM4= X-Received: by 10.223.184.230 with SMTP id c35mr18484527wrg.190.1520440542467; Wed, 07 Mar 2018 08:35:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Wed, 7 Mar 2018 08:35:41 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Wed, 7 Mar 2018 16:35:41 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045fab6c6faacf0566d526c6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045fab6c6faacf0566d526c6 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Wed, Mar 7, 2018 at 3:17 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Mar 7, 2018 at 7:20 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to disable Gravatar image in Server mode. >>> >>> Requirments & Issues: >>> - For security reasons. >>> - For systems which do not have internet access. >>> - Hangs pgAdmin4 while loading the page if connection has no internet >>> access (as described in the ticket) >>> >> >> If I run with the Gravatar disabled, then I get the following regression >> failure: >> >> ====================================================================== >> FAIL: runTest (pgadmin.browser.tests.test_login.LoginTestCase) >> Valid_Credentials >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_login.py", >> line 93, in runTest >> self.assertTrue(self.respdata in response.data.decode('utf8')) >> AssertionError: False is not true >> >> ---------------------------------------------------------------------- >> >> It's fine when Gravatar is enabled (and the rest of the patch does too). >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045fab6c6faacf0566d526c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Wed, Mar 7, 2018 at 3:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company

<= /div>

On Wed, Mar 7, 2018 at 7:20 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala <murtu= za.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to disable Gravatar i= mage in Server mode.

Requirments & Issues:
- For security reasons.
- For systems which do not have internet ac= cess.
- Hangs pgAdmin4 while loading the page if connection has no int= ernet access (as described in the ticket)

=
If I run with the Gravatar disabled, then I get the following re= gression failure:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
FAIL: runTest (pgadmin.= browser.tests.test_login.LoginTestCase)
Valid_Credentials
----------------------------------------------------------------------
Traceback (most recent call last):
=C2=A0= File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_<= wbr>login.py", line 93, in runTest
=C2=A0 =C2=A0 self.assert= True(self.respdata in response.data.decode('utf8'))
Asser= tionError: False is not true

---------------------= -------------------------------------------------=C2=A0

It's fine when Gravatar is enabled (and the rest of the= patch does too).

--
Dave Page
Blog: http://pgsnake.blogspot= .com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The= Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045fab6c6faacf0566d526c6--