Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etcGf-00011l-Vs for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:50:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etcGe-0007Pl-U8 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:50:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etcGe-0007PQ-Nh for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 16:50:16 +0000 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etcGa-0004VI-3s for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 16:50:16 +0000 Received: by mail-wm0-x22d.google.com with SMTP id z9so5952269wmb.3 for ; Wed, 07 Mar 2018 08:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1P0VjOPe7kUbx0bvXD6C0BUUYo3nF1p4Wy2f9+eyYCM=; b=w3hCgGmh2rQR7AQtjouEqYl14NEu9COxDVzR84P0RsT9XlmcP6gH2Pf9lNQ/kMK8UA /ssZu8/KZ/i7V9yjdvsA3gl9iClygo35rnHSFNety21U2nBhl8F0B4PDKH4rbHONfNUQ ZcfSshJX+DIoB/GgeywnO5IcCMVPnWpJzvtijD6E5937Usf3Rm8zqo3kQZLFr5q6JhzT 1yvs9TtrdPgrKoiwLOqa+KrXJ+J7fhhkZO2leWIbU4szOJ837O1PPAGESBdqdMnbcTyk BffZB60QXw8kydggkyVoMKOmIms18xM/u5CT6bCfxXqhwuk6NtBb5zo5UchxIUIOKvKR yvBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1P0VjOPe7kUbx0bvXD6C0BUUYo3nF1p4Wy2f9+eyYCM=; b=hbx1keJvFHUA3Dq1fMGhiYwkIUuNsOIjWEfhtTSJhFqQRYW/HMVG3v9diNbLKO/R6p 7ZJTcxNzQkczlZhiayss30t6ENOXm27Eg7ttVMIeZf6OEkgCfzGLlgXLdqIXax7wbhjy tqg+gMfb3P4htOOuApdOyPJRkEbYXdMDu256gKaUooS7ObZbgZQMM1qCunDyXdhRCktD VWXVSPU/rwg6FKSrhjGn6Dk0ySaXBXrk5esN2A8HO4zBe+Xl86+X0bXmGHgDgu/ljX+J JotGIviQYKxxlsq/HVBl8tvq6Mmykl2OTJZPOEG7eZv1Gba9L7ecTAFIB0jRPAhxbJ6g vHEg== X-Gm-Message-State: AElRT7EoN2Op5Wgqz1EbXMBUAh97GwP6iCsZN/cC6j3MbGJegaB4WmGN 8T4xSbE51GjtG2olL7Mifn3azLUS/f7oN50yxm3wZvdz X-Google-Smtp-Source: AG47ELtVqkWMF1FUDbAk2YozQnuHe58x1TVZstZjPTGdrU3x5HZJuoE7540RnXFN9KqFJFOUoozqGWMp8Fw/NJLuvfc= X-Received: by 10.28.190.18 with SMTP id o18mr15440201wmf.86.1520441411238; Wed, 07 Mar 2018 08:50:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Wed, 7 Mar 2018 08:50:10 -0800 (PST) In-Reply-To: References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org> From: Dave Page Date: Wed, 7 Mar 2018 16:50:10 +0000 Message-ID: Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507 To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403043c3bf038551b0566d55ad6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403043c3bf038551b0566d55ad6 Content-Type: text/plain; charset="UTF-8" Thanks, applied. Lets see what happens. On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Please find the attached updated patch. > This should work. > > > On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: > >> >> >> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: >>>>> >>>>>> Khushboo, can you look at this ASAP please? It passed tests on my >>>>>> machine, but Jenkins isn't happy. >>>>>> >>>>>> I have tried to reproduce the issue with many combination but >>>>> couldn't reproduce it. >>>>> With the help of logs, I have tried to fix it. Can you please check >>>>> this fix is helpful or not? >>>>> >>>> >>>> On my laptop I now get: >>>> >>>> ====================================================================== >>>> ERROR: runTest (pgadmin.tools.sqleditor.tests >>>> .test_poll_query_tool.TestPollQueryTool) >>>> When query tool polling returns messages with result data-set >>>> ---------------------------------------------------------------------- >>>> Traceback (most recent call last): >>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", >>>> line 104, in runTest >>>> response_data['data']['additional_messages']) >>>> File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", >>>> line 802, in assertIn >>>> if member not in container: >>>> TypeError: argument of type 'NoneType' is not iterable >>>> >>>> ---------------------------------------------------------------------- >>>> >>>> Please provide some more details. Is this failing for particular server >>> version? >>> I am not getting any error with this patch and without this patch on PY2 >>> and PY3 with a single/multiple servers. >>> >> >> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are >> the package versions in the venv: >> >> alabaster==0.7.10 >> alembic==0.9.6 >> args==0.1.0 >> Babel==2.3.4 >> backports.csv==1.0.4 >> beautifulsoup4==4.4.1 >> blinker==1.3 >> chromedriver-installer==0.0.6 >> click==6.6 >> clint==0.5.1 >> dateutils==0.6.6 >> docutils==0.13.1 >> extras==1.0.0 >> fixtures==3.0.0 >> Flask==0.11.1 >> Flask-Babel==0.11.1 >> Flask-Gravatar==0.4.2 >> Flask-HTMLmin==1.2 >> Flask-Login==0.3.2 >> Flask-Mail==0.9.1 >> Flask-Migrate==2.0.3 >> Flask-Paranoid==0.1.0 >> Flask-Principal==0.4.0 >> Flask-Script==2.0.6 >> Flask-Security==1.7.5 >> Flask-SQLAlchemy==2.1 >> Flask-WTF==0.12 >> funcsigs==1.0.2 >> html5lib==1.0b3 >> htmlmin==0.1.11 >> imagesize==0.7.1 >> importlib==1.0.3 >> itsdangerous==0.24 >> Jinja2==2.7.3 >> linecache2==1.0.0 >> Mako==1.0.7 >> MarkupSafe==0.23 >> minify==0.1.4 >> mock==2.0.0 >> passlib==1.6.2 >> pbr==3.1.1 >> pkginfo==1.4.1 >> psycopg2==2.7.3.2 >> pycodestyle==2.3.1 >> pycrypto==2.6.1 >> Pygments==2.2.0 >> pyperclip==1.5.32 >> pyrsistent==0.14.0 >> python-dateutil==2.5.0 >> python-editor==1.0.3 >> python-mimeparse==1.6.0 >> pytz==2014.10 >> requests==2.13.0 >> requests-toolbelt==0.7.1 >> selenium==3.3.3 >> simplejson==3.6.5 >> six==1.11.0 >> snowballstemmer==1.2.1 >> speaklater==1.3 >> Sphinx==1.5.3 >> SQLAlchemy==1.0.14 >> sqlparse==0.1.19 >> testscenarios==0.5.0 >> testtools==2.0.0 >> traceback2==1.4.0 >> unittest2==1.1.0 >> Werkzeug==0.9.6 >> WTForms==2.0.2 >> yuicompressor==2.4.8 >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403043c3bf038551b0566d55ad6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied. Lets see what happens.

On Wed, Mar 7, 2018 at 4:37 PM= , Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Please find = the attached updated patch.
This should work.

On Wed, Mar 7, 2= 018 at 9:46 PM, Dave Page <dpage@pgadmin.org> wrote:

=
On Wed, Mar 7, 2018 at 4:13 PM, Khushb= oo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Wed, Mar 7, 201= 8 at 9:23 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Mar 7, 2018= at 3:10 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Mar 7, 2= 018 at 7:34 PM, Dave Page <dpage@pgadmin.org> wrote:
Khushboo, ca= n you look at this ASAP please? It passed tests on my machine, but Jenkins = isn't happy.

I have tried = to reproduce the issue with many combination but couldn't reproduce it.=
With the help of logs, I have tried to fix it. Can you please ch= eck this fix is helpful or not?=C2=A0
<= div>
On my laptop I now get:

= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin.tools.sqleditor.tests.test_poll_query_t= ool.TestPollQueryTool)
When query tool polling returns= messages with result data-set
---------------------------= -------------------------------------------
Traceback (= most recent call last):
=C2=A0 File "/Users/dpage/git/pgadmi= n4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py"= ;, line 104, in runTest
=C2=A0 =C2=A0 response_data['data'= ;]['additional_messages'])
=C2=A0 File "/System= /Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/u= nittest/case.py", line 802, in assertIn
=C2=A0 =C2=A0 if mem= ber not in container:
TypeError: argument of type 'NoneType&#= 39; is not iterable

------------------------------= ----------------------------------------=C2=A0
<= div>
Please provide so= me more details. Is this failing for particular server version?
I= am not getting any error with this patch and without this patch on PY2 and= PY3 with a single/multiple servers.

Python 2.7.10 on macOS Sierra, testing against Pos= tgreSQL 9.4. Here are the package versions in the venv:

alabaster=3D=3D0.7.10
alembic=3D=3D0.9.6
arg= s=3D=3D0.1.0
Babel=3D=3D2.3.4
backports.csv=3D=3D1.0.4<= /div>
beautifulsoup4=3D=3D4.4.1
blinker=3D=3D1.3
ch= romedriver-installer=3D=3D0.0.6
click=3D=3D6.6
clint=3D= =3D0.5.1
dateutils=3D=3D0.6.6
docutils=3D=3D0.13.1
extras=3D=3D1.0.0
fixtures=3D=3D3.0.0
Flask=3D=3D= 0.11.1
Flask-Babel=3D=3D0.11.1
Flask-Gravatar=3D=3D0.4.= 2
Flask-HTMLmin=3D=3D1.2
Flask-Login=3D=3D0.3.2
Flask-Mail=3D=3D0.9.1
Flask-Migrate=3D=3D2.0.3
Flask= -Paranoid=3D=3D0.1.0
Flask-Principal=3D=3D0.4.0
Flask-S= cript=3D=3D2.0.6
Flask-Security=3D=3D1.7.5
Flask-SQLAlc= hemy=3D=3D2.1
Flask-WTF=3D=3D0.12
funcsigs=3D=3D1.0.2
html5lib=3D=3D1.0b3
htmlmin=3D=3D0.1.11
images= ize=3D=3D0.7.1
importlib=3D=3D1.0.3
itsdangerous=3D=3D0= .24
Jinja2=3D=3D2.7.3
linecache2=3D=3D1.0.0
M= ako=3D=3D1.0.7
MarkupSafe=3D=3D0.23
minify=3D=3D0.1.4
mock=3D=3D2.0.0
passlib=3D=3D1.6.2
pbr=3D=3D3.= 1.1
pkginfo=3D=3D1.4.1
psycopg2=3D=3D2.7.3.2
= pycodestyle=3D=3D2.3.1
pycrypto=3D=3D2.6.1
Pygments=3D= =3D2.2.0
pyperclip=3D=3D1.5.32
pyrsistent=3D=3D0.14.0
python-dateutil=3D=3D2.5.0
python-editor=3D=3D1.0.3
python-mimeparse=3D=3D1.6.0
pytz=3D=3D2014.10
req= uests=3D=3D2.13.0
requests-toolbelt=3D=3D0.7.1
selenium= =3D=3D3.3.3
simplejson=3D=3D3.6.5
six=3D=3D1.11.0
=
snowballstemmer=3D=3D1.2.1
speaklater=3D=3D1.3
Sph= inx=3D=3D1.5.3
SQLAlchemy=3D=3D1.0.14
sqlparse=3D=3D0.1= .19
testscenarios=3D=3D0.5.0
testtools=3D=3D2.0.0
=
traceback2=3D=3D1.4.0
unittest2=3D=3D1.1.0
Werkzeu= g=3D=3D0.9.6
WTForms=3D=3D2.0.2
yuicompressor=3D=3D2.4.= 8

--
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Ent= erprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403043c3bf038551b0566d55ad6--