Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgu0m-0005Vd-B7 for pgadmin-hackers@arkaria.postgresql.org; Fri, 28 Jun 2019 16:46:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hgu0l-0003aN-6F for pgadmin-hackers@arkaria.postgresql.org; Fri, 28 Jun 2019 16:46:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgu0k-0003aG-PN for pgadmin-hackers@lists.postgresql.org; Fri, 28 Jun 2019 16:46:07 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgu0c-0002rK-Pt for pgadmin-hackers@postgresql.org; Fri, 28 Jun 2019 16:46:06 +0000 Received: by mail-wr1-x441.google.com with SMTP id f15so7013056wrp.2 for ; Fri, 28 Jun 2019 09:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5bJvDUAKVjwRWgMFLpeAPQDaq8TadzBkNTpe2WVY8GY=; b=C5JFzq81ERJNTFo/Fyp0yOuY4IxlwQ8Sj5S2KWCDkoBoXEooiWsjYBxtTpg3Apbsao UBt0EXJlzUjUQA0MWZ7wpUUdtgM+IRr9yYer0zFvYjvzHQM0eW0Ea9EqDFSMzLS4V7VY VG0HwoK91d/Ym0Xp5MEhA9P7OckGgyKc/wpdxnjLAEfCyTXoIMIYkx0lJdQsE50kAkqo kG8+XxSImcZWJ2oIgYox0ZOvgu39f0NlPDxjWlIdV3cHAkD2GGYXWvYOWKa3OyqpGguM tVXT51qSMpjwwLiW9wf55tjo3ssWj/n3zTPkNaDK6GnBvne7WH7EgkjzCd5U3Jf/GqGb M8EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5bJvDUAKVjwRWgMFLpeAPQDaq8TadzBkNTpe2WVY8GY=; b=XX6/D1cJ7F2keVZuQf+n99KWH/fA1mhZoGu9Bx9ZcY30XSHW7+vL7MxyCEYQBkGzLb 6yY2TwxEox+nM5L63FqfouCtVPigMgG0U3mt7gnUsuEWlW4Up2V+AdareedSIusKaEvL 5vMxT4GZ7MN1/G/dPts1AneLP9zLhwDt/nbFEYSGQLaOnyGqiB2oEcrhrU4n04Vx88V4 VSE2mgnizehfg0l0Q9MJ+fHYUVggaJcsPbDuQ3q5LsWE6YBMzN2cRecNNbYEG5zvnE0g X+8/jOGL1san+LSz5iz9fpCQXoQZZMFZEittKoAAGyAqxZZr8cHWO6fuMAcSSohoOAjU r0Ug== X-Gm-Message-State: APjAAAVdOBdPzUZdGxzhV2I+DLb9V+AkWYxlGnERLQguCyviwdLWjusI ik6csuY1qJL7s6UQs0SWrxvvibgOEUPow/LKN8jCTg== X-Google-Smtp-Source: APXvYqy2qUBHppjwbTvhlP8Pph97aq4SEwxLWwbdItdR/du9N4u5OJq6qlo/Ua2c2L9uvAIFPT1imwQ9JH3QNZ12YAo= X-Received: by 2002:adf:f984:: with SMTP id f4mr8251974wrr.315.1561740357359; Fri, 28 Jun 2019 09:45:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 28 Jun 2019 12:45:44 -0400 Message-ID: Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000003b7c02058c650338" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000003b7c02058c650338 Content-Type: text/plain; charset="UTF-8" Hi On Fri, Jun 28, 2019 at 9:27 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to fix the review comments of trailing mail. > Kindly review. > So where is the summary supposed to be displayed? It's now requesting it from the server, and it's in the JSON response, but isn't displayed anywhere that I can see. > > On Thu, Jun 27, 2019 at 4:49 PM Dave Page wrote: > >> Hi >> >> On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: >>> >>>> Hi >>>> >>>> Something isn't working correctly - I turned on the summary option, and >>>> this is the query that was run when I hit the EXPLAIN button: >>>> >>>> EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING >>>> False,SUMMARY False,BUFFERS False) select * from pg_tables >>>> >>> >>>> Aside from the formatting (s/True/true, s/False/false, missing spaces >>>> etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle >>>> caches, rebundled etc. >>>> >>> I think I misunderstood the documents - >>> https://www.postgresql.org/docs/12/sql-explain.html. Few of the >>> parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will >>> make the changes, along with formatting to existing codes as well. >>> >> >> I'm not sure that explains why the summary option is set to *false* for >> an EXPLAIN action, but anyway, please make sure it works :-) >> >> >>> >>>> Shouldn't there also be documentation updates? >>>> >>> Yeah. (I always miss that :/) >>> >>>> >>>> On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to add support for SETTINGS(v12+) and >>>>> SUMMARY(v10+) explain options. These options will be visible only if >>>>> version is supported. >>>>> >>>>> I have also created and fixed RM4395. The explain options changed on >>>>> one query tool should not change explain options on other query tools or >>>>> preferences. The initial values will be taken from preferences are usual. >>>>> >>>>> Kindly review. >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000003b7c02058c650338 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Fri, Jun 28, 2019 at 9:27 AM Aditya = Toshniwal <aditya.t= oshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the up= dated patch to fix the review comments of trailing mail.
Kindly review.

So where is the summary supposed to be displayed? It's= now requesting it from the server, and it's in the JSON response, but = isn't displayed anywhere that I can see.
=C2=A0

On Thu, Jun 27, 2019 at 4:49 PM Dave Pa= ge <dpage@pgadmin= .org> wrote:
Hi

On Thu, Jun 27, 2019 at 12:32 AM Ad= itya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

<= div class=3D"gmail_quote">
On Wed, Jun= 26, 2019 at 8:22 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

Som= ething isn't working correctly - I turned on the summary option, and th= is is the query that was run when I hit the EXPLAIN button:

<= /div>
EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMI= NG False,SUMMARY False,BUFFERS False) select * from pg_tables

Aside from the formatting (s/True/true, s= /False/false, missing spaces etc), shouldn't it say SUMMARY true? I'= ;ve cleared the browser and bundle caches, rebundled etc.
I think I misunderstood the documents -=C2=A0https://= www.postgresql.org/docs/12/sql-explain.html. Few of the parameters are appl= icable only to EXPLAIN ANALYSE and not to EXPLAIN. Will make the changes, a= long with formatting to existing codes as well.=C2=A0

I'm not sure that explains why the = summary option is set to *false* for an EXPLAIN action, but anyway, please = make sure it works :-)
=C2=A0

Shouldn't there also be documentation updates?
Yeah. (I always miss that :/)=C2=A0

On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal <aditya.= toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v= 10+) explain options. These options will be visible only if version is supp= orted.

I have also created and fixed RM4395= . The explain options changed on one query tool should not change explain o= ptions on other query tools or preferences. The initial values will be take= n from preferences are usual.

Kindly review= .

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Enterprise= DB India |=C2=A0Pune<= /font>
"Don't Complain about Heat, Plant a TREE"
=


--
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company


--
<= div>
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0<= /span>Pune
"Don't Co= mplain about Heat, Plant a TREE"
<= /div>


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company
=

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000003b7c02058c650338--