Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSOK6-0007J6-IE for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 15:01:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fSOK5-0007dQ-EH for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 15:01:33 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSOK4-0007cv-Sb for pgadmin-hackers@lists.postgresql.org; Mon, 11 Jun 2018 15:01:33 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fSOK1-00044H-4p for pgadmin-hackers@postgresql.org; Mon, 11 Jun 2018 15:01:31 +0000 Received: by mail-wm0-x241.google.com with SMTP id v16-v6so15276448wmh.5 for ; Mon, 11 Jun 2018 08:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JixmEvenIBIflJQH1kj59V6SDoZ1bRizzXzrBIkdKV4=; b=lA0yYOHWFQ8aUkRbBZovLsDmA9EVpPKNX7h6/1oz7HsMkaAuYheSgzWmxpa5p5DiXC kpZaX9nRn1bt/RSSlcBVgWuJmwaLsXzq4WPlpJktG+mAWI9q/KzL7BzbNj83O7y8SV/t c40N1ZQvy37exlJ13giKWCTtRkSIl3ToSPFXH5HtbTg8zYparXYXiyh2XrVB389AEjQg 18s1iBpmGkIZwxWvZhE80EArdb7soYlnbBE48x6rcktq3Lq7eoorSSvYvzmJzGPB9Xie Boa6oX8/OpjeNSji22sKlZyjKrNqT8SXAOnQSlSvGJZDqbHLnsQ8geg/3szkTR/8PxHQ fKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JixmEvenIBIflJQH1kj59V6SDoZ1bRizzXzrBIkdKV4=; b=nJNxZWyQLDM8LLxSnuCnxY0Fbn0uyPkqsKSWMzwTg0AlIcCksqSLh4gTM3afOnbs9Z NMTRLxdTiOWxmblJTztjKqmieHrindnnqU773imYlUrfP4Q5qiDnopGQFPJOucuI0dbZ K2T895BXuOhFzgV+y9RUAncZOpsoefAXL3g3UNYjJh2UEEBEcj6Fid0cIOr52rUaxVSk 358E/D54w0dD4GmCs3YRbHAXW0kAQDea51vzcLCeceKBU8qnL26BWjSAJAJdpE0dQ63V e7jGwGju62P0CHAPwNyJQLRovoPBqb5YTbXJxCB0+N8q5QaV6gABNJKmVvqZf0HCuKde snZg== X-Gm-Message-State: APt69E0Bk5QlxAFr8XHx7PT8p6Y4s2GP8kNKREzOcUa9GdlGHTWkQ97B gm4Q28Il3DMq7zyCN2xPalsg9kKcZ69C0YcZCAFf/A== X-Google-Smtp-Source: ADUXVKJGgSF80Xp/LUX5fdjPVjIsFlP2WISVPbNaKUhk4QFFlGSFjh1yADZncglsvmibTHsd1KWsTqmLC7k56pXwG/c= X-Received: by 2002:a1c:b7d4:: with SMTP id h203-v6mr8135060wmf.161.1528729287623; Mon, 11 Jun 2018 08:01:27 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 08:01:26 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 11 Jun 2018 16:01:26 +0100 Message-ID: Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests To: Joao De Almeida Pereira Cc: pgadmin-hackers , Anthony Emengo Content-Type: multipart/alternative; boundary="000000000000259e84056e5f064e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000259e84056e5f064e Content-Type: text/plain; charset="UTF-8" Hi On Mon, Jun 4, 2018 at 3:26 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Known issues: >>> >>> - Python 2.7, the library we are using for assertions (Grappa) is >>> failing while trying to assert on strings. We created a PR to the library: >>> https://github.com/grappa-py/grappa/pull/43 >>> as soon as this gets >>> in all the tests should pass >>> >>> Any guesses as to the ETA? Given that most of our dev, and our Windows >> and Mac packages both run on 2.7 at the moment, it's clear that this is a >> required fix before we can proceed. >> > > Attached you can find the patch that bumps grappa to version 0.1.9 that > support Python 2.7 > I thought I had replied to this, but apparently not. My apologies... This does seem to fix the issues with Python 2.7. The remaining issues I saw are: - There are a handful of failures with PG 11, however that's not yet supported and Khushboo is working on it. It shouldn't hold up this patch - just mentioning for completeness. - I get the following failure (which is easily fixed in the config file, though that of course, shouldn't be necessary): E AssertionError: Oops! Something went wrong! E E The following assertion was not satisfied E subject "/Library/PostgreSQL/ ..." should be equal to "/Library/PostgreSQL/ ..." E E What we expected E a value that is equal to "/Library/PostgreSQL/ ..." E E What we got instead E an value of type "str" with data "/Library/PostgreSQL/ ..." E E Difference comparison E > - /Library/PostgreSQL/tablespaces/9.4 E > + /Library/PostgreSQL/tablespaces/9.4/ E > ? + E E Where E File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_get.py", line 75, in test_tablespace_get Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000259e84056e5f064e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, Jun 4, 2018 at 3:26 PM, Joao De Almeida Pereira <= jdealmeidapereira@pivotal.io> wrote:
<= p style=3D"margin:0px 0px 1.2em">Known issues:

  • Python 2.7, the library we are using for ass= ertions (Grappa) is failing while trying to assert on strings. We created a= PR to the library: https://github.com/grappa-py/grappa/pull/43 as = soon as this gets in all the tests should pass
<= /blockquote>
Any guesses as to the ETA? Given that most of our dev, and= our Windows and Mac packages both run on 2.7 at the moment, it's clear= that this is a=C2=A0 required fix before we can proceed.

Attached you can find the= patch that bumps grappa to version 0.1.9 that support Python 2.7=C2=A0
=

I thought I had replied = to this, but apparently not. My apologies...

This = does seem to fix the issues with Python 2.7. The remaining issues I saw are= :

- There are a handful of failures with PG 11, ho= wever that's not yet supported and Khushboo is working on it. It should= n't hold up this patch - just mentioning for completeness.
<= br>- I get the following failure (which is easily fixed in the config file,= though that of course, shouldn't be necessary):

E =C2=A0 = AssertionError: Oops! Something went wrong!

E=C2=A0 = =C2=A0

E =C2=A0 =C2=A0 The following assertion was no= t satisfied

E =C2=A0 = =C2=A0 =C2=A0 subject "/Library/PostgreSQL/ ..." should be= equal to "/Library/PostgreSQL/ ..."

E=C2=A0 = =C2=A0

E =C2=A0 =C2=A0 What we expected

E =C2=A0 = =C2=A0 =C2=A0 a value that is equal to "/Library/PostgreSQL/ ..= ."

E=C2=A0 = =C2=A0

E =C2=A0 =C2=A0 What we got instead

E =C2=A0 = =C2=A0 =C2=A0 an value of type "str" with data "/Libr= ary/PostgreSQL/ ..."

E=C2=A0 = =C2=A0

E =C2=A0 =C2=A0 Difference comparison

E =C2=A0 = =C2=A0 =C2=A0 > - /Library/PostgreSQL/tablespaces/9.4

E =C2=A0 = =C2=A0 =C2=A0 > + /Library/PostgreSQL/tablespaces/9.4/

E =C2=A0 = =C2=A0 =C2=A0 > ?=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 +

E=C2=A0 = =C2=A0

E =C2=A0 = =C2=A0 Where

E =C2=A0 = =C2=A0 =C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/brows= er/server_groups/servers/tablespaces/tests/test_tbspc_get.py", line 75= , in test_tablespace_get


Thanks.

--
= Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB = UK: http://www.en= terprisedb.com
The Enterprise PostgreSQL Company
--000000000000259e84056e5f064e--