Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZfNtv-0004fa-3D for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Sep 2015 07:58:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZfNtu-0003Qh-Jw for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Sep 2015 07:58:38 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZfNtg-0002v8-8I for pgadmin-hackers@postgresql.org; Fri, 25 Sep 2015 07:58:24 +0000 Received: from mail-io0-f173.google.com ([209.85.223.173]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZfNtd-0001g4-DH for pgadmin-hackers@postgresql.org; Fri, 25 Sep 2015 07:58:23 +0000 Received: by ioiz6 with SMTP id z6so102491192ioi.2 for ; Fri, 25 Sep 2015 00:58:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=rGSx059i6uIO4dGv0hXJ4yALtpikvJaSeYe4NhAG8qE=; b=RFzOCBhn8IYnOFOJgQBe13aNk3656D9KNNqruteGXRGLw+6cKWwU5xAFgn94r7eT0t O5Xs5N5G0fx1dHiy8Xxnbzs3tQJlTGyt65FYUkLIVy5aIgLRw8MfskQDU+zrSi1YY8Mm GrLztP/HapdugUOn45GU7DDeSHzBR8RbvUZnjwOY7j3w5T5/WqsnvjhEp403CG5VLj5T QDz2UtgmU+ZFrVBqTSNGTWxdTthyyuP+2NJSTQy2+++8pX2MtjOmYdgI6Jnwli6rK3TU cpVzXAVgld3ovJtQleqvu2iVkIgljWm8eF6RuHVmdByiEpmoCrl504+m465jmxk+fvJ1 tzlg== X-Gm-Message-State: ALoCoQkK1UFhJkgcC7FliHyWTAwNbs/ARbDIZyGA9iFEk+4KQA8vZK33dPQVTlAmWdMUk0s0zGI4 MIME-Version: 1.0 X-Received: by 10.107.15.69 with SMTP id x66mr4824425ioi.156.1443167900043; Fri, 25 Sep 2015 00:58:20 -0700 (PDT) Received: by 10.64.110.37 with HTTP; Fri, 25 Sep 2015 00:58:19 -0700 (PDT) In-Reply-To: References: Date: Fri, 25 Sep 2015 08:58:19 +0100 Message-ID: Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2 From: Dave Page To: John Obaterspok Cc: Sanket Mehta , Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113ed8e208c7f305208db66d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113ed8e208c7f305208db66d Content-Type: text/plain; charset=UTF-8 Ashesh, are you able to deal with this before Monday (when I'll be cutting the feature-frozen beta 1 tarballs)? On Fri, Sep 25, 2015 at 7:03 AM, John Obaterspok wrote: > Thanks, appreciated. > > Can it be committed then? :) > > 2015-09-23 9:49 GMT+02:00 Sanket Mehta : > >> Hi John/Ashesh, >> >> I have reviewed the patch and it seems fine to me. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Wed, Sep 23, 2015 at 11:08 AM, John Obaterspok < >> john.obaterspok@gmail.com> wrote: >> >>> Hi Sanket, >>> >>> Did you give the patch a try? I would really like it to for the next >>> release :) >>> >>> -- john >>> >>> 2015-09-16 20:27 GMT+02:00 John Obaterspok : >>> >>>> Hi Sanket, >>>> >>>> Attached patch is rebased now. >>>> >>>> Regards, >>>> >>>> -- john >>>> >>>> >>>> 2015-09-16 11:20 GMT+02:00 Sanket Mehta >>>> : >>>> >>>>> Hi John, >>>>> >>>>> Patch is not proper. >>>>> I got below error when I try to apply the patch: >>>>> >>>>> error: patch failed: pgadmin/frm/frmQuery.cpp:2435 >>>>> error: pgadmin/frm/frmQuery.cpp: patch does not apply >>>>> >>>>> Please do provide the proper patch. >>>>> >>>>> >>>>> Regards, >>>>> Sanket Mehta >>>>> Sr Software engineer >>>>> Enterprisedb >>>>> >>>>> On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta < >>>>> sanket.mehta@enterprisedb.com> wrote: >>>>> >>>>>> Sure Ashesh, >>>>>> >>>>>> I will review the patch. >>>>>> >>>>>> Regards, >>>>>> Sanket Mehta >>>>>> Sr Software engineer >>>>>> Enterprisedb >>>>>> >>>>>> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi < >>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Sanket, >>>>>>> >>>>>>> Can you please take a look at it? >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> Ashesh Vashi >>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> >>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>> >>>>>>> >>>>>>> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok < >>>>>>> john.obaterspok@gmail.com> wrote: >>>>>>> >>>>>>>> Hello, >>>>>>>> >>>>>>>> I'm updated the patch to add commit/rollback actions in the toolbar >>>>>>>> with the following: >>>>>>>> 1) updated icons (based on existing pgadmin icon with arrows drawn >>>>>>>> by me) >>>>>>>> 2) add entry to menu as well >>>>>>>> 3) disable icons when not in a transaction >>>>>>>> 4) Ctrl+Shift C|R shortcut >>>>>>>> >>>>>>>> Hopefully all issues are resolved now! >>>>>>>> >>>>>>>> Regards, >>>>>>>> >>>>>>>> John >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>> To make changes to your subscription: >>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113ed8e208c7f305208db66d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ashesh, are you able to deal with this before Monday (when= I'll be cutting the feature-frozen beta 1 tarballs)?

On Fri, Sep 25, 2015 at 7:0= 3 AM, John Obaterspok <john.obaterspok@gmail.com> wr= ote:
Thanks, appreciated= .=C2=A0

Can it be committed then? :)

2015-09-23 9:49 GMT+02:00 Sanket Mehta &= lt;sanke= t.mehta@enterprisedb.com>:
=
Hi John/Ashesh,

I have reviewed the pat= ch and it seems fine to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Wed, Sep 23, 2015 at 11:= 08 AM, John Obaterspok <john.obaterspok@gmail.com> w= rote:
Hi Sanket,
Did you give the patch a try? I would really like it to for the= next release :)

-- = john

2015-09-16 20:27 GMT+02:00 John Obaterspok <john.obaterspok@gmail.com>:
Hi Sanket,

Attached patch is rebased = now.

Regards,

-- john
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0

2015-09-16 11:20 GMT+02= :00 Sanket Mehta <sanket.mehta@enterprisedb.com>= :
Hi John= ,

Patch is not proper.
I got below error when I try t= o apply the patch:

error: patch failed: pgadmin/frm/frmQuery.cpp:243= 5
error: pgadmin/frm/frmQuery.cpp: patch does not apply

Ple= ase do provide the proper patch.
=C2=A0

Regards,
Sanket = Mehta
Sr Software engineer
Enterprisedb

On Mon, Sep 14, 2015 at 10:= 51 AM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Sure Ashesh,<= div>
I will review the patch.

Regards,
Sanket Meh= ta
Sr Software engineer
Enterprisedb
<= /div>

On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Sanket,

Can y= ou please take a look at it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Sep 14, 2015 at 1:07 AM, J= ohn Obaterspok <john.obaterspok@gmail.com> wrote:
Hell= o,

I'm updated the patch to add commit/rollback acti= ons in the toolbar with the following:
1) updated icons (based on exist= ing pgadmin icon with arrows drawn by me)
2) add entry to menu as= well
3) disable icons when not in a transaction
4)= Ctrl+Shift C|R shortcut

Hopefully all issues are = resolved now!

Regards,

= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 John



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=











--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter= : @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company
--001a113ed8e208c7f305208db66d--