Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYuCU-0003N4-Jr for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 14:16:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fYuCS-0006h7-Gy for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 14:16:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYuCS-0006h0-3j for pgadmin-hackers@lists.postgresql.org; Fri, 29 Jun 2018 14:16:36 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fYuCP-0006Nt-1M for pgadmin-hackers@postgresql.org; Fri, 29 Jun 2018 14:16:34 +0000 Received: by mail-wm0-x244.google.com with SMTP id w16-v6so1725865wmc.2 for ; Fri, 29 Jun 2018 07:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0QNgw4Mpx/k59n1g8IKC+CptHbbo7mjvIZ6jqBmcuBA=; b=BmPO8HD1RtYD1r/b+e3Kovt5unJBOQHfZYHwPszI+eH5fbW5BlF9zmWqTm9zqe29o3 RYHXdZ3PTa9UrTTEGiPMwDg9V4PR9drV7hgEUwEoOW3rnYneAjORpUNycGf7QXCovddF P+jDHhRo8XToQ6BEudd2FFcJpoHMViVFvtlFYnyvR0gSlJGwhca+QVkUZEtrRcIiXu3I jX/9TP0ewgMTNMcw+mwe3KZk8vJWBbPq/lt40VCV7A7K8WcejsydKfUVVUg79MsnLroU ZTgZ6oFSPmtV81djHp1GPB0I93H9nw1x+HMLabmv6UYv+HCJxD3HC+WENmh6Ib4rDQ5U WGDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0QNgw4Mpx/k59n1g8IKC+CptHbbo7mjvIZ6jqBmcuBA=; b=peib9PNomAJwuU8sZEum69U4jM2TDT2I7DYaK6Iq8q4EgG4l6B6IC9lfGbO5mjPFmY kKinKakwXpTwQZz0AZgvrsT4ek1kX9GKoXOj7cCTTHu/LXzle10PTiyZNLzImY2x9MnE zFSM6hUCduS7ACBV5t7wm5gP92kg/pVxquQ2BX7ayCrmHXn/gp45Hjv6CJQpgr632pS3 8kJyW/2nKU4zvJcMTtAtvEVe8ODvgSY1J7awgrlLHw23QYH+CgPB5d8jpziGFiEBnFRZ cJn/+HcQUvNUUpx4nb/I7lTC/htODUArwi3s8bbLwMxkO+XAqQZBeLr+vZJchcw1Oa1b CdVA== X-Gm-Message-State: APt69E3sl/1KLZRsEK6x6WCLdgXXvs7OsJuAKtRhXb0Ew4YSMzn6ISgE IhUYdxQiyDpTgTvaqt9aRDQqd/W2EGmzpN8TW8Mvi2Kp X-Google-Smtp-Source: AAOMgpfY5l8Y1eSKjfxPJ/Uk+JwNt+i+CxFsgHVucRNoWOV3ZUhraJdDMdYD1FU/nCaCNBfe9Vg86D0PSB6cNjn2BkM= X-Received: by 2002:a1c:94f:: with SMTP id 76-v6mr1959070wmj.86.1530281791349; Fri, 29 Jun 2018 07:16:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Fri, 29 Jun 2018 07:16:30 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 29 Jun 2018 15:16:30 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000947d97056fc87e89" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000947d97056fc87e89 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Fri, Jun 29, 2018 at 10:24 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Mon, Jun 25, 2018 at 8:07 PM, Dave Page wrote: > >> >> >> On Mon, Jun 25, 2018 at 3:33 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, 25 Jun 2018, 19:47 Dave Page, wrote: >>> >>>> Hi >>>> >>>> On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch for RM #3309 - Backup does not work >>>>> with --format=d. >>>>> >>>>> Fixes in the patch : >>>>> >>>>> 1. Format = directory fix for Backup and Restore utilities >>>>> 2. Test cases for format = directory >>>>> 2. File manager fix - The selected directory was not properly >>>>> populated in the text box >>>>> >>>> >>>> The patch disables the file picker button if you select Directory >>>> format. This seems like poor behaviour; I think we need to modify the >>>> dialogue to allow a directory to be selected. >>>> >>>> >>> In the directory format, which ever the folder name given, that will be >>> created by pg_dump, so I have disabled it. >>> >> >> Sure, but I can't even browse to the location I want to put it now - I >> have to manually type in the path. We just need to allow selection of the >> directory that will contain the directory. >> >> > Fixed. > >> 3. Refactoring of File manager JS file >>>>> >>>> >>>> That's somewhat more readable. Can we add tests? >>>> >>> Will look into it. >>> >> >> Added. > >> Thanks. >> >> >>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000947d97056fc87e89 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Fri, Jun 29, 2018 at 10:24 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please fin= d the attached updated patch.

Thanks,
Kh= ushboo

On Mon, Jun 25, 2018 at 8:07 PM, Dave Page &l= t;dpage@pgadmin.org<= /a>> wrote:

On Mon, J= un 25, 2018 at 3:33 PM, Khushboo Vashi <khushboo.vashi@enter= prisedb.com> wrote:

=C2=A0
3. Refactoring of File manager JS= file

That's somewhat more = readable. Can we add tests?=C2=A0
Will look into it.

Added.=C2=A0




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--000000000000947d97056fc87e89--