public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Subject: Re: Lack of activity indicator over slow connections (pgadmin4)
Date: Mon, 26 Sep 2016 15:11:22 +0100
Message-ID: <CA+OCxoy7E31MDLAzcoGBewOyvYim0Pvy7WDJaBsD_GFHtNeRMg@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D_R5a0mA-W9YsTf1ezCUi8CWJvDkcvemih7f80CGshyWw@mail.gmail.com>
References: <CABUevEx++DjkspfVGNkP4tyPNO1stR-Xp=GitREWXNHxKcoLyw@mail.gmail.com>
<CA+OCxow5nvt8yBjx_Oh-6Upa3O4HrR5t14Y7OTiQ1quXxUfscw@mail.gmail.com>
<CABUevEz0KfNQ6Y_gh-MRWkOEWaHxGrr-oFvpKOvLE+=M8fCxEw@mail.gmail.com>
<CA+OCxozh3e4AGxd2GkLav9qLG=i2U4YG4FoCMe0fN+edYWhgow@mail.gmail.com>
<CAM5-9D8GARXHAryQDHLKgBzCgN0+beSVwFPn3Gb3MCQZ=nr7ow@mail.gmail.com>
<CA+OCxoyhJBwRfEE4sW30XoSvwRs2aG+dw5JsWaHiYFPWk0S_qw@mail.gmail.com>
<CAM5-9D9tXi7D9xwOVRdZoJ0QnjxpKhA8csm2GLZ1H4SuZkKRGw@mail.gmail.com>
<CA+OCxoxp8Y0j_cYR3h2er2az+H4Yjy8Bsp1SP8ELDZNPRMLMHQ@mail.gmail.com>
<CAM5-9D83rt3+yCyj3d_99GPBFtQX7WpBUb4eo7EXBzVBujER1w@mail.gmail.com>
<CAM5-9D_R5a0mA-W9YsTf1ezCUi8CWJvDkcvemih7f80CGshyWw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks, applied with some changes to wording, and reduction of the
delay from 2 secs to 1.
On Mon, Sep 26, 2016 at 2:41 PM, Surinder Kumar
<[email protected]> wrote:
> Please find attached patch. Added activity indicator for:
> 1) Panels.
> 2) Dialog open and on click OK.(set cursor to progress)
> 3) Debugger. (Set cursor to progress).
>
> Not done: Activity indicator is not implemented for wizard pages. send
> another patch once completed.
>
> On Fri, Sep 23, 2016 at 2:19 PM, Surinder Kumar
> <[email protected]> wrote:
>>
>> On Fri, Sep 23, 2016 at 1:45 PM, Dave Page <[email protected]> wrote:
>>>
>>> On Fri, Sep 23, 2016 at 7:32 AM, Surinder Kumar
>>> <[email protected]> wrote:
>>> >
>>> >
>>> > On Wed, Sep 21, 2016 at 8:40 PM, Dave Page <[email protected]> wrote:
>>> >>
>>> >> Hi
>>> >>
>>> >> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar
>>> >> <[email protected]> wrote:
>>> >> > Hi Dave/Ashesh
>>> >> >
>>> >> > The thing we can do is:
>>> >> > 1) We can display loading message same as other panels if returned
>>> >> > response
>>> >> > is taking longer than 2 seconds, otherwise we won't display any
>>> >> > message(to
>>> >> > avoid fluctuations).
>>> >> > Screenshot - demo_message.png
>>> >>
>>> >> There's a typo there (laoded)..
>>> >>
>>> >> > 2) Display a loading spinner along with panel title while data is
>>> >> > being
>>> >> > loaded.
>>> >> > Screenshot - spinner.png
>>> >>
>>> >> I don't see a spinner there at all.
>>> >
>>> > sorry its not spinner, its reload spinning icon in place of properties
>>> > icon.
>>>
>>> Oh, I see. I like it, but wonder if it would be too subtle.
>>>
>>> Can we do both? Show the panel, and spin a loading icon on the tab?
>>
>> I will try to implement both.
>>>
>>>
>>> >>
>>> >>
>>> >> What about the other places I mentioned?
>>> >
>>> >
>>> >>
>>> >> - On dialogue open and OK
>>> >
>>> > D
>>> > isplay loading message
>>> > in dialog till the data loads and on OK we can set mouse pointer to
>>> > 'progress' till the data is not processed.
>>>
>>> Yes, they are essentially panels too, so we can do the same as for
>>> Properties and Statistics etc.
>>>
>>> > - On Wizard steps
>>> > D
>>> > isplay loading message
>>> > also in wizard pages till it doesn't loads data.
>>>
>>> Yes.
>>>
>>> >
>>> > - Possibly in the debugger, when stepping?
>>> >
>>> > In case of debugger's step into, step out & resume, we can set mouse
>>> > pointer
>>> > to 'progress'
>>>
>>> OK.
>>>
>>> Can you work up a patch ASAP please?
>>
>> Ok.
>>>
>>>
>>> Thanks!
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (11+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Lack of activity indicator over slow connections (pgadmin4)
In-Reply-To: <CA+OCxoy7E31MDLAzcoGBewOyvYim0Pvy7WDJaBsD_GFHtNeRMg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox