Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hazoK-0001tY-G2 for pgadmin-hackers@arkaria.postgresql.org; Wed, 12 Jun 2019 09:44:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hazoJ-0000qC-AW for pgadmin-hackers@arkaria.postgresql.org; Wed, 12 Jun 2019 09:44:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hazoI-0000q5-VB for pgadmin-hackers@lists.postgresql.org; Wed, 12 Jun 2019 09:44:51 +0000 Received: from mail-it1-x141.google.com ([2607:f8b0:4864:20::141]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hazoF-0002GI-8k for pgadmin-hackers@postgresql.org; Wed, 12 Jun 2019 09:44:50 +0000 Received: by mail-it1-x141.google.com with SMTP id m138so9716194ita.4 for ; Wed, 12 Jun 2019 02:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=46sDHvAE0E/Q1acrU8nbCwr/Dj+rufvjUtvltmiog8U=; b=kVyhvFwaM/NeXs9FBnIquEfFtEDezEtAQImxQBlSRREOmhQQHAn88a2nveYHxuiHYF LIVEJfH3YptXbfG7iFSm4YZFDuV/fEVHhBvhw6Q3kIOXWa43q3D0iSPJsJ/MkV56s0q6 bM+SpiL+NCAHn52ScEImvYfrU6TEPq4PlC3iG8GJfss4lHb+B/juHlXOWnGuGUoZ14Oc cjIDOQCFPeREQICCAKR7oeA/qwqShnTOJG2+T37wgs3hGPYt545IIIk/E8e3l6StcRgh fzzTQebc+fNlcGZPJb5v25tC1fruLu40SfAL7UqR4/LtoMeIEKQP/YzDE338d5TVBhzH W5FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=46sDHvAE0E/Q1acrU8nbCwr/Dj+rufvjUtvltmiog8U=; b=DoIeYziJf46P+2is55nOIGWnfsoa/uEnS8rEjPkzA4SiZhtYa7mSqbVKVTQ3wTbNDK Ziqsjfy3VsgeeH4b1cxVr9PhcQoqoQZLBR6G2N4G2A5gKzg02xMXJS98WnwzZrH9921g /72jYo/EAnX9x88Er6rwLAmDN1AY25tGFDJ/aG3xTEfpOqT4hhdVYSYFFt3k9PssJ23P UkC0eYXZU5ASCK+DcUlEeRHZLhP2UHiLe3+dguuxIMmB9wxsnFw9Ho/kBsfmhdk4KmJ6 H5RyRrOTI1opzeF6PJJq1D66oMyIkU0VIgtGs+xi5+/P0JcjV0YjiVzj59SuaH5FCS9x tTfA== X-Gm-Message-State: APjAAAU5KN5YpWydPX+jJaRTHKfHnlGK5bJz2gwsR4vP8gJ/FTpds0cr 5O7OLlG0kS9xFSOxvDnAkgxn27R7Rmy8DzgxKrnHkA== X-Google-Smtp-Source: APXvYqyfEDt4UfOFvzY8YXiPV59f/PfGJuxjcbEksqFhxf9kcU2QXlLSWcQyEN+LuUbWhQQ2bBIR+QfzLpULYng+RcM= X-Received: by 2002:a24:fcc4:: with SMTP id b187mr20392437ith.179.1560332685191; Wed, 12 Jun 2019 02:44:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 12 Jun 2019 10:44:32 +0100 Message-ID: Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and object details To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000006ec415058b1d43b6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006ec415058b1d43b6 Content-Type: text/plain; charset="UTF-8" Hi On Wed, Jun 12, 2019 at 10:02 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 12, 2019 at 1:54 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to add more information on connection details to >>> debugger panel title and content title similar to Query Tool and View/Edit >>> data. >>> Adding the object name with arguments is not a good idea for the panel >>> title, so I have kept to connection details similar to query tool. The >>> content title will have all the details. >>> >>> Kindly review. >>> >> >> I think not having the function name in there is a big limitation. >> >> With all this hacking going on, I think what we need to do is stop and >> make this configurable as has been both requested by users and suggested by >> us. >> >> I propose adding 2 preference options for each tab type. Each of these >> would be a string with placeholders, one for the tab title, and one for the >> tab tooltip. For example: >> >> - Query Tool >> * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST% >> * Tab title default: %DATABASE% on %SERVER% >> * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@%SERVER% >> >> - View Data >> * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, >> %PORT%, %HOST% >> * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER% >> * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE% in %DATABASE% >> on %USERNAME%@%SERVER% >> >> - Script >> * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%, >> %USERNAME%, %PORT%, %HOST% >> * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on >> %SERVER% >> * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT% >> in %DATABASE% on %USERNAME%@%SERVER% >> >> - Debugger >> * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%, >> %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST% >> * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on >> %SERVER% >> * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_ARGS% >> in %DATABASE% on %USERNAME%@%SERVER% >> >> Or something like that. Thoughts? >> > Yes, this could be a nice feature. I think tooltip title customisation is > not needed, we can just set it as prefix + tab title. > I think having it be separate is useful - you can include full information there, but keep the tab minimal so as not to create huge tabs. For example, the debugger tab could just be set to %FUNCTION_NOARGS%, whilst the tooltip has the full string. > Some users asked for in-place rename of tab title. I'm not sure if it is > feasible to implement, but should we consider it also ? > No - I've only seen one request for that, and it seems like a lot of work for little gain. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000006ec415058b1d43b6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, Jun 12, 2019 at 10:02 AM Aditya Toshniwal &= lt;aditya.toshniwal@en= terprisedb.com> wrote:
Hi,

On Wed, Jun 12, 2019 at 1:54 PM Dave Page <= ;dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal <= adit= ya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is th= e patch to add more information on connection details to debugger panel tit= le and content title similar to Query Tool and View/Edit data.
Adding the object name with argument= s is not a good=C2=A0idea for the panel title, so I have kept to connection= details similar to query tool. The content title will have all the details= .

Ki= ndly review.

I thin= k not having the function name in there is a big limitation.

=
With all this hacking going on, I think what we need to do is st= op and make this configurable as has been both requested by users and sugge= sted by us.

I propose adding 2 preference options = for each tab type. Each of these would be a string with placeholders, one f= or the tab title, and one for the tab tooltip. For example:

<= /div>
- Query Tool
=C2=A0 * Placeholders: %DATABASE%, %SERVER= %, %USERNAME%, %PORT%, %HOST%
=C2=A0 * Tab title default: %DATABA= SE% on %SERVER%
=C2=A0 * Tooltip title default: Query Tool: %DATA= BASE% on %USERNAME%@%SERVER%

- View Data
=C2=A0 * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USER= NAME%, %PORT%, %HOST%
=C2=A0 * Tab title default: %SCHEMA%.%TABLE= % in %DATABASE% on %SERVER%
=C2=A0 * Tooltip title default: View/= Edit Data: %SCHEMA%.%TABLE% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%
=

- Script
=C2=A0 * Placeholders: %A= CTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST= %
=C2=A0 * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATA= BASE% on %SERVER%
=C2=A0 * Tooltip title default: %ACTION% Script= : %SCHEMA%.%OBJECT% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%

- Debugger
=C2=A0 * Placeholders: %FUNCTIO= N_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PO= RT%, %HOST%
=C2=A0 * Tab title default: %FUNCTION_NOARGS%.%OBJECT= % in %DATABASE% on %SERVER%
=C2=A0 * Tooltip title default: Debug= ger: %SCHEMA%.%FUNCTION_ARGS% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%

Or something like that. Thoughts?
Yes, this could be a nice feature. I think tooltip title custom= isation is not needed, we can just set it as=C2=A0 prefix=C2=A0+ tab title.=

I think having i= t be separate is useful - you can include full information there, but keep = the tab minimal so as not to create huge tabs. For example, the debugger ta= b could just be set to %FUNCTION_NOARGS%, whilst the tooltip has the full s= tring.
=C2=A0
Some users asked for in-pl= ace rename of tab title. I'm not sure if it is feasible to implement, b= ut should we consider it also ?
<= br>
No - I've only seen one request for that, and it seems li= ke a lot of work for little gain.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
T= witter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise P= ostgreSQL Company
--0000000000006ec415058b1d43b6--