MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZSrYHCypG0rfsD9DHCoE8-c+XAvBnU3vS8LMDfPqSrC1Q@mail.gmail.com>
References: 
 <CAKKotZSrYHCypG0rfsD9DHCoE8-c+XAvBnU3vS8LMDfPqSrC1Q@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 9 Mar 2018 15:55:01 +0000
Message-ID: 
 <CA+OCxoy7R6TU5Z3+b-D6Oz80yBafYVMe-6AtJ3QXoK6HC3jFXw@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#3140] Add service parameter
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="f403045ce2eaac56950566fcd0e7"
Precedence: bulk

--f403045ce2eaac56950566fcd0e7
Content-Type: text/plain; charset="UTF-8"

HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to add service parameter in server dialog.
> - Docs updated
> - Test case added for Service ID parameter
>
> Please note,
> I have extracted Connection class and Server manager class from our own
> custom Psycopg2 driver module.
>
> Patch also covers RM#3120
>

 This patch seems a little confused. The "Service" and "Service ID" fields
from pgAdmin 3 are very different things. The Redmine ticket seems to be
asking for the Service field (the pg_service.conf service name), *not*
Service ID (the operating system's service ID, used to start/stop the
database server service).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--f403045ce2eaac56950566fcd0e7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">HI<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <span dir=3D"ltr">=
&lt;<a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank"=
>murtuza.zabuawala@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex"><div dir=3D"ltr"><div style=3D"font-family:verdana,sans-se=
rif;color:rgb(68,68,68)">Hi,</div><div style=3D"font-family:verdana,sans-se=
rif;color:rgb(68,68,68)"><br></div><div style=3D"font-family:verdana,sans-s=
erif;color:rgb(68,68,68)">PFA patch to add=C2=A0service parameter in server=
 dialog.</div><div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,=
68)">- Docs updated</div><div style=3D"font-family:verdana,sans-serif;color=
:rgb(68,68,68)">- Test case added for Service ID parameter</div><div style=
=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)"><br></div><div styl=
e=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">Please note,</div>=
<div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">I have ex=
tracted Connection class and Server manager class from our own custom Psyco=
pg2 driver module.</div><div style=3D"font-family:verdana,sans-serif;color:=
rgb(68,68,68)"><br></div><div style=3D"font-family:verdana,sans-serif;color=
:rgb(68,68,68)">Patch also covers RM#3120</div></div></blockquote><div><br>=
</div><div>=C2=A0This patch seems a little confused. The &quot;Service&quot=
; and &quot;Service ID&quot; fields from pgAdmin 3 are very different thing=
s. The Redmine ticket seems to be asking for the Service field (the pg_serv=
ice.conf service name), *not* Service ID (the operating system&#39;s servic=
e ID, used to start/stop the database server service).</div></div><div><br>=
</div>-- <br><div class=3D"gmail_signature" data-smartmail=3D"gmail_signatu=
re">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_b=
lank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>Enterpris=
eDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://ww=
w.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--f403045ce2eaac56950566fcd0e7--