Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bv82R-0000Vj-KE for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Oct 2016 19:21:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bv82R-0001mf-7B for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Oct 2016 19:21:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bv82D-0001SQ-A5 for pgadmin-hackers@postgresql.org; Fri, 14 Oct 2016 19:20:49 +0000 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bv82A-0004xD-7m for pgadmin-hackers@postgresql.org; Fri, 14 Oct 2016 19:20:48 +0000 Received: by mail-it0-x22f.google.com with SMTP id m138so19818316itm.0 for ; Fri, 14 Oct 2016 12:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DSzFrmcpoTDG+Jy+QAvMuZZtEbSJCChIJGQkxEekjAQ=; b=l0YZhJ1xm4lGZnuk5JAELC5wwM7bbbnbHj2BGUPFi2D2S+UY82JlQKG/wHVU3vSXmk KHk/cVYneBEhpUoQYrOztwtEGKG9vv8QlO7llX9WjRv09xPulsKp1w4JEDmz7fTyFMrb rKkjXArglCfAWhyxNEw6gbMg/3zJrdy4q3XGc69FyE8mY7BVcwYjFW5Vva52WzlhUqlv oBHGoy8pqq5+Geu8CtZPaoVD6QuekwVuaVX9irkKl61NphItZgtuJwOk9NM/nULXVj2m oVeAurDKxCb71a6NB90WBAmiWD4oGfDy4M4YDJ6wS+eujeWmYMWhRzuW7pEKN4ejEIjB c6UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DSzFrmcpoTDG+Jy+QAvMuZZtEbSJCChIJGQkxEekjAQ=; b=fgSoAMYj/KjvpZkdNTsU7FK5s1LYByZiwyKLiyuFxd89NwYjyN0alq8kG3RLAbRx7Q 8KUAIDINwHUF659QgKm/d1GyLWnGb7KIH0K0fIT4QPv9rdNn5ePH0E/C/M9P2JYamP3p apcKDY79iFl/kH/6Q77tFHgBAmeA6vKl7qM65WQoGIAsj/rJCIXINVThr34f4c75O0Q8 TFXu/gmZuVXpoCk7uucu07rIXQvcJxQfcLD7a/6FRf6o/iLvNmDroK4NeurzSt7+lV7y 5UMPnVwDt932rpscHrZPcrmfqIue2o5VFyX5pHOPi4umzEBMusKrIpzFZjF1T3VlSJoq QKhg== X-Gm-Message-State: AA6/9RlNFPfyEXmN8GYiSXBKJA15e60dxbF38GdwaUywpbqDL662Qjeva5SykpQaUzRwOM7R9tMS96E99EP3zQ== X-Received: by 10.36.202.131 with SMTP id k125mr3528019itg.100.1476472844043; Fri, 14 Oct 2016 12:20:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.146.135 with HTTP; Fri, 14 Oct 2016 12:20:43 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 14 Oct 2016 20:20:43 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix] To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c089e5c63d0ef053ed81f3f X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c089e5c63d0ef053ed81f3f Content-Type: text/plain; charset=UTF-8 Thanks, applied. On Friday, October 14, 2016, Surinder Kumar wrote: > Hi > > While clicking on Select2 control, it tries to destroy the control and > thus it doesn't get this object sometimes and throws error. > > It should attempt to destroy the select2 object only if this object is not > undefined. > Adds proper check to handle the case. > > Please find minor patch and review. > > Thanks > Surinder Kumar > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c089e5c63d0ef053ed81f3f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks, applied.

On Friday, October 14, 2016, Surinder Kumar <surinder.kumar@enterprisedb= .com> wrote:
Hi

While clicking on Select2 control, it tries to= destroy the control and thus it doesn't get this object sometimes and = throws error.
<= br>
It should a= ttempt to destroy the select2 object only if this object is not undefined.<= /div>
Adds proper che= ck to handle the case.

Pl= ease find minor patch and review.

Thanks
Surinder Kumar


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company

--94eb2c089e5c63d0ef053ed81f3f--