Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bX6iO-0001zl-QU for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:05:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bX6iO-0005TC-C5 for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:05:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bX6iB-0005En-3h for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:04:51 +0000 Received: from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bX6i7-0003QY-Ma for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:04:49 +0000 Received: by mail-it0-x230.google.com with SMTP id x130so13310415ite.1 for ; Tue, 09 Aug 2016 06:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=J6Quf3MrtOXTWsKvl05CJyfQCcTf6NV6aEQ2ra5WCvw=; b=lAyc6YRxDjbYYbdA8D+FSJ/nThGhhKyd6EdzZWpe37ZwfHuAyuNZIi78kFxR6KCuwb Gy67N3gc7A8c7SH/Tzd0trlXmaPuzhM7/Xy//a15mhAALihZhwG+kh/k/Jza++5Y4v7R DASty1tapYWgqvKQtkWEkArXlWPlcbl56+K5UQczmdLv8JcIg37h+ShegEYvaA1Hw43P 5pTocnEPEd2+uxrt92HTExl4F6ogJKpWi0GY49H4I0prPIVGxUoy7Js2gV8c1QOz9IaU SmUBSKUT4yD4mqTXvBs0aG2RfoUHfFwuRORgDgvvZc/KSPr0uhvXuLqAkoE0coGIFyZi CeFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=J6Quf3MrtOXTWsKvl05CJyfQCcTf6NV6aEQ2ra5WCvw=; b=NMY086XOc7WQToen5qGzEGgQcx82H/O0v0e0oHfRCUAmi42e6oSiSRWZFVKwQltvyi 0+a/BBc6WDWXIBo6w9AeG4auGH/hZGO4np8Flem8f0tv421Zn14sokF6jdviYAifXM3F 4kfawqjbifWxDD3eMOaxcTQCgPDf9x0remClUKaZP9KbaDAG3WaWrxiges1P3CTzg/lQ Blg3e3VHYmgtqV4a2hzitHksGG5eK9jYZTZlKFQtzsAB8BZakuURO8eCcKKkOfMirrmG LV86lBKLHq4MnNsRy50l5t7HLno3bW2ZqFFPRP8ZPfjGkigVcyzYA/Hg8s4ZfrONl05w EvlQ== X-Gm-Message-State: AEkoouv+Riv2yNSldiZ2BaglIc81kAafyjwwW5S/U4fMnKwCmQw2kVM0T+2/PkbbdOTltrTjKqdE4uUgxq17TQ== X-Received: by 10.36.2.18 with SMTP id 18mr23237991itu.35.1470747886294; Tue, 09 Aug 2016 06:04:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Tue, 9 Aug 2016 06:04:45 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 9 Aug 2016 14:04:45 +0100 Message-ID: Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4) To: Ashesh Vashi Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1144b808514de00539a32dc4 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1144b808514de00539a32dc4 Content-Type: text/plain; charset=UTF-8 On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi wrote: > On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: > >> Hi >> >> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala >> wrote: >> > Hi, >> > >> > PFA patch to fix the issue where message panel was showing incomplete >> info. >> > We may still miss some messages from Psycopg2 driver due to limited >> size of >> > notices queue. >> > (RM#1523) >> >> A few thoughts on this (mostly based on my discussions with Ashesh): >> >> 1) You seem to have removed the poll delay. I assume that is to try to >> avoid missing messages? Can we re-introduce the delay (to avoid >> excessive network requests), but collect messages while we're waiting? >> > Using thread? > Start a thread during the timeout? > Not necessarily. If we want a 2 second polling delay, we could just sleep for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages, return to client. > >> 2) If I run VACUUM, whilst I see messages as I should now, there is no >> query time summary as there is for a query that returns data. >> > >> 3) Can we incrementally display messages? e.g. each time we poll, we >> add the new messages to the messages div, and scroll to the end >> automatically? > > Yeah - that's a good idea. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > >> > > > > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1144b808514de00539a32dc4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <ashesh.vashi= @enterprisedb.com> wrote:
<= div dir=3D"ltr">

On Tue, Aug 9, 2016 at 6:28 PM, Dave Page <d= page@pgadmin.org> wrote:

Hi

On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where message panel was showing incomplete = info.
> We may still miss some messages from Psycopg2 driver due to limited si= ze of
> notices queue.
> (RM#1523)

A few thoughts on this (mostly based on my discussions with Ashesh):=

1) You seem to have removed the poll delay. I assume that is to try to
avoid missing messages? Can we re-introduce the delay (to avoid
excessive network requests), but collect messages while we're waiting?<= br>
Using thread?
Start a thread during t= he timeout?

Not nec= essarily. If we want a 2 second polling delay, we could just sleep for 0.5 = secs, collect messages, sleep for 0.5 sec, collect messages, <repeat...&= gt; return to client.
=C2=A0
=

2) If I run VACUUM, whilst I see messages as I should now, there is no
query time summary as there is for a query that returns data.

3) Can we incrementally display messages? e.g. each time we poll, we
add the new messages to the messages div, and scroll to the end
automatically?
Yeah - that's a good idea.
=

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL C= ompany


=C2=A0
=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


 --
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1144b808514de00539a32dc4--