Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdESt-0005I5-HN for pgadmin-hackers@arkaria.postgresql.org; Tue, 18 Jun 2019 13:48:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hdESs-00075r-7G for pgadmin-hackers@arkaria.postgresql.org; Tue, 18 Jun 2019 13:47:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdESr-00075c-Ot for pgadmin-hackers@lists.postgresql.org; Tue, 18 Jun 2019 13:47:58 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdESo-0000O7-UJ for pgadmin-hackers@postgresql.org; Tue, 18 Jun 2019 13:47:57 +0000 Received: by mail-wm1-x344.google.com with SMTP id f17so3351533wme.2 for ; Tue, 18 Jun 2019 06:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dPP2i2Hc4KoYbT6PyL6eeoFcpTAWLQ1Zmc9f/U5ALWM=; b=aOiyc7/7JwcoLdCNOnW6Dr66BrkH5x89Y7gfKOj5nZkVKkmN0LEOA4IZ+9N9PCIxdd laJiFwM8WiIsQLvrRnF7qx9zbmINugO3bV9S4vkoMAuWp/OsEFOyS7JUir2hk12Bi5Gv rzi54R+xFCTGDCDmuiiF4+aTBfUUzrslprUsz+ZxqDy7VJl8FS0XZapOb5EOPwPCygE5 8aP3ZHztKuqNyIAr00Ltrk5UFk/6CcZkBhANnBJzYyyoJNytoKV1YVLX2GcD6KM9pQzn +L6EztG+ay1Mrp0np5+hdc7lSWCfRN/Hq3UCEaw9IALMYVBgPoO8g1jHoskFOXKs+2u/ vNPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dPP2i2Hc4KoYbT6PyL6eeoFcpTAWLQ1Zmc9f/U5ALWM=; b=NHz88aJ5XtAVaRBKDsoSCIBYSuoiv20dOBPuIAyib5kxZ8jTb4MX4B51jc0zDczlFG jatPI+qFKaCwD0bZvGmCFp15UsQ5zbhFoQE+AROgglXCtAUvxobo9dcYY7vEvDeBluRA qlsTrtd+jwGtv9CTLs4gJNa+m/2P+On6ol7wbr6hjCSwjc+evNQBSRJQCTwwErDAJ/WY q+skaoweOPAoGXnhhMbjNm/zU3PVX+MBnsKaV5/ciO24RoULoVtG8c7HPnQL+I4wridq Moqtmq8Y3soN6e2/MBJs9BjKDvYi2HAeqrSydX+vzIFhM+L7qt65LxL5bn4poeaVg9sw VHmA== X-Gm-Message-State: APjAAAXmmHiO23eV7bEkuU4YDbi68qtNDBaZFKFGBFE2P4DnupJSCxeX qClOxVS/N5k3ZFP1Mm2DPjt5+8jh63FaDjFz3NbvEg== X-Google-Smtp-Source: APXvYqxaSIclPcjtMNLBLv6H98DEvmrBm8o6eql3oDs4Sq13tegf8htpar5M2CLvdq3E/xWTqjyFoErI8adeEhqhk4M= X-Received: by 2002:a7b:cc16:: with SMTP id f22mr4056144wmh.115.1560865673422; Tue, 18 Jun 2019 06:47:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 18 Jun 2019 14:47:38 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 4360 Debugger buttons should be disabled until it is completely started To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000001c5b8058b995c53" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000001c5b8058b995c53 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Jun 18, 2019 at 9:52 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #4360 Debugger buttons should be disabled > until it is completely started. Patch contains following fix apart from the > actual RM: > > - Fixed issue when restart the execution of debugger, it is a > regression of #4329 > - Fixed issue while change in preference dialog for debugger but that > will not reflect real time. > > > Please review it. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000001c5b8058b995c53 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Jun 18, 2019 at 9:52 AM Aksh= ay Joshi <akshay.joshi@= enterprisedb.com> wrote:
Hi Hackers,

Attached is= the patch to fix=C2=A0RM #4360 Debugger buttons should be disabled until i= t is completely started. Patch contains following fix apart from the actual= RM:
  • Fixed issue when restart the execution of debugger, = it is a regression of #4329
  • Fixed issue while change in prefere= nce dialog for debugger but that will not reflect real time.

Please review it.

-- <= br>
= Akshay Joshi
Sr. Software Architect
EnterpriseDB Software Ind= ia Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--00000000000001c5b8058b995c53--