public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Priyanka Shendge <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Kanchan Mohitey <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Subject: Re: pgAdmin IV API test cases patch
Date: Wed, 15 Jun 2016 09:40:05 +0100
Message-ID: <CA+OCxoy=yRwZNScnjzrP03BfD=9ay-8BFV0afW8ursMQ5LYmAg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyqfK8pUGGmeO=5pyC=MOizNMOnfshAfgQ5NjMRnkjgmA@mail.gmail.com>
References: <CAKmZXFQ2Hj1-OZpSGFEBB-vOypQ_=1b4Yr_VytZ-E1=CBw9Yhw@mail.gmail.com>
	<CA+OCxow8Q83e7Tm+BC2bxq=oqwd-m4JS3y2KpzgFemc=wX=f=A@mail.gmail.com>
	<CAKmZXFTX9D_qOXGrvPa9sfFjc1A6VPebcpBn7vyzPEOH4pWfEg@mail.gmail.com>
	<CAKmZXFRj8yY91TTxwQQ01eOQE8Rc7FPWuxGcjxaVY+QcWpgWDg@mail.gmail.com>
	<CA+OCxoyqfK8pUGGmeO=5pyC=MOizNMOnfshAfgQ5NjMRnkjgmA@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Ashesh - can you also look at the patch please (feel free to wait for
the update). I want more eyes on this.

Thanks.

On Wed, Jun 15, 2016 at 9:39 AM, Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge
> <[email protected]> wrote:
>> Hi Dave,
>>
>> PFA updated patch. I have made changes suggested by you.
>>
>> Kindly, review and let me know for more changes.
>
> OK, I got a bit further this time, but not there yet.
>
> 1) The patch overwrote my test_config.json file. That should never
> happen (that file shouldn't be in the source tree).
> test_config.json.in should be the file that's included in the patch.
>
> 2) The updated test_config.json file is huge. I should only need to
> define one or more connections, then be able to run the tests. If you
> need to keep configuration info for "advanced users", let's put it in
> a different file to avoid confusing/scaring everyone else. Maybe split
> it into config.json for the stuff the user needs to edit
> (config.json.in would go in git), and test_config.json for the test
> configuration.
>
> 3) It fails on my machine, for what looks like a coding error
> initially, then a lot of issues where it can't find parent_id.pkl.
> I've attached the log.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (27+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin IV API test cases patch
  In-Reply-To: <CA+OCxoy=yRwZNScnjzrP03BfD=9ay-8BFV0afW8ursMQ5LYmAg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox