Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmj9G-0003rc-Ie for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Sep 2016 15:09:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bmj9G-00039t-5T for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Sep 2016 15:09:22 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bmj92-0002up-Br for pgadmin-hackers@postgresql.org; Wed, 21 Sep 2016 15:09:08 +0000 Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bmj8y-00034U-LW for pgadmin-hackers@postgresql.org; Wed, 21 Sep 2016 15:09:07 +0000 Received: by mail-io0-x231.google.com with SMTP id r145so55810461ior.0 for ; Wed, 21 Sep 2016 08:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SQbJVzCPpru6083o+wydXKUr/kgI30uk3vw+hlBZqiA=; b=RJ5Tlo3QSr3Mm14B2VJMe5xRs6I5MnaAZq1YS9f54rDlOesHqCHKu01ZirXZ4a7TZj Ms72Bw2W5EFGFAlioxHuvQyDo0iw6+4Z36xsjxnmi9qmYlawnau/DqGHWgkxcIZ2tWpH T28zNk5FrJolyQkicB0DRnSa3tEOWt/Zaj3mB+jtYaYvo282WYgWytq5HXAk4E4w6dWg iMMwwckQ9DYU1dl4Qk9rWlo7hnu0qtzWX1ui6XAOufaNAuFBELErh1KTl0ccSnbaUoNl PVHR0UJMEIqD3ov9hbutwY8WVEPU9mV33tr5//DFMsyLmj4A7wj9My+sCVIhVqLz8ml2 fncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SQbJVzCPpru6083o+wydXKUr/kgI30uk3vw+hlBZqiA=; b=a5pFPvZewYAC3lhug4BNFA/5OZ7iv6XeISMFVOAWYOwM3vjnx9gdYk8Op6xJP6c1Hw 5XN8k/wV1IXCdq+2PEvKea44vWnCNl2qA6uJRk8x29Bye9qUbNBSl+rbX+ecxXfi6v7e BMzlyec3dvRTrZheS2X8OOTvaJz4Id+Rl5ZtzSzg5ra4av63OdXjO7sweyPtr+uucYAU mEXE8wHWDGTc/dP4JQF1WWPUcTg+rBlpmV8PVfvl3yF1IlUO543T+bMXUTaL0G8fQCVK DfoxCxDEB65iZseP7cD/hg8ANV4l4AJLEMZmT/vEPLJaA07GH+ESv6vwbjBEfit9wwc2 F78A== X-Gm-Message-State: AE9vXwMH29xk9EF3JljxNKNNIZ4Re4YiEWz7D3jdJDcl5yki/U6Ai238gVzsPmWrTCSihw+Bgq3m5so7I8WeQA== X-Received: by 10.107.53.206 with SMTP id k75mr49991093ioo.195.1474470543544; Wed, 21 Sep 2016 08:09:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Wed, 21 Sep 2016 08:09:02 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 21 Sep 2016 16:09:02 +0100 Message-ID: Subject: Re: Patch for RM1720 [pgadmin4] To: Navnath Gadakh Cc: Harshal Dhumal , pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org On Wed, Sep 21, 2016 at 4:02 PM, Navnath Gadakh wrote: > Hi Dave, > Can you please run testsuite for server or database node only, as > there are some code modifications are remaining on the rest of the nodes. > Currently i don't have a machine to look into issue, will check it tomorrow. OK, here's the result: (pgadmin4)piranha:web dpage$ python regression/runtests.py --pkg browser.server_groups.servers.databases pgAdmin 4 - Application Initialisation ====================================== The configuration database - '/Users/dpage/.pgadmin/test_pgadmin4.db' does not exist. Entering initial setup mode... NOTE: Configuring authentication for SERVER mode. The configuration database has been created at /Users/dpage/.pgadmin/test_pgadmin4.db =============Running the test cases for 'Regression - PG 9.4'============= runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase) This function will add database under 1st server of tree node. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ... ok ---------------------------------------------------------------------- Ran 4 tests in 1.310s OK =============Running the test cases for 'Regression - PG 9.5'============= runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase) This function will add database under 1st server of tree node. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ... FAIL runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ... ERROR runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ... ERROR ====================================================================== ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_get.py", line 33, in runTest self.db_id) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database follow_redirects=True) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post return self.open(*args, **kw) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open follow_redirects=follow_redirects) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open response = self.run_wsgi_app(environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app rv = run_wsgi_app(self.application, environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app app_rv = app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request return method(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect conn = manager.connection(did=did, auto_reconnect=True) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1448, in connection "Couldn't find the specified database." Exception: Couldn't find the specified database. ====================================================================== ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_put.py", line 37, in runTest db_id) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database follow_redirects=True) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post return self.open(*args, **kw) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open follow_redirects=follow_redirects) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open response = self.run_wsgi_app(environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app rv = run_wsgi_app(self.application, environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app app_rv = app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request return method(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect conn = manager.connection(did=did, auto_reconnect=True) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1448, in connection "Couldn't find the specified database." Exception: Couldn't find the specified database. ====================================================================== FAIL: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_delete.py", line 38, in runTest self.assertEquals(response.status_code, 200) AssertionError: 410 != 200 ---------------------------------------------------------------------- Ran 4 tests in 1.019s FAILED (failures=1, errors=2) =============Running the test cases for 'Regression - EPAS 9.5'============= runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase) This function will add database under 1st server of tree node. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ... FAIL runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ... ERROR runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ... ERROR ====================================================================== ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_get.py", line 33, in runTest self.db_id) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database follow_redirects=True) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post return self.open(*args, **kw) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open follow_redirects=follow_redirects) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open response = self.run_wsgi_app(environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app rv = run_wsgi_app(self.application, environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app app_rv = app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request return method(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect conn = manager.connection(did=did, auto_reconnect=True) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1448, in connection "Couldn't find the specified database." Exception: Couldn't find the specified database. ====================================================================== ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_put.py", line 37, in runTest db_id) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database follow_redirects=True) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post return self.open(*args, **kw) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open follow_redirects=follow_redirects) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open response = self.run_wsgi_app(environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app rv = run_wsgi_app(self.application, environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app app_rv = app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request return method(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect conn = manager.connection(did=did, auto_reconnect=True) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1448, in connection "Couldn't find the specified database." Exception: Couldn't find the specified database. ====================================================================== FAIL: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_delete.py", line 38, in runTest self.assertEquals(response.status_code, 200) AssertionError: 410 != 200 ---------------------------------------------------------------------- Ran 4 tests in 1.807s FAILED (failures=1, errors=2) Test Result Summary ============================ Regression - EPAS 9.5: 1 test passed, 3 tests failed : DatabaseDeleteTestCase DatabasesGetTestCase DatabasesUpdateTestCase Regression - PG 9.5: 1 test passed, 3 tests failed : DatabaseDeleteTestCase DatabasesGetTestCase DatabasesUpdateTestCase Regression - PG 9.4: 4 tests passed, 0 tests failed ============================ -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers