Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwRiE-0006j6-7q for pgadmin-hackers@arkaria.postgresql.org; Tue, 18 Oct 2016 10:33:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bwRiD-0004ao-R7 for pgadmin-hackers@arkaria.postgresql.org; Tue, 18 Oct 2016 10:33:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bwRiD-0004ai-6M for pgadmin-hackers@postgresql.org; Tue, 18 Oct 2016 10:33:37 +0000 Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bwRiA-0004Gj-91 for pgadmin-hackers@postgresql.org; Tue, 18 Oct 2016 10:33:36 +0000 Received: by mail-it0-x22b.google.com with SMTP id m138so75802317itm.0 for ; Tue, 18 Oct 2016 03:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=m25d3ed48GprS53YNv3hfg9ZxA+58+6AVYfaTYjlpyA=; b=E+QDgensZF9msXbrn4ZgsCI/NgZS5uKIQSOijP+GZzf9qQ74u6XIF4VRk94qWJOLYK RSB286eam9bJj35u704ix7baBQPZ0DQRCuQqYM7AkZd+DzylztO08ZFJmyZBwwT6RUmn 5ncFMWWv17IGmCgLWtgkrHNsRA5w69BwbkLyQ6XdoOQmWQkqQggXkeWzNNr0tsUdSfo6 kQycQZoSu68DndHunlYrF9lCov1LYa7UXhH0CPzYVBxXF7WlaTAoHY3pZNcUYGd5nI4O iRok9mupZX6KeWGmxkzs9T81wWFFfRUkgkaq0GBlPIUKMYRMdQH5/8kYCrk4ehdKNC5v gRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=m25d3ed48GprS53YNv3hfg9ZxA+58+6AVYfaTYjlpyA=; b=m3dTZiiRjD7qMMRx2jFJ7GQsdoUFSK8rgBvwC5DEQI/5jPWsiAeqByocgdW8JilYDc vB7TT0YG3pqwaa528qgY8gGd30hb8xj4zgcEa0wD6wY6m5UJZ6URHjfR0l6uNhYSVP31 7l+XYQh/h/qn1vxFKESyHEdd5KiZH7hdRp9a6GI5rDj2PO1uwPvOzthPsq7b7YrpeeGA JkSGskGzbNMGs257l/FI6LrdDgdkOj6uJ3fe9MCSB8ClLk9KHHbVXruxJQOw3Teiphla 3N4s80ZJ1KevKIf2EU4A4Fz2KwDx3yet64tMb2uOGGlN4Hh4GHGqvjk1ASe8opEp9F9/ lmPQ== X-Gm-Message-State: AA6/9RkFesiCRpzZ+uE5gkRgfT9GK+FEmS8XjFuPrR/lxuFLHEJjZOiXNJZq6wZ5wMTlBjLSPmjRML0zQAa5aw== X-Received: by 10.36.149.193 with SMTP id m184mr12637837itd.94.1476786813583; Tue, 18 Oct 2016 03:33:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.146.135 with HTTP; Tue, 18 Oct 2016 03:33:32 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 18 Oct 2016 11:33:32 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks - applied! On Mon, Oct 17, 2016 at 7:48 AM, Surinder Kumar wrote: > On Sun, Oct 16, 2016 at 7:29 AM, Dave Page wrote: >> >> Hi >> >> I just found a case where this patch is broken - if you update the comment >> on a type, it looks like it tried to lookup the schema ID using the type >> name, which a) isn't in the posted data so gives a 500 response, and b) >> wouldn't be safe anyway, if there were types with the same name in multiple >> schemas. > > I have fixed this issue. Now it will lookup the schema ID against the type > id instead of type name. >> >> >> Actually, it looks like that's an issue when creating a type too - that is >> also using an unsafe schema lookup. >> >> Please fix this ASAP (i.e. Monday) and double check to ensure we're not >> doing any more unsafe lookups like this. > > It looks good to me in other nodes. > Please find attached patch and review. >> >> >> Thanks. >> >> >> On Friday, October 14, 2016, Dave Page wrote: >>> >>> Thanks, applied. >>> >>> On Friday, October 14, 2016, Surinder Kumar >>> wrote: >>>> >>>> Hi >>>> >>>> Following are the issues fixed in nodes: >>>> >>>> 1) If we create/update a node with non-default schema, It should return >>>> selected schema id in return response. but default schema id is returned >>>> every time due to which it throws error in properties panel. >>>> Fixed in Domains, Collation, Types, Views & Table node. >>>> >>>> 2) Incorrect parent id of object node is returned from nodes method due >>>> to which wrong parent id is passed while updating object and >>>> thus node didn't get refreshed. >>>> Fixed in FTS Configuration, FTS Parser nodes. >>>> >>>> Also, I have kept changes of first patch which are essential to refresh >>>> node every time. Without that patch nodes properties panel updates only >>>> sometimes. >>>> >>>> Please find attached patch. Please review and let me know for comments. >>>> >>>> Thanks >>>> Surinder Kumar >>>> >>>> >>>> >>>> On Fri, Sep 23, 2016 at 6:00 PM, Dave Page wrote: >>>>> >>>>> Umm, no it wasn't - sorry. >>>>> >>>>> I see the same issue with Types. Can you fix that, and check all other >>>>> nodes as well please? >>>>> >>>>> Thanks. >>>>> >>>>> On Fri, Sep 23, 2016 at 1:29 PM, Dave Page wrote: >>>>> > Thanks, applied. >>>>> > >>>>> > On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar >>>>> > wrote: >>>>> >> Hi, >>>>> >> >>>>> >> Please find updated patch with changes: >>>>> >> 1) On debugging through JS files, the issue was in synonym update >>>>> >> method >>>>> >> which wasn't returning node object. >>>>> >> 2) retrieving schema name in node.sql for creating node object in >>>>> >> update >>>>> >> method. >>>>> >> >>>>> >> Please review and let me know for comments. >>>>> >> >>>>> >> On Fri, Sep 23, 2016 at 2:44 PM, Dave Page >>>>> >> wrote: >>>>> >>> >>>>> >>> Hi >>>>> >>> >>>>> >>> On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar >>>>> >>> wrote: >>>>> >>> > Hi >>>>> >>> > >>>>> >>> > Issue: >>>>> >>> > on updating node, we deselect and then again select the node >>>>> >>> > updated to >>>>> >>> > refresh the panel. but it needs some delay of few milliseconds >>>>> >>> > between >>>>> >>> > deselect and select to fix this issue. >>>>> >>> > >>>>> >>> > Please find attached patch and review. >>>>> >>> >>>>> >>> This does not resolve the issue for me. I tested using a synonym to >>>>> >>> a >>>>> >>> package on EPAS 9.5, by changing the target package name. >>>>> >>> >>>>> >>> >>>>> >>> -- >>>>> >>> Dave Page >>>>> >>> Blog: http://pgsnake.blogspot.com >>>>> >>> Twitter: @pgsnake >>>>> >>> >>>>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> >>> The Enterprise PostgreSQL Company >>>>> >> >>>>> >> >>>>> > >>>>> > >>>>> > >>>>> > -- >>>>> > Dave Page >>>>> > Blog: http://pgsnake.blogspot.com >>>>> > Twitter: @pgsnake >>>>> > >>>>> > EnterpriseDB UK: http://www.enterprisedb.com >>>>> > The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers