MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELcKP1eRWNwtT3=UVoKPiwR2Pt6LhS+=C0D8vCs1AiK3GQ@mail.gmail.com>
References: 
 <CAFOhELcKP1eRWNwtT3=UVoKPiwR2Pt6LhS+=C0D8vCs1AiK3GQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 25 Jun 2018 15:17:40 +0100
Message-ID: 
 <CA+OCxoyCFZgqa5qKxatwVp9kQ8PO7_EXTWZTZgtNKDwRv=cTyg@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with
 --format=d
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000668a3a056f780b66"
Precedence: bulk

--000000000000668a3a056f780b66
Content-Type: text/plain; charset="UTF-8"

Hi

On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for RM #3309 - Backup does not work with
> --format=d.
>
> Fixes in the patch :
>
> 1. Format = directory fix for Backup and Restore utilities
> 2. Test cases for format = directory
> 2. File manager fix - The selected directory was not properly populated in
> the text box
>

The patch disables the file picker button if you select Directory format.
This seems like poor behaviour; I think we need to modify the dialogue to
allow a directory to be selected.


> 3. Refactoring of File manager JS file
>

That's somewhat more readable. Can we add tests?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000668a3a056f780b66
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi <span dir=3D"ltr">&lt=
;<a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khush=
boo.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please find the attached pa=
tch for RM #3309 - Backup does not work with --format=3Dd.</div><div><br></=
div><div>Fixes in the patch :</div><div><br></div><div>1. Format =3D direct=
ory fix for Backup and Restore utilities</div><div>2. Test cases for format=
 =3D directory</div><div>2. File manager fix - The selected directory was n=
ot properly populated in the text box</div></div></blockquote><div><br></di=
v><div>The patch disables the file picker button if you select Directory fo=
rmat. This seems like poor behaviour; I think we need to modify the dialogu=
e to allow a directory to be selected.</div><div>=C2=A0</div><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex"><div dir=3D"ltr"><div>3. Refactoring of File manager JS fi=
le</div></div></blockquote><div><br></div><div>That&#39;s somewhat more rea=
dable. Can we add tests?=C2=A0</div></div><div><br></div>-- <br><div class=
=3D"gmail_signature" data-smartmail=3D"gmail_signature">Dave Page<br>Blog: =
<a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.bl=
ogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http=
://www.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><=
br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--000000000000668a3a056f780b66--