Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiHoL-0004DW-9G for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 12:23:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiHoJ-0002mr-36 for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 12:22:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiHoI-0002mk-R5 for pgadmin-hackers@lists.postgresql.org; Tue, 02 Jul 2019 12:22:58 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiHoF-0003r1-V2 for pgadmin-hackers@postgresql.org; Tue, 02 Jul 2019 12:22:58 +0000 Received: by mail-wm1-x341.google.com with SMTP id f17so790064wme.2 for ; Tue, 02 Jul 2019 05:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aNjO88dz31vrZQH4Et3O3ulwWgjlM9AxSpX52thtxL8=; b=A9cfH2gW+MAdu9lQUdeN9pDpU9LSszRIixI8PLgfNjEXa42Unv5q3U+YBgNslMAISL 1H+gdxR12vLllj1Kk+02GcP5dTTvSkCXXB/BxDy1cIXKadK7bvADYWKVGkzDK2ETdCHN 75R26BkY4XsF4aiJ/E89av8EC4JplzWdUBRiYzlJAOcbmxccYnOnxBN92O4FAJtUwslC WDY8HRQ0WFkfPKCYq2tDRR9ceFXGa6lOVxYjHRFe9m/bh9ii7DiH/t69jKh+ndTdwMg3 TtJkW+da0+5UqYBQLRD5YiKKwEaPR2QM7v9OPjzpEUCiGJHpIPMymIg9v5GXGtG24m+O asMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aNjO88dz31vrZQH4Et3O3ulwWgjlM9AxSpX52thtxL8=; b=f+OOicuLjoNRR33yJAlQAkB0uunDq2eB+d0OXYzlxt8X/ibJg1ucRO1Zc5GHwhxKYZ SAPkS6JXhHvjRMnaf+fUCAzTw8zjvoWTt+lTllZ7tL2iRH6c7lTdECuUHOulZ+KALecx Kj/RSLqgcyJxuUUeUX99pUYBkDlE7N/WNrIKZ57GwNbV+G2qM3PlvdXXPz1xET2AhIbk YVgIpmy0gUOhYsoqEyVLAF6Y5PnyXzTVKSN8d4A/BjddGTJY2hysLejMuNQKvUMEQcsE 1fmRRqV7GxFwJThxcZ5KkyVyrTw8lt4/DxdbQNGeKJv9XOPgH7nkTmkPCHUeAxGBORVv rGbg== X-Gm-Message-State: APjAAAWrAQYH3XKVRgRZkIMAN3Rd3T+bmDjlVYoo773V1Olbk5w3C2dQ xsqDarLww5LTG6PfhLM6WTt07P6WhUV7ACx/An/Q0A== X-Google-Smtp-Source: APXvYqxWPQvPukZxSq4PQ7fa4GL3LzN5gpP3cv5ysM+8nqmcyLtGXVdsxUA6Jc/ji4KgvcuP/uiigNOjQ19Lv+FtYz4= X-Received: by 2002:a7b:cc16:: with SMTP id f22mr3599914wmh.115.1562070174681; Tue, 02 Jul 2019 05:22:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 2 Jul 2019 13:22:42 +0100 Message-ID: Subject: Re: RE-SQL tests for Roles & Resource Group nodes To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e07653058cb1cdcd" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e07653058cb1cdcd Content-Type: text/plain; charset="UTF-8" Hi On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > ++ Attaching patch > > On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the updated patch, >> >> - Added a mechanism to check for supported minimum/maximum version and a >> server type in the framework. >> > There's still a problem with this I'm afraid - it says in the summary that the re_sql test cases were all skipped, which is not the case. I think we should just skip the irrelevant tests in the re_sql module, but not mark the entire module as being skipped: =============Running the test cases for 'Regression - PG 11'============= runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases) Reverse Engineered SQL Test Cases Create IMPLICIT Cast Alter IMPLICIT Cast Drop IMPLICIT Cast Create EXPLICIT Cast Alter EXPLICIT Cast Drop EXPLICIT Cast ... skipped 'Server(Type: #ppas) is not supported for the Resource Groups module' ---------------------------------------------------------------------- Ran 1 test in 0.480s OK (skipped=1) ====================================================================== Test Result Summary ====================================================================== Regression - PG 11: 0 tests passed 0 tests failed 1 test skipped: ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases) ====================================================================== -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000e07653058cb1cdcd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala &l= t;murtuza.zabuawala@e= nterprisedb.com> wrote:
++ Attaching patch
<= br>
On Tue,= Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.= com> wrote:
Hi Dave,

Please find the updated patch,
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">
=
- Added a= mechanism to check for supported minimum/maximum version and a server type= in the framework.
<= div>
There's still a problem with this I'm afraid - i= t says in the summary that the re_sql test cases were all skipped, which is= not the case. I think we should just skip the irrelevant tests in the re_s= ql module, but not mark the entire module as being skipped:

<= /div>

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test cases for &#= 39;Regression - PG 11'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTest= Cases)

Reverse Engineered SQL Test Cases


Create IMPLICIT Cast

Alter IMPLICIT Cast

Drop IMPLICIT Cast

Create EXPLICIT Cast

Alter EXPLICIT Cast

Drop EXPLICIT Cast

=C2=A0... skipped= 'Server(Type: #ppas) is not supported for the Resource Groups module&#= 39;


--------------------------------------------------------------------= --

Ran 1 test in 0.480s


OK (skipped=3D1)


=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Test Result Summary

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D


Regression - PG 11:


0 tests passed

0 tests failed

1 test skipped:

R= everseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)


D= ave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB U= K: http://www.ent= erprisedb.com
The Enterprise PostgreSQL Company
--000000000000e07653058cb1cdcd--