public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM_2424]: Menu Items don't appear in tools menu for modules that are loaded using deps
Date: Tue, 30 May 2017 16:31:59 +0100
Message-ID: <CA+OCxoyEdD3hLj8CKe8kUtGoSD3GiqxYFB-E622AOmu1jKPAYg@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D86hMaWan8o5ram63dqEPPPkTO8YaaWV5H2fvp-2v2yag@mail.gmail.com>
References: <CAM5-9D86hMaWan8o5ram63dqEPPPkTO8YaaWV5H2fvp-2v2yag@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

On Mon, May 29, 2017 at 8:52 AM, Surinder Kumar
<[email protected]> wrote:
> Hi
>
> Issue:
>
> If modules are loaded without any node dependency(i.e: on page load), the
> function 'create_menu' is called implicitly to generate menu items.
>
> But when the modules are loaded when its dependent node expands, the
> function 'create_menus' has to explicitly call after 'add_menus' from
> respective module's template files.
>
> This patch is dependent on patch 'load_modules_js_when_required.patch'
>
> Please find attached patch and review.

Unfortunately I just realised why this change isn't so good - it
causes the menus to be built when JS is loaded. That's not good, as we
really want the Tools menu to list all items, all of the time - it's
important that menu stays consistent so that users don't get confused
when they find an option they expected to be there, isn't.

Is there any way you can think of to have the menu items added at
startup, but the rest of the code loaded as needed?

Of course, whatever we do with Grunt/webpack will make this moot
anyway, so don't spend much time on it..

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM_2424]: Menu Items don't appear in tools menu for modules that are loaded using deps
  In-Reply-To: <CA+OCxoyEdD3hLj8CKe8kUtGoSD3GiqxYFB-E622AOmu1jKPAYg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox