Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgadmin-hackers-owner+M24577=pgadmin-hackers-arka@postgresql.org>)
	id 1arZE2-00059b-QH
	for pgadmin-hackers@arkaria.postgresql.org; Sat, 16 Apr 2016 23:02:02 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgadmin-hackers-owner+M24577=pgadmin-hackers-arka@postgresql.org>)
	id 1arZE2-0007oj-DD
	for pgadmin-hackers@arkaria.postgresql.org; Sat, 16 Apr 2016 23:02:02 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <dpage@pgadmin.org>)
	id 1arZE2-0007ob-0W
	for pgadmin-hackers@postgresql.org; Sat, 16 Apr 2016 23:02:02 +0000
Received: from mail-ig0-x232.google.com ([2607:f8b0:4001:c05::232])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.84_2)
	(envelope-from <dpage@pgadmin.org>)
	id 1arZDz-0008Cp-4S
	for pgadmin-hackers@postgresql.org; Sat, 16 Apr 2016 23:02:00 +0000
Received: by mail-ig0-x232.google.com with SMTP id g8so53184141igr.0
        for <pgadmin-hackers@postgresql.org>;
 Sat, 16 Apr 2016 16:01:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=pgadmin-org.20150623.gappssmtp.com; s=20150623;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc;
        bh=CA4i0F5e6VobBmKlYD10iJPKAe0/P0LW00AlzaIbh2I=;
        b=MeeWPMgFX0GGhVp64hv1/54Wor6sI1VSX0yIsA20YhfdcC8Nj8nVt2x7VKa7LJEdg5
         Kjer/BZgbhu56QQ7BdWs/9REp3ho/sfUJ+1nWTw3JtjtW2fs24gtnawClMYMDzWQbNi6
         /xvIlvh1VcB4vkXTy7KPlL9uBBBK/RxHlxhrbCJjnZPGlMqT2yb/MglkuxfH22/fTQUM
         NcAWCxdZinsgQQDTkZq0OtT+48ztH81L4mGNbNAulWmZKcybnJNgsEEOPyRa68PeJFFL
         cssGe7MDAj7gFLh3wJyekUOOxBBZ+muQ4yFRijc0AvS6/qqOgs9BLHqyemLqjs1FsEII
         V4ig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:cc;
        bh=CA4i0F5e6VobBmKlYD10iJPKAe0/P0LW00AlzaIbh2I=;
        b=UReu/DhErY5QPGkdlU+Q0cm83SkPdBrP4e+Q6TRKOGxargpYFBanVHs7Mi/R8tFmfB
         PSzWdz+YCedIQ+i6N8lRFyTslopWa+WXCXHPyCdIdKegwmaxmv58KIv+OmYoOlnDRkhO
         4r/YxwrQrSKc5RwvJzlP1M724gmSjEuB4AWVBjJq2+3PO/O2FCrPnh3XNfWtH0FmrrSo
         eJckf/sdONM7vhy+Hfrfg+6fW8TsRnXcLLmiQFKQX5R4KA8hIEQJMjOoHwnfaZ88YNu5
         gYLPPrKFk1s0Bo8JaBGd/W8S+zg1UW/1B4ekWrFNiu8CsBmfO1CPC+HpjxtHJFPy87xF
         To4A==
X-Gm-Message-State: 
 AOPr4FV2uV7swNgEGmu+ebaqSoEtp0cuB7rseIdUECXa0dscEgjD4lHSDkggY3UMP8EyAnOuNXZzTAp3yTeBCQ==
MIME-Version: 1.0
X-Received: by 10.50.59.210 with SMTP id b18mr12224985igr.11.1460847718454;
 Sat, 16 Apr 2016 16:01:58 -0700 (PDT)
Received: by 10.64.105.131 with HTTP; Sat, 16 Apr 2016 16:01:58 -0700 (PDT)
In-Reply-To: <op.yf0fc0s30sbe7t@118-65.static.ikomline.net>
References: <op.yf0fc0s30sbe7t@118-65.static.ikomline.net>
Date: Sun, 17 Apr 2016 00:01:58 +0100
Message-ID: 
 <CA+OCxoyEhhsJTzQbyucs_KEHWJTXf9n=9rGt-TsxB5GA1T6Ohw@mail.gmail.com>
Subject: Re: pgAdmin4.cpp - sync missing
From: Dave Page <dpage@pgadmin.org>
To: =?UTF-8?Q?Vladimir_Kokovi=C4=87?= <vladimir.kokovic@gmail.com>
Cc: "pgadmin-hackers@postgresql.org" <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=047d7bea3bac5462cb0530a21df3
X-Pg-Spam-Score: -2.6 (--)
List-Archive: <http://archives.postgresql.org/pgadmin-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgadmin-hackers.postgresql.org>
List-Owner: <mailto:pgadmin-hackers-owner@postgresql.org>
List-Post: <mailto:pgadmin-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgadmin-hackers>
List-Unsubscribe: 
 <mailto:majordomo@postgresql.org?body=unsub%20pgadmin-hackers>
X-Mailing-List: pgadmin-hackers
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--047d7bea3bac5462cb0530a21df3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi

On Saturday, April 16, 2016, Vladimir Kokovi=C4=87 <vladimir.kokovic@gmail.=
com>
wrote:

> Hi,
>
> settings.sync() missing after the line 110
>

Thanks - in theory it shouldn't be needed as it'll be called in the
destructor and periodically in the event loop, but it doesn't hurt to save
anyway.

Patch applied.


--=20
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--047d7bea3bac5462cb0530a21df3
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi<br><br>On Saturday, April 16, 2016, Vladimir Kokovi=C4=87 &lt;<a href=3D=
"mailto:vladimir.kokovic@gmail.com">vladimir.kokovic@gmail.com</a>&gt; wrot=
e:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-l=
eft:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
settings.sync() missing after the line 110<br></blockquote><div><br></div><=
div>Thanks - in theory it shouldn&#39;t be needed as it&#39;ll be called in=
 the destructor and periodically in the event loop, but it doesn&#39;t hurt=
 to save anyway.</div><div><br></div><div>Patch applied.</div><br><br>-- <b=
r>Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_bla=
nk">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseD=
B UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.=
enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br><br>

--047d7bea3bac5462cb0530a21df3--