Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brmjT-00062t-Hx for pgadmin-hackers@arkaria.postgresql.org; Wed, 05 Oct 2016 13:59:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1brmjS-00011j-5u for pgadmin-hackers@arkaria.postgresql.org; Wed, 05 Oct 2016 13:59:38 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1brmjR-00011Z-Fp for pgadmin-hackers@postgresql.org; Wed, 05 Oct 2016 13:59:37 +0000 Received: from mail-it0-x236.google.com ([2607:f8b0:4001:c0b::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1brmjJ-0008Ek-Py for pgadmin-hackers@postgresql.org; Wed, 05 Oct 2016 13:59:35 +0000 Received: by mail-it0-x236.google.com with SMTP id j69so196519276itb.0 for ; Wed, 05 Oct 2016 06:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EOC9YuztcFUzWStxgzGqKR8QqmbPdUYCbXRL6YfjAKM=; b=bqyiR++Pq9NorEM65vY4lC0m1S6nXULmJkR7VoXZifqbdYrx23i1GQfoEQTKJeytZv z6g2POd9wNZEYCfTPbm8N/yuclqQcyabgjihmL/oKyohBmUviWHgJCJCvoOjiI1C7JzL H65zopR7Tu5qXWErhX8auQZgR5qIuZcmNqiT1kp06AxuHEngf8q04CRiQ1+8i+fXsjWD Em3fSgfVoNek/UakcB8u1zqna44zTZU+LUjDhcMsd3kIzhhDufaW9UY4Lcycein3wpJR rerAzZpuuwDWRJsJmWVnFMZaTgv33+3HrLmAjCxc1rgnGlVGcLythh2uEVd08tsq/ySS jLsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EOC9YuztcFUzWStxgzGqKR8QqmbPdUYCbXRL6YfjAKM=; b=a4pyV/zW0xyeYPvujXsSgvjrjwdq2O5oQ1bcTbqlkK8j1IZPw6ZyOjX1h6jHMVpGcf 8qR6T0YHkvJHG806BB9j3cuyyrhmi5P4ZJxZvoL9dy3g4UdMegn+7Mis8LAIg891okB1 fiwBmR1mg8qhA5DfHN2Sf7kdmk9P0SpxmnG+l4vZTZC8l5WiTwOAveSfHg5zO2HHzDX4 bXexT6sdcGvWTmSIwrlnZ78uyju4MFuZcmoX5nkmjvAHAhdJRki7WrosxaiIsERWgbcA s6F85MVnDc7PS5qzxXWQskETk/vLRW4lgLsu3DM4dNrSZby4yjZOjJyKB9rtKnHBs5v6 DErg== X-Gm-Message-State: AA6/9RmBl3jrjDUOpUxrCg1LnEqvXtQwbvXg2HFadw8D6zNoHEElnm/p9gLZSatG/wZcyVlSLd5YRg5CFYTBrg== X-Received: by 10.36.33.18 with SMTP id e18mr29604602ita.113.1475675966002; Wed, 05 Oct 2016 06:59:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Wed, 5 Oct 2016 06:59:25 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 5 Oct 2016 14:59:25 +0100 Message-ID: Subject: Re: PATCH: To fix the issue in Debugger module (pgAdmin4) To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org OK, that's much better. I think I've figured out what's causing the remaining execution error as well - we're not disabling the buttons until we get a response from the server, so if you click too quickly, you make multiple requests at once. I tested this by adding a "SELECT pg_sleep(2);" to a loop in a function. If you can fix that as well, then I think we can call this issue fixed. Thanks! On Wed, Oct 5, 2016 at 1:09 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch for the same. > RM#1227 > > Please review. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Oct 3, 2016 at 6:05 PM, Dave Page wrote: >> >> Hi >> >> On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala >> wrote: >> > Hi Dave, >> > >> > PFA updated patch to fix mentioned issue as well as incremental msgs >> > updates >> > in Messages Tab. >> >> This doesn't seem to work well. In pgAdmin 4 I get the following: >> >> ==== >> SELECT 1 >> INFO: EMPNO ENAME >> >> >> INFO: ----- ------- >> >> >> SELECT 1 >> SELECT 1 >> SELECT 1 >> INFO: 7369 SMITH >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7499 ALLEN >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7521 WARD >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7566 JONES >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7654 MARTIN >> >> >> SELECT 1 >> INFO: 7698 BLAKE >> >> >> SELECT 1 >> SELECT 1 >> SELECT 1 >> INFO: 7782 CLARK >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7788 SCOTT >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7839 KING >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7844 TURNER >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7876 ADAMS >> >> >> SELECT 1 >> INFO: 7900 JAMES >> >> >> SELECT 1 >> SELECT 1 >> INFO: 7902 FORD >> >> >> SELECT 1 >> SELECT 1 >> SELECT 1 >> INFO: 7934 MILLER >> >> >> SELECT 1 >> SELECT 1 >> SELECT 1 >> SELECT 1 >> ==== >> >> Whilst in pgAdmin III I get: >> >> ==== >> INFO: EMPNO ENAME >> INFO: ----- ------- >> INFO: 7369 SMITH >> INFO: 7499 ALLEN >> INFO: 7521 WARD >> INFO: 7566 JONES >> INFO: 7654 MARTIN >> INFO: 7698 BLAKE >> INFO: 7782 CLARK >> INFO: 7788 SCOTT >> INFO: 7839 KING >> INFO: 7844 TURNER >> INFO: 7876 ADAMS >> INFO: 7900 JAMES >> INFO: 7902 FORD >> INFO: 7934 MILLER >> SELECT 1 >> ==== >> >> Sidenote: pgAdmin III uses a fixed-width font for this output which >> works far better than pgAdmin 4's variable width font. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers