Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJEAO-0007mE-3y for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Mar 2021 11:35:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEAN-0004Nv-1F for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Mar 2021 11:35:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJEAM-0004No-Ql for pgadmin-hackers@lists.postgresql.org; Mon, 08 Mar 2021 11:35:14 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJEAL-0006tG-7C for pgadmin-hackers@postgresql.org; Mon, 08 Mar 2021 11:35:14 +0000 Received: by mail-ej1-x62e.google.com with SMTP id p7so8213164eju.6 for ; Mon, 08 Mar 2021 03:35:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YKqAPPYJ0KBGcR7AMosHaRoLDgHFKtcCfq4ceWWICT8=; b=fDUsJlhWsO6V1H7e09EvDvWmCRAM30jKm5NPj29G0EXnf8HEiMXc1ESuqN+S6xlYxo t2CFBFAPMNzhQgInj9Qsb9rJ6IwGffgGGOgiABco2+Al284+2HvChUcNIAQLDNBq5lIa TfrJjyVC7rekl4vULjMhmSmZjxyVSYdvEx3Pc9n/y3kXCqln+s0wKGuN6Nh8rmCcqBVq 2KzAY1eqEJm3Ow0nj6OxVxJH/U7dvPycMwMi5RIQVt4kOXTtKqPT6qG4TNOctBp/l7o2 OaJv9BKHnS/SFNwjbYAXh5fIFCveUiZVUxrPWX6VbshkmIrMy7Xf1iWQV512LO5eR7qK oOiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YKqAPPYJ0KBGcR7AMosHaRoLDgHFKtcCfq4ceWWICT8=; b=EJEYAxOPHft10VvWWQ+1IFsdLhCWm3hf3Kwev0zZjV0TjtqE1kemqkonVpQNXPt8AI XIn+tTlQMtIERu+pQ9AtE5HObmZGVsfNHt6yU/Ca75zEWkkhge/OVcr+N66nQs2B7pmu 2bxgHNl3fqfAqqHdOJA83Bn7YDsgxZOnrE4j4bsZcTFBc8sjMyjut/SZvlAL8zenKXUW Chhl8kpDcBTgDMTA78tAY2yG3sHjzbfLmmKIfH1nClKoZ8zrD0nYul8Ctu60wSeOlmLe eTEO0y7NQCTQj/5guGjbNJhK43g+8AVp+4PpSav1Yl4OU4K/ICiJ0xTRXn6lIp6HshuM rPdA== X-Gm-Message-State: AOAM532ic1TPoFN5dd2VSHIUn4Myb9qFOiwXouCdOx2NmdbmFDUMHrgF RAVO1CVgAG5G83REjCCGqlcjhpF5kKnL4AtjjESIBA== X-Google-Smtp-Source: ABdhPJy/ZqgQgdKB8zbGksyDKqtIuTQsNu/6k2r80XWGKGRUY74KwLlqGPK26v26gRkIIsWoBih6cBVIKQrcp1F2qjU= X-Received: by 2002:a17:906:1408:: with SMTP id p8mr14371341ejc.89.1615203311508; Mon, 08 Mar 2021 03:35:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 8 Mar 2021 11:35:00 +0000 Message-ID: Subject: Re: Making Kerberos optional in the Python wheel To: Khushboo Vashi Cc: pgadmin-hackers , Shaheed Haque Content-Type: multipart/alternative; boundary="0000000000009f6e8205bd04d313" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000009f6e8205bd04d313 Content-Type: text/plain; charset="UTF-8" Thanks - patch applied, with a couple of other tweaks to version numbers for Python in the readme's etc. On Mon, Mar 8, 2021 at 11:20 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Dave, > > The patch looks good to me. > > Thanks, > Khushboo > > On Mon, Mar 8, 2021 at 4:42 PM Dave Page wrote: > >> Has anyone been able to review this? >> >> On Thu, Mar 4, 2021 at 10:02 AM Dave Page wrote: >> >>> There have been a couple of complaints that the latest Python wheel >>> distribution doesn't install cleanly. This happens when there is no >>> pre-built gssapi wheel on PyPi that matches the users combination of Python >>> version and platform, *and* the MIT Kerberos development headers etc. are >>> not present on the system, so the source wheel cannot be compiled. >>> >>> This seems like it's a bit onerous on users, especially if they're on >>> Windows where they'll also need a suitable compiler to be installed. The >>> attached patch aims to address that by making the Kerberos support optional >>> (thankfully, Khushboo made the code handle lack of gssapi libraries). >>> >>> To install without gssapi, users would simply do: >>> >>> pip install pgadmin4 >>> >>> or >>> >>> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl >>> >>> To install with gssapi: >>> >>> pip install pgadmin4['kerberos'] >>> >>> or >>> >>> pip install pip install >>> /path/to/pgadmin4-5.0-py3-none-any.whl['kerberos'] >>> >>> The patch also cleans up some old cruft that was required for now >>> unsupported Python versions. >>> >>> Thoughts? >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: http://www.enterprisedb.com >>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com --0000000000009f6e8205bd04d313 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks - patch applied, with a couple of other tweaks to v= ersion numbers for Python in the readme's etc.

On Mon, Mar 8, 2021 at 11= :20 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

The patch looks good to me.=C2=A0

Thanks,
=
Khushboo

On Mon, Mar 8, 2021 at 4:42 PM Dave Page <dpage@pgadmin.org> wrote= :
Has anyone been able to review this?

On Thu, Mar 4, 2021 at 10:02 AM Dave= Page <dpage@pgad= min.org> wrote:
There have been a couple of complaints that the lat= est Python wheel distribution doesn't install cleanly. This happens whe= n there is no pre-built gssapi wheel=C2=A0on PyPi that matches the users co= mbination of Python version and platform, *and* the MIT Kerberos developmen= t headers etc. are not present on the system, so the source wheel cannot be= compiled.

This seems like it's a bit onerous=C2=A0o= n users, especially if they're on Windows where they'll also need a= suitable compiler to be installed. The attached patch aims to address that= by making the Kerberos support optional (thankfully, Khushboo made the cod= e handle lack of gssapi libraries).

To install wit= hout gssapi, users would simply do:

pip install pg= admin4

or=C2=A0

pip insta= ll=C2=A0pip install /path/to/pgadmin4-5.0-py3-none-any.whl

To install with gssapi:

pip install = pgadmin4['kerberos']

or=C2=A0
pip install=C2=A0pip install /path/to/pgadmin4-5.0-py3-none-an= y.whl['kerberos']

The patch also cleans up= some old cruft that was required for now unsupported Python versions.

Thoughts?

--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
=
EDB: http://w= ww.enterprisedb.com



--


--
--0000000000009f6e8205bd04d313--