Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewRCB-0006X4-IU for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 11:37:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewRCA-0000Wb-G5 for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 11:37:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewRCA-0000WR-3Q for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 11:37:18 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewRC6-0003UX-N9 for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 11:37:16 +0000 Received: by mail-wm0-x231.google.com with SMTP id w128so9863328wmw.0 for ; Thu, 15 Mar 2018 04:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=f6x0K2YL5ghS9OWmdo99VEyrn0glDkS7OlChzr3oIYg=; b=hdp9RlQyOAyUIh0D6CShwi7hlsatcQd54uFTpf/mi808K6VlycZxiiaCcUaAJ6sgIc EUg1cIeqmNEs5BW4Hq5fIrUfCGkLs/r+meSqCx12aAISOXHQzheCIP8+uggxedT41YX5 KTbILmiCgQ4CyxYTeZusrMHilpIcDpsYzzwTPa+AsgGjOanLaXSw/M3CSg3G/Pp6oSc1 2n0pQvrcmoobrlhq9TdRyHs87lub0kblNrpf6goodT9wMgzX8FXU+c8spoAkc92Cwtg2 xi/P01M/cJIMtZdFnO+tnjOh5e4F5lk35GuOMwi6muJuIZWQ4Z/SQddnJPtbhRyF6EQV 8q2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=f6x0K2YL5ghS9OWmdo99VEyrn0glDkS7OlChzr3oIYg=; b=mysCpET/yZ0X8oZyiBbUNDnc02wdenDkxVTXwafx/HROQ2QB0/AuCViw19/41svSJy RUvvjySxxQNXtmUDtljtWytq/ar2YcLyBvS+58JRNnn5IKu6arqNsELCLhsiD6IqYgDz Sk6BYvvviR7sp2IG4bQR0TOYeWHewqqf5MSqz4lqa4Z2wgx1bJlKMYYQf6TfEn8PJ0Fu 1liUE4dMsGhRlRMKpoYo63Vwf/71BDQGG/Ho0cJ2UgjWiAdJioIt6HyyNhHzPNKYsvkw /9h5Y+iRO635FNRcOlB1kKNXr+qd20wNMEakUpgS5zmmCtd6pkrvBA4Uo0mp8VhQjENO Ps6g== X-Gm-Message-State: AElRT7H3K9V8fesqLpmgSM7CZfehBNbbg2y6qOQljmLkjBpWZt0fJ7so IroLBRmURlY4eZ4hkTH1JkT7p5u4S76WUQwUcZGUgw== X-Google-Smtp-Source: AG47ELt3CbJAah7MtQ9SW6a1SgFmmXhbE9JHPObCTzBAHerUIZxNvKMaK6X/0Un75CaOIEgt2bWEMoEebpPCtg0Vof8= X-Received: by 10.28.130.9 with SMTP id e9mr4220072wmd.161.1521113831817; Thu, 15 Mar 2018 04:37:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Thu, 15 Mar 2018 04:37:11 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 15 Mar 2018 07:37:11 -0400 Message-ID: Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers To: Khushboo Vashi Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a11444b449bce74056771e98c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a11444b449bce74056771e98c Content-Type: text/plain; charset="UTF-8" Hi On Thu, Mar 15, 2018 at 12:55 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Thu, Mar 15, 2018 at 3:21 AM, Dave Page wrote: > >> Hi >> >> On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached updated patch. >>> >> >> Can you add a unit test for set_env_variables() please? >> >> > This function is a part of a BatchProcess class which is used by all > backup/restore/maintenance etc modules. So, when we write test cases for > this module this function will be covered. > I had already created RM for the same (Ref: https://redmine.postgresql. > org/issues/3206) and it is in the current sprint. > OK, thanks. Patch applied. > >>> Thanks, >>> Khushboo >>> >>> On Wed, Mar 14, 2018 at 1:07 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without >>>>> your patch applied. >>>>> >>>>> Yes, good point. Will update and send the patch. >>>> >>>>> >>>>> On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi Khushboo, >>>>>> >>>>>> We can simplify this, we don't need to create any extra column, >>>>>> >>>>>> Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322 >>>>>> where we are setting ENV variable we can create common utility function >>>>>> (let say in ../tools/utils/__init__.py) which will set all required the >>>>>> environment variables and then we will pass that function in p.start(..) >>>>>> method. >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi < >>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Please find the attached patch to fix RM #3122 : Backup not working >>>>>>> on certificate (SSL) protected servers. >>>>>>> >>>>>>> The attached patch fixes the issue in the following modules: >>>>>>> >>>>>>> 1. Backup >>>>>>> 2. Restore >>>>>>> 3. Import/Export >>>>>>> 4. Maintenance >>>>>>> >>>>>>> Thanks, >>>>>>> Khushboo >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a11444b449bce74056771e98c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Mar 15, 2018 at 12:55 AM, Khushboo Vashi &l= t;khus= hboo.vashi@enterprisedb.com> wrote:


On Thu, Mar 15, 2018 at 3:21 AM, Dave Page <= dpage@pgadmin.org> wrote:
Hi

On Wed= , Mar 14, 2018 at 10:55 AM, Khushboo Vashi <khushboo.vashi@e= nterprisedb.com> wrote:
Hi,

Please = find the attached updated patch.

Can you add a unit test for set_env_variables() please?
=C2=A0
<= /div>
This function is a part of a BatchProce= ss class which is used by all backup/restore/maintenance etc modules. So, w= hen we write test cases for this module this function will be covered.
I had already created RM for the same (Ref: https://redmine.postgresql.= org/issues/3206) and it is in the current sprint.

OK, thanks. Patch applied.
=C2=A0

Thanks,
Khushboo

On Wed, Mar 14, 2018 at 1:07 PM, Khushboo= Vashi <khushboo.vashi@enterprisedb.com> = wrote:


On We= d, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala <murtuza.z= abuawala@enterprisedb.com> wrote:
= =C2=A0../pgadmin4/web/pgadmin/tools/import_export/__in= it__.py +310=C2=A0without your patch applied.

Yes,= good point. Will update and send the patch.=C2=A0

On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com><= /span> wrote:
= Hi Khushboo,

We can simplify this, we don't need to create any extra colum= n,
<= br>
= Check: ../pgadmin4/web/pg= admin/tools/import_export/__init__.py +322 where we are setting= ENV variable we can create common utility function (let say in ../tools/ut= ils/__init__.py) which will set all required the environment variables and = then we will pass that function in p.start(..) method.


--
Regards,
Murtuza Zabuawala
EnterpriseD= B:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreS= QL Company


On Wed, Mar 14, 2018 at 11:03 AM, Khushboo V= ashi <khushboo.vashi@enterprisedb.com> wr= ote:
= Hi,

Please find the attached patch to fix RM #3122 :=C2= =A0Backup not working on certificate (SSL) protected servers.
The attached patch fixes the issue in the following modules:

1. Backup
2. Restore
3. Import/E= xport
4. Maintenance

Thanks,
K= hushboo









<= /div>--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a11444b449bce74056771e98c--