Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hahza-0005sr-8u for pgadmin-hackers@arkaria.postgresql.org; Tue, 11 Jun 2019 14:43:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hahzY-00048D-Dr for pgadmin-hackers@arkaria.postgresql.org; Tue, 11 Jun 2019 14:43:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hahzY-000485-0c for pgadmin-hackers@lists.postgresql.org; Tue, 11 Jun 2019 14:43:16 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hahzQ-0006Kj-Cc for pgadmin-hackers@postgresql.org; Tue, 11 Jun 2019 14:43:15 +0000 Received: by mail-io1-xd43.google.com with SMTP id u19so10083437ior.9 for ; Tue, 11 Jun 2019 07:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tFGfxqxa0GZQ/fvcmsCa4QdKkAdeLd7gLvZpKviyyLY=; b=p2sl3ISXcTxWOphw5yf8/dvPFBj2uhKmwKj5tlrtKOCdeIzrAKShbXGkrHRzm8o6Qr 2LfuHOjLtlrnkiHYoyAwWCkt76wFvZHUX9+0c1E1Jir+GaoFLlpKDZuvhqDrBN01Tqz4 Yj1wEznmBlY5Lr7+pYQiYgJtGon2ySGhHDsPE9rDoQjo8on4lC6pMD07eHoLoJgStlCG H64jS5TMyRhwywL4s3+U2tXZIvNS5XizKW8oKBaJ6JD4HQURAPIcUjga6wcN5HQ9EKjl DyvwYSlsPwsNYnCo7A+uQQsPC7MY8QDCVL6IB2qjV++mY2dJLSPHPB7lM/M4uwrIKO18 Fufg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tFGfxqxa0GZQ/fvcmsCa4QdKkAdeLd7gLvZpKviyyLY=; b=qA9pT22xDbKlxulgtxB+I99oskh4wnbQfqAlgEVo3To7eejFoR2vULwG3NaPea3pxJ g4bZRxgjp1ZWnp1JOsvyg2VgUdsm8Lo9P8pPdYP5dh76UBXvNHYKHwHBKsjdlKAPKBQ6 kUGuVnMRsSWz8chhgBbbalUpSymqVmYXE4lZAyStmDH5MOgDaSFwfIH7lL++Qctnl044 0nmRJ5TlgFO6FeWCdkz3YWl92WYkE5AHwlCyFVKmcLEPrBfiNaSh9ovz0MzDM/Pp/Ar4 6YFbGwtXi/qkfdnAmIhLUPcnt4N1czTNlcgHFkg0UclJHD2MZFhLDrjUQiX5ud1hOk4G e8Qw== X-Gm-Message-State: APjAAAUMif1VXT+5EwJCGHwECbVstgve+4qGfgTowvhMTwfRFRjgKzJz 9yg574tlLLeY04b3vy7ybok9PkmGawDIVHJedwZ1Jg== X-Google-Smtp-Source: APXvYqysR6eHb5nHO8qcQEcreK1OPcZYmNwlVVjxMHbLYVBas51t90DGMHkspa8NKrW+3KaKx3IveISaO11yD5KRsE0= X-Received: by 2002:a5d:9456:: with SMTP id x22mr21702572ior.71.1560264185903; Tue, 11 Jun 2019 07:43:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 11 Jun 2019 15:42:53 +0100 Message-ID: Subject: Re: [pgAdmin][RM4228] Incorrect table listed in panel header To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008e925e058b0d50e4" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008e925e058b0d50e4 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Tue, Jun 11, 2019 at 11:22 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > It is failing irrespective of patch applied or not. :) > However, I have fixed it. Attached is the updated patch. > I have also flag for chromedriver 75. > > Just to add, I have also changed "Filtered Rows" dialog title to add table > details also. > > Kindly review. > > On Tue, Jun 11, 2019 at 2:50 PM Dave Page wrote: > >> Hi >> >> This doesn't pass the feature tests: >> >> ====================================================================== >> ERROR: runTest >> (pgadmin.feature_tests.browser_tool_bar_test.BrowserToolBarFeatureTest) >> Browser tool bar feature test >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/browser_tool_bar_test.py", >> line 55, in runTest >> self.test_filtered_rows_tool_button() >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/browser_tool_bar_test.py", >> line 112, in test_filtered_rows_tool_button >> ".alertify .ajs-header[data-title='Data Filter']") >> File >> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", >> line 305, in find_by_css_selector >> lambda driver: driver.find_element_by_css_selector(css_selector) >> File >> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", >> line 485, in wait_for_element >> self._wait_for("element to exist", element_if_it_exists) >> File >> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", >> line 560, in _wait_for >> "Timed out waiting for " + waiting_for_message >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/selenium/webdriver/support/wait.py", >> line 80, in until >> raise TimeoutException(message, screen, stacktrace) >> selenium.common.exceptions.TimeoutException: Message: Timed out waiting >> for element to exist >> >> >> On Tue, Jun 11, 2019 at 8:35 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix incorrect label on panels when using >>> filtered rows. >>> I've also moved redundant code for filter data in datagrid.js to >>> show_data.js, reusing the existing code of view/edit data. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000008e925e058b0d50e4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Tue, Jun 11, 2019 at 11:22 AM Aditya To= shniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi,

It is failing irrespective of = patch applied or not. :)
However, I have fixed it. Attached is the updated = patch.
I have also flag for chromedriver 75.

Just to add, I have also = changed "Filtered Rows" dialog title to add table details also.
<= br>
Kindly review.

On Tue, Jun 11, 2019 at 2:50 PM Dave Page <dpage@pgadmin.org>= wrote:
Hi

This doesn't pass the feature tests:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D
ERROR: runTest (pgadmin.feature_tests.browser_tool_bar_test.Br= owserToolBarFeatureTest)
Browser tool bar feature test
--------------= --------------------------------------------------------
Traceback (most= recent call last):
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgad= min/feature_tests/browser_tool_bar_test.py", line 55, in runTest
= =C2=A0 =C2=A0 self.test_filtered_rows_tool_button()
=C2=A0 File "/U= sers/dpage/git/pgadmin4/web/pgadmin/feature_tests/browser_tool_bar_test.py&= quot;, line 112, in test_filtered_rows_tool_button
=C2=A0 =C2=A0 ".= alertify .ajs-header[data-title=3D'Data Filter']")
=C2=A0 F= ile "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_pa= ge.py", line 305, in find_by_css_selector
=C2=A0 =C2=A0 lambda driv= er: driver.find_element_by_css_selector(css_selector)
=C2=A0 File "= /Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py"= ;, line 485, in wait_for_element
=C2=A0 =C2=A0 self._wait_for("elem= ent to exist", element_if_it_exists)
=C2=A0 File "/Users/dpage= /git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 560,= in _wait_for
=C2=A0 =C2=A0 "Timed out waiting for " + waiting= _for_message
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/py= thon3.7/site-packages/selenium/webdriver/support/wait.py", line 80, in= until
=C2=A0 =C2=A0 raise TimeoutException(message, screen, stacktrace)=
selenium.common.exceptions.TimeoutException: Message: Timed out waiting= for element to exist


On Tue, Jun 11, 2019 at 8:35 = AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers= ,

Attached is the patch to fix incorrect label on panels when usin= g filtered rows.
I've also moved redundant code for = filter data in datagrid.js to show_data.js, reusing the existing code of vi= ew/edit data.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
<= font face=3D"verdana, sans-serif">Software Engineer |=C2=A0Enterp= riseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twit= ter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Post= greSQL Company


--
Thanks and Regards,=
Aditya Toshniwal<= /span>
Software Engi= neer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TR= EE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000008e925e058b0d50e4--