Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTif6-0001an-5s for pgadmin-hackers@arkaria.postgresql.org; Thu, 23 May 2019 08:01:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hTif4-0005LR-OT for pgadmin-hackers@arkaria.postgresql.org; Thu, 23 May 2019 08:01:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTif4-0005LI-A8 for pgadmin-hackers@lists.postgresql.org; Thu, 23 May 2019 08:01:14 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTiex-0005jT-H9 for pgadmin-hackers@postgresql.org; Thu, 23 May 2019 08:01:12 +0000 Received: by mail-it1-x142.google.com with SMTP id m3so8173989itl.1 for ; Thu, 23 May 2019 01:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OhhScT4Ew/K7xX/vMgXmV8DQynBNEXn67/9jn2X6utc=; b=Ps40Qh8njWhfpt54XX6XubCjyamZSG0DI187cPHIouWzVcOUJOLXSvsfMZWcIeOUM2 rDh1vdoxmsBVK7tDb1gDJiWWzOthZ2HhkRlAA8/ycxpfyvtzuzHU2j+D7IVZSz25AXnz XAJ+D8TV/XUxxfNU+rBN7DLVe+y7Kr01l5ZtZsxXZPSoVF/fCvxzwJvl4mV8u83FhTm9 ZQiifitdjdjOYCcKvtGcVT+t+FbCUveX5dr7+fyRIBUYfNXAsfjd5iUIUegajsrg276o aVdk9UVO6a5wwvQ87OtP1VYU4nx9YUmfj5cwSM22wRVtiPhqNCYqM1sLLKQRhhim366M 6Azw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OhhScT4Ew/K7xX/vMgXmV8DQynBNEXn67/9jn2X6utc=; b=se0HISs5XFWAcbN29T4+sBtnbTNmDW5q6OiDcSDbU3Av8LhRCKVARYFqXZkxjUvZw6 AcF3ZHC2CaIMK1LFMzLd6hJ+YTYAjGKSrm/eSXb0hPGRx66yJHDHofbstsTUb9m9QNF/ VvLzBQfpgRnemdfnTl5ZJ7F90Eo/XHi1m3WIIg6o9k12sv3cmchnEd/uLO8JzgXcMemB 5KTZye9zH0BomdA7Gd9lm5CDMbiJTScQen2dcbouj/KrfEbVCjw8ce/CQSM/KbOPER5k NMpSNCewX7cWnzEE2OtnYWlwq+9+C2quDkHDLBOd+kaBEROh2CXlEZmoRx/YRIGyniwp RVsQ== X-Gm-Message-State: APjAAAWHTm0P3NdfXTwONzvKw8aRa46uZCV8SZeGx1zldROF3nCZn3nh khZCQn/UhxXZDx5Pi0qxdRyM6esBFRP/yXnKT74RmA== X-Google-Smtp-Source: APXvYqw9V/GJ+1LsG9eFlxsXyQ66JXS5aH1/qVuDNnDWjGGsrAixxpxqJH/suqKi79IjiJQ4vv1k8wTKnoYIcZKOlRQ= X-Received: by 2002:a24:9d94:: with SMTP id f142mr11542704itd.179.1558598466424; Thu, 23 May 2019 01:01:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 23 May 2019 09:00:55 +0100 Message-ID: Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility) To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000f072b30589897b8b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f072b30589897b8b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On further testing, this doesn't seem to be working as expected. Alt+Shift+] or [ in the query tool are typing =E2=80=99 and =E2=80=9D and n= ot changing the tab. If I switch to a non-input tab (e.g. History), they still don't work. Alt+Shift+Tab changes the panel successfully though, and does cause the flash as expected. I'm using Chrome 74.0.3729.131 on Mojave. On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > Attached is the updated patch with doc changes. > > On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: >> >>> Hi >>> >>> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch to fix the accessibility issue in query tool. >>>> >>>> The query tool can be completely restructured unlike previously where >>>> query tool used to stick at top and other tabs in the bottom. >>>> - I have added a new shortcut to switch between frames if in query too= l >>>> the tab positions are changed. On switching the frames, the frame will >>>> blink to show it is focussed. >>>> - In the frame, you can switch tab same as previous. The tabs in SQL >>>> editor are cyclic now, which means if you execute shortcut to go right= on >>>> the last tab then it will cycle to first tab. >>>> - I have also changed the default shortcut to switch between tabs from >>>> Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we have in >>>> browser tabs. >>>> - Similar changes done for debugger also. >>>> >>> >>> Shouldn't there be documentation changes to go with this? >>> >> Yes, definitely :P >> Will send the updated patch. >> >>> >>> Otherwise, it seems to work :-) >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000f072b30589897b8b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

O= n further testing, this doesn't seem to be working as expected. Alt+Shi= ft+] or [ in the query tool are typing=C2=A0=E2=80=99 and =E2=80=9D and not= changing the tab. If I switch to a non-input tab (e.g. History), they stil= l don't work.=C2=A0

Alt+Shift+Tab changes the = panel successfully though, and does cause the flash as expected.=C2=A0

I'm using Chrome=C2=A074.0.3729.131 on Mojave.

On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal <aditya.toshniwal@enterprised= b.com> wrote:
Hi,

Attached is the updated patch with doc changes.

On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal <aditya.toshniwal@enter= prisedb.com> wrote:
Hi,

On Tue, May 21, 2019 at 5:= 32 PM Dave Page <= dpage@pgadmin.org> wrote:
Hi

On Tue, May 21, 2019= at 10:01 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wro= te:
Hi Hackers,

Attached is the patch to fix the acce= ssibility issue in query tool.

The query to= ol can be completely restructured unlike previously where query tool used t= o stick at top and other tabs in the bottom.=C2=A0
- I have added a new shortcut to switch between = frames if in query tool the tab positions are changed. On switching the fra= mes, the frame will blink to show it is focussed.=C2=A0
- In the frame, you can switch tab same as = previous. The tabs in SQL editor are cyclic now, which means if you execute= shortcut to go right on the last tab then it will cycle to first tab.
- I have also changed the de= fault shortcut to switch between tabs from Shift+Ctrl+ArrowKeys to Shift+Ct= rl+[ and ] similar to what we have in browser tabs.
- Similar changes done for debugger also.
=

Shouldn't there be documentation= changes to go with this?=C2=A0
Yes, definit= ely :P
Will send the updated patch.=C2=A0

Otherwise, it seems to work :-)
<= div>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>


--
Thanks and Regards,
Aditya Toshniwal
Software Engine= er |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE= "


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000f072b30589897b8b--