MIME-Version: 1.0
References: 
 <CAOBg0ANnFFsknDcF6NfLaDVc6x1EFwf_KUO+gbKtR7qvyfAY5A@mail.gmail.com>
 <CAOBg0AOcPNT69=Eqd22sNChWUGz6HpMt1qXrs4_pgCP6sO0H7Q@mail.gmail.com>
 <CA+OCxoy_TUdmca3pB1hgnRKniwQ8-XsKD_2uVTZW9BnTiVuGEA@mail.gmail.com>
 <CAOBg0AM8coLjoYL6kUirbo+5cmm9VhqXp0SH_FgRyzekBaPOtA@mail.gmail.com>
 <CA+OCxozx6vJFM20CVn0VZrdC9LLOjGiN4_zZQ6i23_6anBpRmg@mail.gmail.com>
 <CAOBg0APy7ONbPTFSHFqcvtYzDNKc7dSgv1Qz+Cg7kb_mF9p7gg@mail.gmail.com>
 <CA+OCxox4MRytMEN_XKnoF1t99Lxf-2JnJvy-f+Ux1P9Fp0aBzQ@mail.gmail.com>
 <CAOBg0AOd-8t_KaSxfMGpBMCkEHTEwoSBV4nOmvVVbG6rF+GUGg@mail.gmail.com>
In-Reply-To: 
 <CAOBg0AOd-8t_KaSxfMGpBMCkEHTEwoSBV4nOmvVVbG6rF+GUGg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 25 Aug 2020 14:38:52 +0100
Message-ID: 
 <CA+OCxoyKCp-uvuOVi7ZKvhjAAaqVqRu6YiSZpZ0mDvrFctaQiQ@mail.gmail.com>
Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000009532dd05adb3d313"
Precedence: bulk

--0000000000009532dd05adb3d313
Content-Type: text/plain; charset="UTF-8"

Hi

On Tue, Aug 25, 2020 at 12:49 PM Nikhil Mohite <
nikhil.mohite@enterprisedb.com> wrote:

>
> PFA v5 patch for the same.
>
> if required any updates in this please let me know.
>

Hmm, yeah - that doesn't work for me I'm afraid; it's mixing content with
code.

The titles should be defined in the HTML pages themselves. We do that
everywhere else by including a template block like the following in the
lowest level content:

{% block title %}Contributing{% endblock %}

And then in base.html:

<title>{% block title %}{% endblock %}</title>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

--0000000000009532dd05adb3d313
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Tue, Aug 25, 2020 at 12:49 PM Nikhil=
 Mohite &lt;<a href=3D"mailto:nikhil.mohite@enterprisedb.com">nikhil.mohite=
@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex"><div dir=3D"ltr"><div><br></div><div class=3D"gmail_quote"=
><div>PFA v5 patch for the same.</div><div><br></div><div>if required any u=
pdates in this please let me know.</div></div></div></blockquote><div><br><=
/div><div>Hmm, yeah - that doesn&#39;t work for me I&#39;m afraid; it&#39;s=
 mixing content with code.</div><div><br></div><div>The titles should be de=
fined in the HTML pages themselves. We do that everywhere else by including=
 a template block like the following in the lowest level content:</div><div=
><br></div><div>{% block title %}Contributing{% endblock %}</div><div><br><=
/div><div>And then in base.html:</div><div><br></div><div>&lt;title&gt;{% b=
lock title %}{% endblock %}&lt;/title&gt;<br></div></div><div><br></div>-- =
<br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave Page<b=
r>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pg=
snake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EDB: <a href=3D"http://w=
ww.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br><=
br></div></div></div>

--0000000000009532dd05adb3d313--