Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ez02A-0006rs-6d for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 13:13:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ez028-0007S4-Si for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 13:13:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ez028-0007Rp-IJ for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 13:13:32 +0000 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ez024-0006fe-Dp for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 13:13:31 +0000 Received: by mail-wr0-x230.google.com with SMTP id p53so1121948wrc.10 for ; Thu, 22 Mar 2018 06:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DeXRAodzdfzWWkYP9L933ImLudUCPJAoysWHiiiA6TU=; b=enzVFoEGudYhKth6ViEskNVLACpDSOyTVZWPDMpdaxKeVvguWqufKaSXCxBLC43y8X Hsu1RASIqfiZzwz/X2mkjeFX9t3ylv2BWk55yTapm/WnZAs5nwjDWJnxcFZUqCv0wrxe mpGzp+OizWkakBYnejEPEMpy4Cs2ZyrDb4cBZpq83LoSjmu6eyZjyOA+PTbAL0RMbcY/ R2owaWVgAII230AzQI6i6mBgaJHGsFQ8c7via1yMBOZHQrsuXNgZnAJDrtO3cGnvGtKW DLkot9+Z9kB3GjuVNO5Sv5a859HYQ6U640OJiiWXg61psQTve5WrzrfPmk+YSvPm4Np/ yUBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DeXRAodzdfzWWkYP9L933ImLudUCPJAoysWHiiiA6TU=; b=lnaGU6lTkWCLvRf36zeH1N9xfwLh4f51IWzv0pSNev7DaEMVtxgtT/eFf5ZzG420NE zc1i22E6SSW/P/6NJ3fHt/wJ+//60OL7RHuy/cVIXGEEaD9uQiLKY5DY+eW/RSLOAVM4 PHimFaM+X/xGBdWqXzhu2RlByR2J9UStSbFb6jgWyVK7wfsOfxhMRt2ghhCX674Wfi6Z /0dl5ptCkF3UjPkbzTgAEO8G2qWyx3vFJ/xewd2iRkMLciUMSOLRZeGVvRHlogqQ+OFU 8jFSPF4VaOM009NAGboeyKHOX51kd0yHoYGdF3kx3+6wQ9dxvGus0rqRy94IRf/hB9aI d7BQ== X-Gm-Message-State: AElRT7Ep5yGVLCqfamxxkqFzyVJYUb2YcVHyYhOv0kjhxq6PmtudQGhr 8pxNUssCs/j8Z3Zcc5cIp2OvCPjSbcubOAb+gXLSEg== X-Google-Smtp-Source: AG47ELszESJrSDZ/Tbllg3E4yVMFpgLbQUDhRiESf4CbKiF3h8kqlRSFOHXbM9drVA+q5Tu6ow8T0dXoVIy107vU3RM= X-Received: by 10.223.176.98 with SMTP id g31mr19106612wra.256.1521724407279; Thu, 22 Mar 2018 06:13:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Thu, 22 Mar 2018 06:13:25 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 22 Mar 2018 13:13:25 +0000 Message-ID: Subject: Re: v3.0 release on hold To: Akshay Joshi Cc: pgadmin-hackers , Murtuza Zabuawala , Khushboo Vashi , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="001a113c9c40be066b056800129b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113c9c40be066b056800129b Content-Type: text/plain; charset="UTF-8" Hi On Thu, Mar 22, 2018 at 1:00 PM, Akshay Joshi wrote: > > > On Thu, Mar 22, 2018 at 3:22 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 22, 2018 at 9:21 AM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: >>> >>>> We've run into a number of unexpected issues with the v3.0 release that >>>> I think we need to resolve before moving forwards. For the time being, only >>>> patches critical to fix these issues should be committed. >>>> >>>> I'll try to look at 1, though I do have another deadline I need to >>>> meet. >>>> Akshay, can you look at 2 please? >>>> Fahar is already looking at 3. >>>> Khushboo, can you look at 4 please? >>>> >>>> Thanks all. >>>> >>>> 1) There is no longer a system tray in Gnome 3.26 and later, and thus >>>> the runtime won't initialise in Fedora 27 and later. We need an alternative >>>> for this, either a tray replacement that the RPM can depend on, or better >>>> yet, support whatever it is Gnome expect such apps to use these days. >>>> >>>> 2) Starting a second instance of the app bundle on Mac doesn't always >>>> open a new pgAdmin window as it should. It works fine in the debugger, or >>>> if you start the app with a command like: "/Applications/pgAdmin\ >>>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click >>>> the appbundle or use a command like "open /Applications/pgAdmin\ 4.app" >>>> >>> >>> Still working on this, not found any solution yet. >>> >> > Not able to figure out the solution yet. I have tried to debug > the code, but every time it will create a new instance(tray icon). Do I > need to look into the code or something related to app bundle may be some > settings in info.plist or any other pointer? > Have a look at the code around line 85 an onwards of pgAdmin4.cpp. It creates the shared memory interlock (and log/address files) based on the current username and a hash of the executable name/path. My suspicion is that the path hash (which is calculated from argv[0] on line 72) is for some reason getting a different value each time when launched via the Finder or "open", thus the interlock is failing. > >>>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my >>>> copy, but apparently his is a fresh installation. >>>> >>> >>> I have tried on Windows 7 and Windows 8.1 64 bit clean VM (created >>> using ISO file) and pgAdmin4 is working fine on both. I have given the same >>> ISO file to Khushboo and she has created VM for both the OS and it is >>> crashed on her machine (seems strange behaviour), only difference is >>> version of VMWare fusion. I have 6.0.6 and she has 7.0.1 >>> >> >> Is it possible that on one virtual machine VMware Tools were installed, >> but not on the other? I ask because I believe they install a version of the >> MSVC runtime. >> > > On both machine VMware tools were installed. > Odd. Very odd. > >> >>> >>>> 4) On my Windows 7 machine, after running a backup I get no status >>>> window, and see the following in the logs: >>>> >>>> Traceback (most recent call last): >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>>> line 209, in run_wsgi >>>> execute(self.server.app) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>>> line 197, in execute >>>> application_iter = app(environ, start_response) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1997, in __call__ >>>> return self.wsgi_app(environ, start_response) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1985, in wsgi_app >>>> response = self.handle_exception(e) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1540, in handle_exception >>>> reraise(exc_type, exc_value, tb) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1982, in wsgi_app >>>> response = self.full_dispatch_request() >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1614, in full_dispatch_request >>>> rv = self.handle_user_exception(e) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1517, in handle_user_exception >>>> reraise(exc_type, exc_value, tb) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1612, in full_dispatch_request >>>> rv = self.dispatch_request() >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1598, in dispatch_request >>>> return self.view_functions[rule.endpoint](**req.view_args) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", >>>> line 792, in decorated_view >>>> return func(*args, **kwargs) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", >>>> line 62, in index >>>> return make_response(response=BatchProcess.list()) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", >>>> line 584, in list >>>> details = desc.details(p.command, args) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", >>>> line 190, in details >>>> res += html.safe_str(cmd + self.cmd) >>>> AttributeError: 'BackupMessage' object has no attribute 'cmd' >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>> 976-788-8246 <+91%2097678%2088246>* >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113c9c40be066b056800129b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Mar 22, 2018 at 1:00 PM, Akshay Joshi <<= a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.jo= shi@enterprisedb.com> wrote:


On Thu, Mar 22, 2018 at 3:22 PM, Dave Page <dpage@p= gadmin.org> wrote:
Hi

On Thu, Mar 22, 2018 at 9:21 AM, Akshay Joshi <akshay.josh= i@enterprisedb.com> wrote:
Hi Dave

On Wed, Mar 21, 2018 at 9:05 PM, Dave Page <dpage@pgadmi= n.org> wrote:
We've run into a number of unexpected issues with the v3.0 release = that I think we need to resolve before moving forwards. For the time being,= only patches critical to fix these issues should be committed.

I'll try to look at 1, though I do have another deadline I need= to meet.=C2=A0
Akshay, can you look at 2 please?
Fahar= is already looking at 3.
Khushboo, can you look at 4 please?

Thanks all.

1) There is no l= onger a system tray in Gnome 3.26 and later, and thus the runtime won't= initialise in Fedora 27 and later. We need an alternative for this, either= a tray replacement that the RPM can depend on, or better yet, support what= ever it is Gnome expect such apps to use these days.

2) Starting a second instance of the app bundle on Mac doesn't alway= s open a new pgAdmin window as it should. It works fine in the debugger, or= if you start the app with a command like: "/Applications/pgAdmin\ 4.a= pp/Contents/MacOS/pgAdmin4". It doesn't work if you double-cl= ick the appbundle or use a command like "open /Applications/pgAdmin\ 4= .app"

=C2=A0 Still = working on this, not found any solution yet.

=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Not able to figure out the solution yet. I h= ave tried to debug the code, but every time it will create a new instance(t= ray icon). Do I need to look into the code or something related to app bund= le may be some settings in info.plist or any other pointer?=C2=A0

Have a look at the code arou= nd line 85 an onwards of pgAdmin4.cpp. It creates the shared memory interlo= ck (and log/address files) based on the current username and a hash of the = executable name/path. My suspicion is that the path hash (which is calculat= ed from argv[0] on line 72) is for some reason getting a different value ea= ch time when launched via the Finder or "open", thus the interloc= k is failing.

=C2=A0

<= div>3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my = copy, but apparently his is a fresh installation.
<= div>
=C2=A0 =C2=A0 I have tried on Windows 7 and Windo= ws 8.1 64 bit clean VM (created using ISO file) and pgAdmin4 is working fin= e on both. I have given the same ISO file to Khushboo and she has created V= M for both the OS and it is crashed on her machine (seems strange behaviour= ), only difference is version of VMWare fusion. I have 6.0.6 and she has 7.= 0.1=C2=A0 =C2=A0=C2=A0

<= /span>
Is it possible that on one virtual machine VMware Tools were ins= talled, but not on the other? I ask because I believe they install a versio= n of the MSVC runtime.

<= /span>
=C2=A0 =C2=A0 On both machine VMware tools were installed.=C2=A0= =C2=A0

Odd. Very od= d.
=C2=A0
=
=
=C2=A0

4) On my Windows 7 machine, after running a backup I= get no status window, and see the following in the logs:
Traceback (most recent call last):
=C2=A0 File = "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkz= eug\serving.py", line 209, in run_wsgi
=C2=A0 =C2=A0 execute= (self.server.app)
=C2=A0 File "C:\Program Files (x86)\pgAdmi= n 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 197, in = execute
=C2=A0 =C2=A0 application_iter =3D app(environ, start_res= ponse)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv= \Lib\site-packages\flask\app.py", line 1997, in __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, start_response)
=C2= =A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\f= lask\app.py", line 1985, in wsgi_app
=C2=A0 =C2=A0 resp= onse =3D self.handle_exception(e)
=C2=A0 File "C:\Program Fi= les (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line= 1540, in handle_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_va= lue, tb)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\ve= nv\Lib\site-packages\flask\app.py", line 1982, in wsgi_app
<= div>=C2=A0 =C2=A0 response =3D self.full_dispatch_request()
=C2= =A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\f= lask\app.py", line 1614, in full_dispatch_request
=C2= =A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File "= ;C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.= py", line 1517, in handle_user_exception
=C2=A0 =C2=A0 rerai= se(exc_type, exc_value, tb)
=C2=A0 File "C:\Program Files (x= 86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1612,= in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_requ= est()
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\= Lib\site-packages\flask\app.py", line 1598, in dispatch_request
=C2=A0 =C2=A0 return self.view_functions[rule.endpoint](**req= .view_args)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3= \venv\Lib\site-packages\flask_login.py", line 792, in decorated_v= iew
=C2=A0 =C2=A0 return func(*args, **kwargs)
=C2=A0 F= ile "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", line 62, in index
=C2=A0 =C2=A0 return make= _response(response=3DBatchProcess.list())
=C2=A0 File "= C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\process= es.py", line 584, in list
=C2=A0 =C2=A0 details =3D desc.det= ails(p.command, args)
=C2=A0 File "C:\Program Files (x86)\pg= Admin 4\v3\web\pgadmin\tools\backup\__init__.py", line 190, in de= tails
=C2=A0 =C2=A0 res +=3D html.safe_str(cmd + self.cmd)
<= div>AttributeError: 'BackupMessage' object has no attribute 'cm= d'



--
Dave PageBlog: http://pg= snake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. Software Architect
<= /font>

=

Phone: +91 2= 0-3058-9517
Mobile: +91 976-788-8246
<= /div>
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company



--
<= div>Akshay Joshi
Sr. Software Architect





--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a113c9c40be066b056800129b--