MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELdg272qxWw-zWA_NvE8qBUSrWbv04LQkzZwmLYN1-nDRg@mail.gmail.com>
References: 
 <CAFOhELdtSDCcHTs+LJukGH5E_xUYfm0JJLwpKrq+SfLqcWthKg@mail.gmail.com>
 <CANxoLDeAD3VPenh7BCxtBWyZfcOD3LhA1bbOqc5xZ3foFxkshg@mail.gmail.com>
 <CA+OCxowrguJS2U8hDSg88VJdirRkdVg4OCMWESypMbeJmXz_DA@mail.gmail.com>
 <CAFOhELdfheYVqBeW_7M1_gnS-cw=HhYd7sJffc6F8ittP0moog@mail.gmail.com>
 <CA+OCxow=60KmJjxW2ORn4SaJacdpqEXn5f+-5-a1_BAXwudcHw@mail.gmail.com>
 <CAFOhELckCk=XnadYMwZ5hifg2qLQ5Q5AWbuLOgG3LRax_K-DrQ@mail.gmail.com>
 <CA+OCxowzkV6SLbxSzxfFw4spD8_EZjSWdXaDLMWrEGpch=G=0w@mail.gmail.com>
 <CAFOhELdg272qxWw-zWA_NvE8qBUSrWbv04LQkzZwmLYN1-nDRg@mail.gmail.com>
From: Dave Page <dave.page@enterprisedb.com>
Date: Fri, 24 Feb 2017 12:21:29 +0000
Message-ID: 
 <CA+OCxoyLD_EDkOPi_BWka0GuY3sC_Od23uc2Q4EDST-V+pUCrQ@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE
 support for functions missing
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: Akshay Joshi <akshay.joshi@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, committed!

On Fri, Feb 24, 2017 at 6:48 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Wed, Feb 15, 2017 at 8:57 PM, Dave Page <dave.page@enterprisedb.com>
> wrote:
>>
>> Hi
>>
>> On Fri, Feb 10, 2017 at 7:28 AM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>>>
>>> Hi,
>>>
>>> Please find the attached updated patch.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Fri, Feb 3, 2017 at 7:53 PM, Dave Page <dave.page@enterprisedb.com>
>>> wrote:
>>>>
>>>>
>>>>
>>>> On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi
>>>> <khushboo.vashi@enterprisedb.com> wrote:
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <dave.page@enterprisedb.com>
>>>>> wrote:
>>>>>>
>>>>>> I doubt the order matters, but feel free to change it if it bugs you
>>>>>> :-)
>>>>>>
>>>>>
>>>>> I have tried to create the function with both SQL commands.
>>>>> There is no bug, its just in pgAdmin4, if its not leakproof then we
>>>>> mentioned 'NOT LEAKPROOF'  in the SQL.
>>>>> So, I am not sure, we should remove it or not.
>>>>
>>>>
>>>> Well we should be consistent - we either list the full set of all
>>>> options, or just the non-default ones. The main thing is that we don't
>>>> explicitly show options that are the default in some cases, but not in
>>>> others.
>>>>
>>>
>>> Agreed.  Fixed for LEAKPROOF and PARALLEL options.
>>
>>
>> This seems to work in edit mode, but not in create mode, where the
>> PARALLEL option that's selected is simply ignored in the msql.
>>
>
> Fixed
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers