Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fW4Ie-0007rj-KC for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jun 2018 18:27:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fW4Ib-0004AQ-O6 for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jun 2018 18:27:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fW4Ib-0004AJ-Bt for pgadmin-hackers@lists.postgresql.org; Thu, 21 Jun 2018 18:27:13 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fW4IX-0006V2-Ba for pgadmin-hackers@postgresql.org; Thu, 21 Jun 2018 18:27:11 +0000 Received: by mail-wm0-x244.google.com with SMTP id 69-v6so7872895wmf.3 for ; Thu, 21 Jun 2018 11:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WXqRW4+UiZC621S8JK9pBBKW5B2pVWwTOpCzkiOoQ9s=; b=s8wkFYITmxc1CkC5dKZexCX316Z6DjmVwCM+ty/crwAcTLsr3U9KRxgi3F7ql00EW2 hBqLgYyjkvLY/qgg+76d29Qu77xOozq/FZuHKQ5Ra5eQaYvxVdnZ0gw0rt5nNDhFoSvS 5OGjFmSeWTOfXPKKzubxFEfWRoLAdF5KkE9otlmUPmxt4g1kh6GHNpOZQ6KQsm57MqDq OsiNYkLKkjvhnKW/cXxXHdf/7rjBfQE/w/hcbGV/9FuLHZEgrBEtXNNqPlVqGQlBVblG x9OeTkXXjJ4l5gZDz2dV8F3AQ5ISNPc/x6HSF0DpaGk/p7ew+zDKNFTkMxWub7vomGn0 huZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WXqRW4+UiZC621S8JK9pBBKW5B2pVWwTOpCzkiOoQ9s=; b=k3OdFeH+BBvJdGYS/njG99RFsI3Hlxcio8P6CsKdtAAPT+6zfPm35len9TkJDX9NLU CG+aeKSImPxaXjwWGbN0TpdRtzkNnZF/hOWht/BoOEgkBpJiFqYKUbAygrsDssSb+dk0 mncAMA6sQaf37cv37QQHjBPaJpvFAidEyMhV3Bm3xmRgoeWUYRjRHpEnp2Ax+W/ZvR0r lz7uOuH6AlG5LcjDvbQlgry02IAPaS59CbYZYsMGgRAiLHr0bv+18tLZ0AvCv9CXRoWq kVNuhJLLxtSiq1gqkvEOxtbSde9YXJeAyHo9n/w1ioyU3tvUUOMe0y4PXojzRWTOHfyi 7q0g== X-Gm-Message-State: APt69E3qmoBsHATPSfg+ctcZBP4XbBeYli4pOY8tn2lL1lGwbIJLn8yU FxfcHHpdR26lM9/30wTHghrfZwdGuTqWQyP8oYCXHA== X-Google-Smtp-Source: ADUXVKJuoaHb5/04PTAdQLydhZKEeKpyrSv7SPPPhotB2nKQiIOohX/TMQ7x9cAXULz+msV5q3I0mjCwfpKNe74fpx8= X-Received: by 2002:a1c:3ac6:: with SMTP id h189-v6mr6503025wma.64.1529605627273; Thu, 21 Jun 2018 11:27:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Thu, 21 Jun 2018 11:27:06 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 21 Jun 2018 19:27:06 +0100 Message-ID: Subject: Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000000f7924056f2b1076" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000f7924056f2b1076 Content-Type: text/plain; charset="UTF-8" Hi On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi wrote: > > > On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote: > >> Hi >> >> On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for Feature #3273 Add ability to sort in the >>> Select File window when opening a saved query. >>> >>> I haven't seen any refactoring possibility, patch contains feature test >>> with *time.sleep(0.05). *I have spend lot of time to not introduce >>> "time.sleep()" and tried couple of different ways of WebDriveWait, but >>> didn't get success. >>> >>> Please review it. >>> >> >> I get the following running the feature tests: >> >> invalid syntax (xss_checks_file_manager_test.py, line 60) >> >> make: *** [check-feature] Error 1 >> >> Fixed. > > >> Also; should that file be renamed now, to reflect that it tests more than >> just XSS? >> > > Done. Attached is the modified patch. > This seems to work for the most part, however, when sorting on the Modified column, it is sorting alphabetically, not by date. This doesn't seem like it's what users would expect. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000000f7924056f2b1076 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi <<= a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.jo= shi@enterprisedb.com> wrote:


On Thu, Jun 21, 2018 at 6:20 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for Feature #3273 Add ability to sort in= the Select File window when opening a saved query.

I = haven't seen any refactoring possibility, patch contains feature test w= ith time.sleep(0.05). I have spend lot of time to not introduce &quo= t;time.sleep()" and tried couple of different ways of WebDrive= Wait, but didn't get success.=C2=A0
invalid syntax (xss_che= cks_file_manager_test.py, line 60)

make: *** [check-featur= e] Error 1


=C2=A0 =C2= =A0Fixed.
=C2=A0
Also; should that file be renamed now, to reflect that it = tests more than just XSS?=C2=A0
=C2=A0 =C2=A0 Done. Attached is the modified patch.=C2= =A0

This seems to w= ork for the most part, however, when sorting on the Modified column, it is = sorting alphabetically, not by date. This doesn't seem like it's wh= at users would expect.=C2=A0


--=
Dave= Page
Blog: ht= tp://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: = http://www.enterp= risedb.com
The Enterprise PostgreSQL Company
--0000000000000f7924056f2b1076--