Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etcTM-0002D6-Dk for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 17:03:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etcTK-0004cH-5Q for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 17:03:22 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etcTJ-0004c7-Kj for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 17:03:22 +0000 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etcTG-0003OY-BK for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 17:03:20 +0000 Received: by mail-wm0-x235.google.com with SMTP id t6so6059972wmt.5 for ; Wed, 07 Mar 2018 09:03:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QzyfbKwc6jE4L8l+nBSrDwd4oqLenLkXNoZbPNaeDVI=; b=eK9/bd7t2uAkhLQL917bD+Bna0K9qobVq65BIe6F99Fgdc6isMrRaYqCxzdfVrA4c5 fTPLAW89PplftfyZtJrT9I5UOMsZ8aIGMD0yn2ob1tHZvh4Oz2+NTG+NoZNQvhWM+iCb z89wxz8fSZPGwyCOmWhIykDcjio/mQw3oVSpRKuTA6hLS5NahPyHmITn7JXlV6XxyYCG n68kLrnu5WoiFOwN3g1sdxPnzobw3jvxDvUYZ6Twf1ewEYYmMwLEDyufSL1ERDKDTpol TOzxKlUkKOfR+rCR+h7kAYEhYPm4x1yDCOUwb0iOXO9J1UGAd3uEvrSclbvod3LzEDWx zVRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QzyfbKwc6jE4L8l+nBSrDwd4oqLenLkXNoZbPNaeDVI=; b=f4fmvYI3TvnG33XyKxPOB0zM7eYrpYchlvi6sQWQjWIL7UAXOVOz6Oj7g7TYEFzL7j YQXYG/GsYSDAWVLO5M+OxEGLXQ0oBnDVXtaYHotwZCg8m8IZlEr2IgW2ylrSsHEe2Why bR+8evOIrdfJfugzxtutzLV+kBA267Cx/H3413OiOhpWGoipyV2IgKjyAxwhTdFUZQ3g D9VAwR2MzQerFDmBnRekh0uYppjRs9O+MVxqrYZezjLb+uPEgL9bgydOz2tPKmKLJxBI A/4ztm27qsp8s6fT/IOmtgfAjE4YDnJQItYMYB7KtzfnUhY1jduUrwmaRWJUWkuTtfMa lnCw== X-Gm-Message-State: AElRT7HseVwumGnDqf8MezvK8AzxKnMui1ClzStxfYTSx8Ki8pR1iuSD YgAxHAAdm5DCJ/oObaZSbHns7QTB1X5ynlXbOZLFKA== X-Google-Smtp-Source: AG47ELtmdAwQirpZdzG+IwfxYx15R/+cnbokL+z48PN7P5L/HtTMqLgVF3aeVe1RSgfhJmnZKB2JcUiam5xVpg1VN0Y= X-Received: by 10.28.5.75 with SMTP id 72mr15853376wmf.154.1520442195513; Wed, 07 Mar 2018 09:03:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Wed, 7 Mar 2018 09:03:14 -0800 (PST) In-Reply-To: References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org> From: Dave Page Date: Wed, 7 Mar 2018 17:03:14 +0000 Message-ID: Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507 To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114429c8f73bb50566d588d1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114429c8f73bb50566d588d1 Content-Type: text/plain; charset="UTF-8" It still seems to be failing :-( https://jenkins.pgadmin.org/job/pgadmin4-master-python26/lastFailedBuild/consoleFull On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: > Thanks, applied. Lets see what happens. > > On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Please find the attached updated patch. >> This should work. >> >> >> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: >>>>>> >>>>>>> Khushboo, can you look at this ASAP please? It passed tests on my >>>>>>> machine, but Jenkins isn't happy. >>>>>>> >>>>>>> I have tried to reproduce the issue with many combination but >>>>>> couldn't reproduce it. >>>>>> With the help of logs, I have tried to fix it. Can you please check >>>>>> this fix is helpful or not? >>>>>> >>>>> >>>>> On my laptop I now get: >>>>> >>>>> ====================================================================== >>>>> ERROR: runTest (pgadmin.tools.sqleditor.tests >>>>> .test_poll_query_tool.TestPollQueryTool) >>>>> When query tool polling returns messages with result data-set >>>>> ---------------------------------------------------------------------- >>>>> Traceback (most recent call last): >>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", >>>>> line 104, in runTest >>>>> response_data['data']['additional_messages']) >>>>> File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", >>>>> line 802, in assertIn >>>>> if member not in container: >>>>> TypeError: argument of type 'NoneType' is not iterable >>>>> >>>>> ------------------------------------------------------------ >>>>> ---------- >>>>> >>>>> Please provide some more details. Is this failing for particular >>>> server version? >>>> I am not getting any error with this patch and without this patch on >>>> PY2 and PY3 with a single/multiple servers. >>>> >>> >>> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are >>> the package versions in the venv: >>> >>> alabaster==0.7.10 >>> alembic==0.9.6 >>> args==0.1.0 >>> Babel==2.3.4 >>> backports.csv==1.0.4 >>> beautifulsoup4==4.4.1 >>> blinker==1.3 >>> chromedriver-installer==0.0.6 >>> click==6.6 >>> clint==0.5.1 >>> dateutils==0.6.6 >>> docutils==0.13.1 >>> extras==1.0.0 >>> fixtures==3.0.0 >>> Flask==0.11.1 >>> Flask-Babel==0.11.1 >>> Flask-Gravatar==0.4.2 >>> Flask-HTMLmin==1.2 >>> Flask-Login==0.3.2 >>> Flask-Mail==0.9.1 >>> Flask-Migrate==2.0.3 >>> Flask-Paranoid==0.1.0 >>> Flask-Principal==0.4.0 >>> Flask-Script==2.0.6 >>> Flask-Security==1.7.5 >>> Flask-SQLAlchemy==2.1 >>> Flask-WTF==0.12 >>> funcsigs==1.0.2 >>> html5lib==1.0b3 >>> htmlmin==0.1.11 >>> imagesize==0.7.1 >>> importlib==1.0.3 >>> itsdangerous==0.24 >>> Jinja2==2.7.3 >>> linecache2==1.0.0 >>> Mako==1.0.7 >>> MarkupSafe==0.23 >>> minify==0.1.4 >>> mock==2.0.0 >>> passlib==1.6.2 >>> pbr==3.1.1 >>> pkginfo==1.4.1 >>> psycopg2==2.7.3.2 >>> pycodestyle==2.3.1 >>> pycrypto==2.6.1 >>> Pygments==2.2.0 >>> pyperclip==1.5.32 >>> pyrsistent==0.14.0 >>> python-dateutil==2.5.0 >>> python-editor==1.0.3 >>> python-mimeparse==1.6.0 >>> pytz==2014.10 >>> requests==2.13.0 >>> requests-toolbelt==0.7.1 >>> selenium==3.3.3 >>> simplejson==3.6.5 >>> six==1.11.0 >>> snowballstemmer==1.2.1 >>> speaklater==1.3 >>> Sphinx==1.5.3 >>> SQLAlchemy==1.0.14 >>> sqlparse==0.1.19 >>> testscenarios==0.5.0 >>> testtools==2.0.0 >>> traceback2==1.4.0 >>> unittest2==1.1.0 >>> Werkzeug==0.9.6 >>> WTForms==2.0.2 >>> yuicompressor==2.4.8 >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114429c8f73bb50566d588d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 7, 2018 at 4:50 PM, Dave Page <dpa= ge@pgadmin.org> wrote:
Thanks, applied. Lets see what happens.

On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi <= khushb= oo.vashi@enterprisedb.com> wrote:
Please find the attached updated patch.
= This should work.


On Wed, Mar 7, 2018 at 9:46= PM, Dave Page <dpage@pgadmin.org> wrote:


On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Wed, = Mar 7, 2018 at 9:23 PM, Dave Page <dpage@pgadmin.org> wrote:=
Hi

On Wed, M= ar 7, 2018 at 3:10 PM, Khushboo Vashi <khushboo.vashi@enterp= risedb.com> wrote:
Hi Dave,
On Wed, Mar 7, 2018 at 7:34 PM, Dave Page = <dpage@pgadmin.or= g> wrote:
Khushboo, can you look at this ASAP please? It passed te= sts on my machine, but Jenkins isn't happy.

I have tried to reproduce the issue with many combination= but couldn't reproduce it.
With the help of logs, I have tri= ed to fix it. Can you please check this fix is helpful or not?=C2=A0
<= /div>

On my laptop I now= get:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin.tools.sqle= ditor.tests.test_poll_query_tool.TestPollQueryTool)
When query tool polling returns messages with result data-set
----------------------------------------------------------------------
Traceback (most recent call last):
=C2=A0 = File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests= /test_poll_query_tool.py", line 104, in runTest
=C2=A0 = =C2=A0 response_data['data']['additional_messages'])
=C2=A0 File "/System/Library/Frameworks/Python.framework= /Versions/2.7/lib/python2.7/unittest/case.py", line 802, in asser= tIn
=C2=A0 =C2=A0 if member not in container:
TypeError= : argument of type 'NoneType' is not iterable

<= div>-------------------------------------------------------------= ---------=C2=A0

Please provide some more details. Is this failing for part= icular server version?
I am not getting any error with this patch= and without this patch on PY2 and PY3 with a single/multiple servers.

Python 2.7.10 on= macOS Sierra, testing against PostgreSQL 9.4. Here are the package version= s in the venv:

alabaster=3D=3D0.7.10
alembic=3D=3D0.9.6
args=3D=3D0.1.0
Babel=3D=3D2.3.4
backports.csv=3D=3D1.0.4
beautifulsoup4=3D=3D4.4.1
=
blinker=3D=3D1.3
chromedriver-installer=3D=3D0.0.6
click=3D=3D6.6
clint=3D=3D0.5.1
dateutils=3D=3D0.6.6
docutils=3D=3D0.13.1
extras=3D=3D1.0.0
fixture= s=3D=3D3.0.0
Flask=3D=3D0.11.1
Flask-Babel=3D=3D0.11.1<= /div>
Flask-Gravatar=3D=3D0.4.2
Flask-HTMLmin=3D=3D1.2
<= div>Flask-Login=3D=3D0.3.2
Flask-Mail=3D=3D0.9.1
Flask-= Migrate=3D=3D2.0.3
Flask-Paranoid=3D=3D0.1.0
Flask-Prin= cipal=3D=3D0.4.0
Flask-Script=3D=3D2.0.6
Flask-Security= =3D=3D1.7.5
Flask-SQLAlchemy=3D=3D2.1
Flask-WTF=3D=3D0.= 12
funcsigs=3D=3D1.0.2
html5lib=3D=3D1.0b3
ht= mlmin=3D=3D0.1.11
imagesize=3D=3D0.7.1
importlib=3D=3D1= .0.3
itsdangerous=3D=3D0.24
Jinja2=3D=3D2.7.3
linecache2=3D=3D1.0.0
Mako=3D=3D1.0.7
MarkupSafe=3D=3D= 0.23
minify=3D=3D0.1.4
mock=3D=3D2.0.0
passli= b=3D=3D1.6.2
pbr=3D=3D3.1.1
pkginfo=3D=3D1.4.1
psycopg2=3D=3D2.7.3.2
pycodestyle=3D=3D2.3.1
pycrypto= =3D=3D2.6.1
Pygments=3D=3D2.2.0
pyperclip=3D=3D1.5.32
pyrsistent=3D=3D0.14.0
python-dateutil=3D=3D2.5.0
<= div>python-editor=3D=3D1.0.3
python-mimeparse=3D=3D1.6.0
pytz=3D=3D2014.10
requests=3D=3D2.13.0
requests-toolb= elt=3D=3D0.7.1
selenium=3D=3D3.3.3
simplejson=3D=3D3.6.= 5
six=3D=3D1.11.0
snowballstemmer=3D=3D1.2.1
= speaklater=3D=3D1.3
Sphinx=3D=3D1.5.3
SQLAlchemy=3D=3D1= .0.14
sqlparse=3D=3D0.1.19
testscenarios=3D=3D0.5.0
testtools=3D=3D2.0.0
traceback2=3D=3D1.4.0
unitt= est2=3D=3D1.1.0
Werkzeug=3D=3D0.9.6
WTForms=3D=3D2.0.2<= /div>
yuicompressor=3D=3D2.4.8

--=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgs= nake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company



--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a114429c8f73bb50566d588d1--