MIME-Version: 1.0
References: 
 <CA+36bxFXWcbCtjnH-TT9kTkw9uq-XdAQkN1joXbPyDO8kQQg1Q@mail.gmail.com>
 <CA+OCxoym5MAXyf-BBf_skn=DK2LkZcEr8GXpSQTqSsvWs1DgcQ@mail.gmail.com>
 <CAM9w-_kvjS_g1ZX5So=zMo-eJ=8H4_Ws=mfDEcDR92ftG4V3UA@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_kvjS_g1ZX5So=zMo-eJ=8H4_Ws=mfDEcDR92ftG4V3UA@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 26 Nov 2024 11:33:56 +0000
Message-ID: 
 <CA+OCxoyNEXsXQexNJjn=5F4yaaQ1_Cfh4sm9agCH=H4EwandaA@mail.gmail.com>
Subject: Re: Require suggestions on feature 6794
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Pravesh Sharma <pravesh.sharma@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000238d800627cf3acc"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoyNEXsXQexNJjn%3D5F4yaaQ1_Cfh4sm9agCH%3DH4EwandaA%40mail.gmail.com>
Precedence: bulk

--000000000000238d800627cf3acc
Content-Type: text/plain; charset="UTF-8"

On Tue, 26 Nov 2024 at 11:30, Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

> Hi Pravesh,
>
> In addition to that, why do we need env vars at all? We can simply pass
> them as arguments to passexec script. It's up to the users to use it or
> ignore it.
>

Or do some string substitution in the command, e.g.

/path/to/passexec.sh $HOST$ $PORT$

or similar, so the user has even more flexibility. I know that is done in
PEM in a few places, possibly in pgAdmin too, though I don't recall offhand
(if it is, we should be consistent on how the parameters are notated).

-- 
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com

--000000000000238d800627cf3acc
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, 26 Nov 2024 at 11:30, Aditya =
Toshniwal &lt;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com">aditya.t=
oshniwal@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-lef=
t-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=
=3D"ltr"><div style=3D"font-family:verdana,sans-serif">Hi Pravesh,</div><di=
v style=3D"font-family:verdana,sans-serif"><br></div><div style=3D"font-fam=
ily:verdana,sans-serif">In addition to that, why do we need env vars at all=
? We can simply pass them as arguments to passexec script. It&#39;s up to t=
he users to use it or ignore it.</div></div></blockquote></div><div><br cle=
ar=3D"all"></div><div>Or do some string substitution in the command, e.g.</=
div><div><br></div><div>/path/to/passexec.sh $HOST$ $PORT$</div><div><br></=
div><div>or similar,=C2=A0so the user has even more flexibility. I know tha=
t is done in PEM in a few places, possibly in pgAdmin too, though I don&#39=
;t recall offhand (if it is, we should be consistent on how the parameters =
are notated).</div><div><br></div><span class=3D"gmail_signature_prefix">--=
 </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dav=
e Page<div>pgAdmin: <a href=3D"https://www.pgadmin.org" target=3D"_blank">h=
ttps://www.pgadmin.org</a></div><div>PostgreSQL: <a href=3D"https://www.pos=
tgresql.org" target=3D"_blank">https://www.postgresql.org</a></div><div>pgE=
dge: <a href=3D"https://www.pgedge.com" target=3D"_blank">https://www.pgedg=
e.com</a><br><div></div><div><br></div></div></div></div></div>

--000000000000238d800627cf3acc--