Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erlxE-0006FU-BU for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 14:46:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erlxC-0001Lq-So for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 14:46:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erlxC-0001Lg-Fk for pgadmin-hackers@lists.postgresql.org; Fri, 02 Mar 2018 14:46:34 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erlx9-0003AU-86 for pgadmin-hackers@postgresql.org; Fri, 02 Mar 2018 14:46:33 +0000 Received: by mail-wm0-x241.google.com with SMTP id z81so3600099wmb.4 for ; Fri, 02 Mar 2018 06:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9fOOksCPsJFhd71I8RJjr964uvWzVE02f+UNULr3UkY=; b=KLMIYsVigUOF9JTjuuZpT2tXzXGGeVl+wdVd27KUtARg3Z+4pSnuaFLlTUGY+Pbfo+ RZHItige0ZLRBEPTi/CAXIeMPzjupuuP472S0caZwzOO7icohDnPKJhHaLd3G7O4Z/4L fVM0+b97Eo9o//dZOo+MbcHA/NmuZfOUkPpCpw/zLhe8wTUHahYkhmXOxWNS/YnMZJaW j0whjf2Pp5dihc1cHXXRs9s+OcDdSWRC3k5eQ0CYmVqxwbD1Anx1x6CRbGzE28hbkZQh TJviBcbVicgxn5l0oIMUr/2qk4svPI7WNY2nzJZYUHtIom4k1RQQs/mNXgPXVCft7VMm xd/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9fOOksCPsJFhd71I8RJjr964uvWzVE02f+UNULr3UkY=; b=fHQkLND9M3LGAguCoy8wgpPoEcyw5u4h4hZePYVqxFj8i2Kr8hdcK/2ZscBn/kEMQd gX+eNn5JPxqteyp42ijLr8Fk/u/botPxiqY7DpnX2zhbwnOb31HwaCA+OTfOQPj/cTGN 8SKU+mCzrOqldaj0YyzbTHRepiqqWFOQEVfbGFYjVc29S+HhpkvkPUdQ2owc/LtxTcCC bQgACZGBr17TVhEEg01FoPV88Lyfbv1MhAwGtbIYYLe6zroJQSpqsizbNpnXZmkUihZ/ pk3Ou6w5ZVRP0rf2ZypToU0ygT6/x7BQ2b0tPu2e+Ras3GpaNQ6O4HpwN9+IDVw0jib8 RBjw== X-Gm-Message-State: AElRT7F/h/IgrazMDMJ7jUQSTJ6lEhrTX1m7nFpdzeUOXdwmDuOK1le9 4N0UKW1QCTQsw7yXfdI+iztBc5eHbBGCiHbi9w1Mxg== X-Google-Smtp-Source: AG47ELu5aCGfrErJOm5ytMOJP+RTVMpQjybHBqkE6uKKAqyD+kR/lGBTQXMKs5H+zDst8pJBiMuIrg2kdW013F4Dl7Q= X-Received: by 10.28.5.75 with SMTP id 72mr1842743wmf.154.1520001989586; Fri, 02 Mar 2018 06:46:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 2 Mar 2018 06:46:28 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 2 Mar 2018 14:46:28 +0000 Message-ID: Subject: Re: [pgAdmin4][Patch]: PEP-8 fixes in the foreign data wrapper module To: Khushboo Vashi Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114429c8a5c77905666f0ad2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114429c8a5c77905666f0ad2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, applied. On Fri, Mar 2, 2018 at 4:56 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Joao, > > On Thu, Mar 1, 2018 at 8:13 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Khushboo, >> I applied this patch and here is the result: >> >> 2018-03-01 09:41:00 =E2=8C=9A |ruby-2.4.1| pgadmin-dev in >> ~/workspace/pgadmin4/web >> =C2=B1 |pep-8-fdw {2} U:13 =E2=9C=97| =E2=86=92 git st >> On branch pep-8-fdw >> Changes not staged for commit: >> (use "git add ..." to update what will be committed) >> (use "git checkout -- ..." to discard changes in working >> directory) >> >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/__init__.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/__init__.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/tests/test_foreign_servers_add.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/tests/test_foreign_servers_delete.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/tests/test_foreign_servers_get.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/tests/test_foreign_servers_put.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/tests/utils.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/user_mapping/__init__.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_add.p= y >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/user_mapping/tests/test_user_ >> mapping_delete.py >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_get.p= y >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_put.p= y >> modified: pgadmin/browser/server_groups/servers/databases/foreign_ >> data_wrappers/foreign_servers/user_mapping/tests/utils.py >> >> no changes added to commit (use "git add" and/or "git commit -a") >> >> 2018-03-01 09:41:03 =E2=8C=9A |ruby-2.4.1| pgadmin-dev in >> ~/workspace/pgadmin4/web >> =C2=B1 |pep-8-fdw {2} U:13 =E2=9C=97| =E2=86=92 pycodestyle --config=3D.= pycodestyle >> pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/ >> pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__= init__.py:644: >> [E123] closing bracket does not match indentation of opening bracket's l= ine >> pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__= init__.py:651: >> [E123] closing bracket does not match indentation of opening bracket's l= ine >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/__init__.py:593: [E123] closing bracket does >> not match indentation of opening bracket's line >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/__init__.py:662: [E123] closing bracket does >> not match indentation of opening bracket's line >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/__init__.py:669: [E123] closing bracket does >> not match indentation of opening bracket's line >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/user_mapping/__init__.py:622: [E123] closing >> bracket does not match indentation of opening bracket's line >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/user_mapping/__init__.py:685: [E123] closing >> bracket does not match indentation of opening bracket's line >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/user_mapping/__init__.py:692: [E123] closing >> bracket does not match indentation of opening bracket's line >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/user_mapping/tests/test_user_mapping_add.py:72= : >> [E126] continuation line over-indented for hanging indent >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/user_mapping/tests/test_user_mapping_add.py:84= : >> [E121] continuation line under-indented for hanging indent >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/user_mapping/tests/test_user_mapping_get.py:74= : >> [E126] continuation line over-indented for hanging indent >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/tests/test_foreign_servers_put.py:69: [E126] >> continuation line over-indented for hanging indent >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/foreign_servers/tests/test_foreign_servers_put.py:71: [E121] >> continuation line under-indented for hanging indent >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/tests/test_fdw_delete.py:25: [E126] continuation line >> over-indented for hanging indent >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/tests/test_fdw_delete.py:28: [E121] continuation line >> under-indented for hanging indent >> pgadmin/browser/server_groups/servers/databases/foreign_data >> _wrappers/tests/test_fdw_delete.py:55: [E126] continuation line >> over-indented for hanging indent >> 3 E121 continuation line under-indented for hanging indent >> 8 E123 closing bracket does not match indentation of opening >> bracket's line >> 5 E126 continuation line over-indented for hanging indent >> 16 >> >> Did I execute the command correctly? >> If so there are some things that need to be solved still >> >> Fixed. Patch updated. > >> Thanks >> Joao >> >> >> >> On Thu, Mar 1, 2018 at 8:08 AM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the PEP-8 issues in the foreign >>> data wrapper module. >>> >>> Thanks, >>> Khushboo >>> >> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114429c8a5c77905666f0ad2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Fri, Mar 2, 2018 at 4:56 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Joa= o,

On Thu, Mar 1, 2018 at 8:13 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Khushboo,
I applied this patch= and here is the result:

=C2=A02018-03-01 09:= 41:00 =E2=8C=9A |ruby-2.4.1| pgadmin-dev in ~/workspace/pgadmin4/web
<= div>=C2=B1 |pep-8-fdw {2} U:13 =E2=9C=97| =E2=86=92 git st
On bra= nch pep-8-fdw
Changes not staged for commit:
=C2=A0 (us= e "git add <file>..." to update what will be committed)
=C2=A0 (use "git checkout -- <file>..." to discard c= hanges in working directory)

modified:=C2=A0 =C2=A0pgadmin/browser/server_groups= /servers/databases/foreign_data_wrappers/__init__.py
modified:=C2=A0 =C2=A0pgadmin/br= owser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/__init__.py
= modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/da= tabases/foreign_data_wrappers/foreign_servers/tests/test_foreign_= servers_add.py
= modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databases/= foreign_data_wrappers/foreign_servers/tests/test_foreign_servers_= delete.py
modif= ied:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databases/forei= gn_data_wrappers/foreign_servers/tests/test_foreign_servers_= get.py
modified:=C2= =A0 =C2=A0pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_foreign_servers_put.py<= /div>
modified:=C2=A0 =C2= =A0pgadmin/browser/server_groups/servers/databases/foreign_data_w= rappers/foreign_servers/tests/utils.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups= /servers/databases/foreign_data_wrappers/foreign_servers/use= r_mapping/__init__.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/database= s/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_u= ser_mapping_add.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databa= ses/foreign_data_wrappers/foreign_servers/user_mapping/tests/test= _user_mapping_delete.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/d= atabases/foreign_data_wrappers/foreign_servers/user_mapping/tests= /test_user_mapping_get.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers= /databases/foreign_data_wrappers/foreign_servers/user_mapping/tes= ts/test_user_mapping_put.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/serve= rs/databases/foreign_data_wrappers/foreign_servers/user_mapping/t= ests/utils.py

no changes added to commit (use &quo= t;git add" and/or "git commit -a")

= =C2=A02018-03-01 09:41:03 =E2=8C=9A |ruby-2.4.1| pgadmin-dev in ~/workspace= /pgadmin4/web
=C2=B1 |pep-8-fdw {2} U:13 =E2=9C=97| =E2=86=92 pyc= odestyle --config=3D.pycodestyle pgadmin/browser/server_groups/servers= /databases/foreign_data_wrappers/
pgadmin/browser/server_gro= ups/servers/databases/foreign_data_wrappers/__init__.py:644: [E12= 3] closing bracket does not match indentation of opening bracket's line=
pgadmin/browser/server_groups/servers/databases/foreign_dat= a_wrappers/__init__.py:651: [E123] closing bracket does not match inde= ntation of opening bracket's line
pgadmin/browser/server_grou= ps/servers/databases/foreign_data_wrappers/foreign_servers/__init__.py:593: [E123] closing bracket does not match indentation of openin= g bracket's line
pgadmin/browser/server_groups/servers/d= atabases/foreign_data_wrappers/foreign_servers/__init__.py:662: [= E123] closing bracket does not match indentation of opening bracket's l= ine
pgadmin/browser/server_groups/servers/databases/foreign_= data_wrappers/foreign_servers/__init__.py:669: [E123] closing bra= cket does not match indentation of opening bracket's line
pga= dmin/browser/server_groups/servers/databases/foreign_data_wrapper= s/foreign_servers/user_mapping/__init__.py:622: [E123] closing bracket= does not match indentation of opening bracket's line
pgadmin= /browser/server_groups/servers/databases/foreign_data_wrappers/fo= reign_servers/user_mapping/__init__.py:685: [E123] closing bracket doe= s not match indentation of opening bracket's line
pgadmin/bro= wser/server_groups/servers/databases/foreign_data_wrappers/foreig= n_servers/user_mapping/__init__.py:692: [E123] closing bracket does no= t match indentation of opening bracket's line
pgadmin/browser= /server_groups/servers/databases/foreign_data_wrappers/foreign_se= rvers/user_mapping/tests/test_user_mapping_add.py:72: [E126] cont= inuation line over-indented for hanging indent
pgadmin/browser/se= rver_groups/servers/databases/foreign_data_wrappers/foreign_serve= rs/user_mapping/tests/test_user_mapping_add.py:84: [E121] continu= ation line under-indented for hanging indent
pgadmin/browser/serv= er_groups/servers/databases/foreign_data_wrappers/foreign_servers= /user_mapping/tests/test_user_mapping_get.py:74: [E126] continuat= ion line over-indented for hanging indent
pgadmin/browser/server_= groups/servers/databases/foreign_data_wrappers/foreign_servers/te= sts/test_foreign_servers_put.py:69: [E126] continuation line over= -indented for hanging indent
pgadmin/browser/server_groups/s= ervers/databases/foreign_data_wrappers/foreign_servers/tests/test= _foreign_servers_put.py:71: [E121] continuation line under-indented fo= r hanging indent
pgadmin/browser/server_groups/servers/datab= ases/foreign_data_wrappers/tests/test_fdw_delete.py:25: [E126] co= ntinuation line over-indented for hanging indent
pgadmin/browser/= server_groups/servers/databases/foreign_data_wrappers/tests/test_= fdw_delete.py:28: [E121] continuation line under-indented for hanging = indent
pgadmin/browser/server_groups/servers/databases/forei= gn_data_wrappers/tests/test_fdw_delete.py:55: [E126] continuation= line over-indented for hanging indent
3=C2=A0 =C2=A0 =C2=A0 =C2= =A0E121 continuation line under-indented for hanging indent
8=C2= =A0 =C2=A0 =C2=A0 =C2=A0E123 closing bracket does not match indentation of = opening bracket's line
5=C2=A0 =C2=A0 =C2=A0 =C2=A0E126 conti= nuation line over-indented for hanging indent
16
=
Did I execute the command correctly?
If so the= re are some things that need to be solved still

<= /blockquote>
Fixed. Patch updated.=C2=A0
Thank= s
=
Joao


On Thu, Mar 1, 2018 at 8:08 AM= Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
=
Hi,

Plea= se find the attached patch to fix the PEP-8 issues in the foreign data wrap= per module.

Thanks,
Khushboo




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114429c8a5c77905666f0ad2--