public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Chethana Kumar <[email protected]>
Subject: Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the
Date: Tue, 3 Dec 2019 05:39:40 -0500
Message-ID: <CA+OCxoyPUrrLmtQHv9UM9oyoh9w4RyE2QeJCSD-bbLrjZbbXnA@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_nxt1imJCKvCGaZu0tSdOmHZXfeWXgJxkgxMVzYScxKsw@mail.gmail.com>
References: <[email protected]>
<CAM9w-_nxt1imJCKvCGaZu0tSdOmHZXfeWXgJxkgxMVzYScxKsw@mail.gmail.com>
I intentionally didn't change that one as I wasn't sure what icon would be
better. I'm far from convinced that it should also be a play icon.
On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the patch to change toolbar icon for opening query tool inline
> with execute button change.
> Icon for table filter button on the toolbar is also changed as below:
> [image: toolbar.png]
>
> On Tue, Dec 3, 2019 at 7:15 AM Dave Page <[email protected]> wrote:
>
>> Use a 'play' icon for the Execute Query button in the Query Tool for
>> greater consistency with other applications. Fixes #4711
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2bd5e6ee7c41d5fc2f4ee0036042ac79ff...
>>
>> Modified Files
>> --------------
>> docs/en_US/release_notes_4_16.rst | 1 +
>> web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +-
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[image/png] toolbar.png (37.2K, 3-toolbar.png)
download | view image
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the
In-Reply-To: <CA+OCxoyPUrrLmtQHv9UM9oyoh9w4RyE2QeJCSD-bbLrjZbbXnA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox