Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkpA1-0003os-IL for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Jul 2019 12:23:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hkpA0-0006NQ-DJ for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Jul 2019 12:23:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkp9z-0006Dj-Rj for pgadmin-hackers@lists.postgresql.org; Tue, 09 Jul 2019 12:23:52 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkp9w-0006Jw-S1 for pgadmin-hackers@postgresql.org; Tue, 09 Jul 2019 12:23:51 +0000 Received: by mail-wm1-x342.google.com with SMTP id a15so2852994wmj.5 for ; Tue, 09 Jul 2019 05:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JWcWWspnrPcxl+YnNB3x+Ut9tkGX58BSTenQKqMAylE=; b=VTEJAQBM2DNi106pUI70MtwZEIFU8K8GnnwQmtIImWNGbqV2z2OUy0hyfyJD9+ehPi PHF5pDrHu8p7zbxQX3DP1Huyf6AgqDDF6Pejc+mzj8uJQghX5haNyAmi3EbUGqDn5Zqn NowK//Te58DsI+/uCLFWgw/T1Gr/9si+9PfLMxzjcJt82ufflbaAyqwQVv6KmKHDi0Am oXqbiAqMhb7YzjSailmizLZm96n4bFFGa/y1j0ii6AqhUGy4qy9ZbLO0eeWcAcTBVSAD bBi7jqrbuQht684b/3SKKsoi8JlvsuHvbNgAn5CzT6fexXmhVeDjd71M660+dB7v5ZHR mGkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JWcWWspnrPcxl+YnNB3x+Ut9tkGX58BSTenQKqMAylE=; b=n27/hFmF6uqx1Fzc9JgvogMaMMSZAy8yx3wyOjuVrEwZOB/ve9gDys+w2q4jTqJepS cxIQG+uAkf7eTNPtWASeJ+wJf4L622GGDbyXq2ok86NrgmRyLYB7CMRTu4f8YJChHEJa fjkcTRNOCY2voizkXigHv084Tad22sdV6gdE/NzTja0lYNrWI4g9ZhuqhXLGUvj7yvqF aoNlyDqT1Poieo+cptC2KuWPhEoDKAaOdSNdnerpoZoRCoKKKBLMAKZRBjo3I+JAOroG e+/MUmXmWTMV5xo0mbIHHfJIcH55jNjSNo3W1KkslNuu5YYHgX8XPOaYZCZXQtl8najB KvRQ== X-Gm-Message-State: APjAAAUUzHaOpKhp+W9d9JXlEIfvnCDTYTLZ/OsILVSdvnCeKZ1+G+NA WKk0kgyuknGmIspnanqD5quQDajaa1BaG0/g5qU4Gw== X-Google-Smtp-Source: APXvYqzh77cv/fFRqSaVW/Tg/Z7pjz/GYR3UGga8D/CAxBr67KLxaf62GtqpFemHhf8yHa0B7hvBNlum0y4AtOulxQU= X-Received: by 2002:a1c:107:: with SMTP id 7mr22461830wmb.84.1562675027884; Tue, 09 Jul 2019 05:23:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 9 Jul 2019 13:23:35 +0100 Message-ID: Subject: Re: RE-SQL test patch for extension node To: Nagesh Dhope Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000efd38a058d3ea19a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000efd38a058d3ea19a Content-Type: text/plain; charset="UTF-8" Thanks, applied! On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhope wrote: > Hi Dave, > > On Tue, Jul 9, 2019 at 4:54 PM Dave Page wrote: > >> Hi >> >> I have a sneaking suspicion that the work Akshay and Khushboo have been >> doing might have broken this :-( >> > > Yup, earlier we were able to create a schema if not exists while running *alter > *test cases. As this capability is remove alter test case for extension > was failing. > I have fixed the test case, PFA updated patch. > > >> Create Extension with all options..............OK >> ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query >> (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): >> Error Message:ERROR: schema "test_extension_schema" does not exist >> >> Alter Extension version..............FAIL >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line >> 230, in execute_test_case >> self.assertEquals(response.status_code, 200) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 1338, in deprecated_func >> return original_func(*args, **kwargs) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 839, in assertEqual >> assertion_func(first, second, msg=msg) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 832, in _baseAssertEqual >> raise self.failureException(msg) >> AssertionError: 500 != 200 >> >> >> On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope < >> nagesh.dhope@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find updated patch with *sslinfo.* >>> >>> On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: >>> >>>> Hi >>>> >>>> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >>>> nagesh.dhope@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> Please review attached patch for RE-SQL test cases for *extension* >>>>> node. >>>>> >>>> >>>> Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel >>>> contrib module has finally been removed. >>>> >>>> Perhaps use sslinfo? That seems less likely to go away anytime soon. >>>> >>>> Thanks. >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000efd38a058d3ea19a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied!

On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhop= e <nagesh.dhope@enterpr= isedb.com> wrote:
Hi Dave,

On Tue, Jul 9, 2019 at 4:54 PM Dav= e Page <dpage@pga= dmin.org> wrote:
Hi

I have a sneaking suspicion = that the work Akshay and Khushboo have been doing might have broken this :-= (=C2=A0

Yup, earlier we were ab= le to create a=C2=A0 schema if not exists while running alter test cases. As this capability is remove alter test ca= se for extension was failing.=C2=A0
I have fixed the test case, P= FA updated patch.


Create Extension with all= options..............OK
=C2=A0... 2019-07-09 12:22:55,268: ERROR flask.= app: Failed to execute query (execute_dict) for the server #5- DB:test_db_d= 08e5 (Query-id: 1400245):
Error Message:ERROR: =C2=A0schema "test_e= xtension_schema" does not exist

Alter Extension version........= ......FAIL
Traceback (most recent call last):
=C2=A0 File "/User= s/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line = 230, in execute_test_case
=C2=A0 =C2=A0 self.assertEquals(response.statu= s_code, 200)
=C2=A0 File "/opt/local/Library/Frameworks/Python.fram= ework/Versions/3.7/lib/python3.7/unittest/case.py", line 1338, in depr= ecated_func
=C2=A0 =C2=A0 return original_func(*args, **kwargs)
=C2= =A0 File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/= lib/python3.7/unittest/case.py", line 839, in assertEqual
=C2=A0 = =C2=A0 assertion_func(first, second, msg=3Dmsg)
=C2=A0 File "/opt/l= ocal/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittes= t/case.py", line 832, in _baseAssertEqual
=C2=A0 =C2=A0 raise self.= failureException(msg)
AssertionError: 500 !=3D 200


On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:
Hi=C2=A0Dave,

Please find updated patch wi= th sslinfo.

On Mon, Jul 8, 2019 at 2:03 PM Dave Page <dpage@pgadmin.org> = wrote:
Hi

On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope &= lt;nages= h.dhope@enterprisedb.com> wrote:
Hi Hackers,
Please review atta= ched patch for RE-SQL test cases for extension node.=C2=A0

Unfortunately this fails on PostgreSQL 1= 2 as the deprecated timetravel contrib module has finally been removed.

Perhaps use sslinfo? That seems less likely to go awa= y anytime soon.

Thanks.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

En= terpriseDB UK: ht= tp://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterp= riseDB UK: http:/= /www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000efd38a058d3ea19a--