Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjmfq-0006nS-SB for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Jan 2019 15:00:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gjmfp-0006jZ-3E for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Jan 2019 15:00:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjmfo-0006jS-HS for pgadmin-hackers@lists.postgresql.org; Wed, 16 Jan 2019 15:00:08 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjmfk-0005T7-Tz for pgadmin-hackers@lists.postgresql.org; Wed, 16 Jan 2019 15:00:07 +0000 Received: by mail-ed1-x544.google.com with SMTP id h15so5667602edb.4 for ; Wed, 16 Jan 2019 07:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4dMmCkDRCgv9uBuV+4H4y0nCJoJJVpiB3B/JlRCbPv0=; b=kb4MyXjTai1UkrBHbfdAlGpB335Tfl2WsQdpklnCDrNS2xe3y8rPPmI8uPGwQPvi71 PNbLduBhusn/p49Eb/07mo3EAXC/pFA8ypCDbXz9fsxUtF/UDE0ErK9TeXwphbeJdS9C uVocComRC9+PvEI+pschMePc8WgoK3WA94WrnUDdMZBB5qcq1ZvKViC5S3S/OhTUbHkL WeuE8kVOOzs1kKCCcA5vppwQ53PEHs87XCsXOb5lJhPaxsTvH5Vz1XDTlNjgtBcfLkeZ YDAvc4jL6/ufY0S+Y3HToTVrZodb0D5kt52hmPW/0Xftw3hjEF4hJXbW//1lDI3vmulq gVqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4dMmCkDRCgv9uBuV+4H4y0nCJoJJVpiB3B/JlRCbPv0=; b=jCVA8Bzk0kr/jR1fQon53fWoXzD5t9VekhAoy/ykSorQHRuE4QKf2zH9hWVuvNDSSy z4SKQNBblhBTs7jE6oQfXNRXhZbsaXQbPX3CRv9ieXJfTjwipwqXhEmwyFaWL2E/V9ot /2IfTkfTljJ7ogaSXmFcgVqGi7UTT6UR51SLvdiwv33FGGD7LzRbh0/LYWPgY+KHyQsy wSJUeYcggDLn/y/4mjYrcIVCiBeOA3k0PPsJZ2u6YkToJccbVGj8TEypg6jaThMX9J0D KpEgsgmnn9lgdLc+hZ0+8aUeH9hZ8HioXSiJd6BYpHJqcExqa19F+Ohs6FMaZYJ1B5aA 2nZQ== X-Gm-Message-State: AJcUukdGgRTg3CwUJTlUJOyNWFc01N8eN2pNfFq7caPR1S44K/JzYVCZ BeuqLqMy6HVqv0k7IMDJyh8FoH9oNViSDTOlgCwgVlmxbI8o0YOeNP8nzXU8/TjPTrjAHl06tUS nc8Fn8IlhdJZfx3AkqokKY+oa9JPUPCqw0YIJKSCA2O95RRlfeZyEI/OmARKlKAtoDeqUeSP0q2 eLGdmhyvRJv6JFB2KT97M= X-Google-Smtp-Source: ALg8bN6+gniRFz3eeFK8RQftJeGeu7mlwp2IFhxtvgP+sEm57sslkgxqpadG6KBltkUk0f84rW3a+g== X-Received: by 2002:a50:8907:: with SMTP id e7mr7937678ede.252.1547650802802; Wed, 16 Jan 2019 07:00:02 -0800 (PST) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com. [209.85.221.54]) by smtp.gmail.com with ESMTPSA id b46sm5921239edc.57.2019.01.16.07.00.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 07:00:01 -0800 (PST) Received: by mail-wr1-f54.google.com with SMTP id l9so7211114wrt.13 for ; Wed, 16 Jan 2019 07:00:00 -0800 (PST) X-Received: by 2002:a5d:4a8e:: with SMTP id o14mr7557728wrq.159.1547650800258; Wed, 16 Jan 2019 07:00:00 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 16 Jan 2019 14:59:47 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica To: Akshay Joshi Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000002face9057f9488d5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000002face9057f9488d5 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi wrote: > Thanks patch applied without Tree Changes. > > On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for further design improvements: >> - Process watcher made fixed width with header changes, time details >> rounded to 2 decimals >> - Query history will show "No query history" if no query fired. Query >> editor default size increased. >> - Tree improvements - right bold border removed completely. Now click >> anywhere on a tree item to perform actions. Please note, single click on >> the tiny tree arrow button will not work with this. Clicking anywhere is >> more useful than this. >> > @Dave Should we proceed with this behaviour, I haven't commit it. > I like the blue bit, so that should come back. I would say that a single-click on the arrow should open/close the node, whilst a double-click on the icon or label should open/close it. > - Fixed a bug where New folder create button not working when in List mode >> and No files/folder present. >> - Other minor improvements. >> >> Kindly review. >> >> On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for few more changes: >>> - New Folder button was not working in file dialogue. Fixed that. >>> - Color, icon changes in file dialogue >>> - Also replaced the splash screen image (which is used on main dashboard >>> also). It works fine on dashboard. However, I'm not sure of the splash >>> screen as the new image is SVG and older was PNG. I have made changes for >>> that in runtime code but I'm not able to test (evnvironment issue) runtime >>> code :(. It would be helpful if someone else can try it once. >>> >>> Kindly review. >>> >>> >>> On Mon, Jan 7, 2019 at 2:25 PM Dave Page wrote: >>> >>>> Thanks - applied! >>>> >>>> On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal >>>> wrote: >>>> > >>>> > Hi Hackers, >>>> > >>>> > Attached is the patch to incorporate the changes discussed in >>>> trailing mail(s). >>>> > >>>> > Kindly review. >>>> > >>>> > On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote: >>>> >> >>>> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal >>>> >> wrote: >>>> >> > >>>> >> > Hi, >>>> >> > >>>> >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page >>>> wrote: >>>> >> >> >>>> >> >> Hi >>>> >> >> >>>> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >> >>> >>>> >> >>> Hi Dave, >>>> >> >>> >>>> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page >>>> wrote: >>>> >> >>>> >>>> >> >>>> >>>> >> >>>> A few other things that I noticed (or have been bugging me): >>>> >> >>>> >>>> >> >>>> - The menu bar seems a little cramped. Taking pg-navbar from 32 >>>> to 40px and setting the font-weight to normal on the menu options (but not >>>> the product name) seems much better to me (and adjusting everything else as >>>> required of course). >>>> >> >>> >>>> >> >>> Giving too much space for the navbar will reduce the usable >>>> space for other things. It is good enough(32) to be used easily, and is >>>> equal to all the other headers in app (including tabs) giving a feel of >>>> native desktop application. You'll find even smaller menu heights in native >>>> desktop application. We can make font weight to normal and may be slightly >>>> increase horizontal spacing between the menu links. >>>> >> >> >>>> >> >> >>>> >> >> 8 pixels isn't going to make a noticeable difference to the >>>> workspace for users, and would leave the bar smaller than the 50px it's >>>> been for the last couple of years (iirc). I think it needs it to avoid >>>> looking cramped - please make the change. >>>> >> > >>>> >> > Will do. >>>> >> > One more doubt regarding bold headers, should I remove bold >>>> headers in dashboard graph header, subnode headers (eg.table->columns), >>>> properties tab accrordian headers ? >>>> >> >>>> >> No, please don't. I left them bold and the styling seemed like it >>>> >> worked. We can tweak again if others disagree later. >>>> >> >>>> >> Thanks! >>>> >> >>>> >> BTW - Chrome 71 shows the offset headers in the file dialogue as >>>> well. >>>> >> >>>> >> >>>> >>>> >> >>>> - In the file dialogue, the column headers don't line up with >>>> the columns in the rows. >>>> >> >>> >>>> >> >>> I could not see this on my machine (screenshot attached). Could >>>> you please share the screenshot. >>>> >> >> >>>> >> >> >>>> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. >>>> >> >> >>>> >> >> -- >>>> >> >> Dave Page >>>> >> >> Blog: http://pgsnake.blogspot.com >>>> >> >> Twitter: @pgsnake >>>> >> >> >>>> >> >> EnterpriseDB UK: http://www.enterprisedb.com >>>> >> >> The Enterprise PostgreSQL Company >>>> >> > >>>> >> > >>>> >> > >>>> >> > -- >>>> >> > Thanks and Regards, >>>> >> > Aditya Toshniwal >>>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>> >> > "Don't Complain about Heat, Plant a tree" >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> Dave Page >>>> >> Blog: http://pgsnake.blogspot.com >>>> >> Twitter: @pgsnake >>>> >> >>>> >> EnterpriseDB UK: http://www.enterprisedb.com >>>> >> The Enterprise PostgreSQL Company >>>> > >>>> > >>>> > >>>> > -- >>>> > Thanks and Regards, >>>> > Aditya Toshniwal >>>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>> > "Don't Complain about Heat, Plant a tree" >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --0000000000002face9057f9488d5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
Thanks patch applied without Tree Changes.

On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,
Attached is the patch= for further design improvements:
- Process watcher made fixed width with header changes, time deta= ils rounded to 2 decimals
- Query history will show "No query history" if no query fired.= Query editor default size increased.
- Tree improvements - right bold border removed completely. N= ow click anywhere on a tree item to perform actions. Please note, single cl= ick on the tiny tree arrow button will not work with this. Clicking anywher= e is more useful than this.
=C2=A0@Dave=C2=A0= =C2=A0Should we proceed with this behaviour, I haven't commit it.=C2=A0=

I like the blue bit, so = that should come back.

I would say that a single-c= lick on the arrow should open/close the node, whilst a double-click on the = icon or label should open/close it.
=C2=A0
- Fixed a bug where New folder crea= te button not working when in List mode and No files/folder present.
<= div style=3D"font-family:verdana,sans-serif">- Other minor improvements.

Kindly review.

On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwa= l <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached= is the patch for few more changes:
- New Folder button was not working in file dialogue. Fixed tha= t.
- Color, icon changes= in file dialogue
- Also= replaced the splash screen image (which is used on main dashboard also). I= t works fine on dashboard. However, I'm not sure of the splash screen a= s the new image is SVG and older was PNG. I have made changes for that in r= untime code but I'm not able to test (evnvironment issue) runtime code = :(. It would be helpful if someone else can try it once.

Kindly review.


On Mon= , Jan 7, 2019 at 2:25 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks - applied!

On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal
<= aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to incorporate the changes discussed in trailing= mail(s).
>
> Kindly review.
>
> On Fri, Jan 4, 2019 at 3:31 PM Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal
>> <aditya.toshniwal@enterprisedb.com> wrote:
>> >
>> > Hi,
>> >
>> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal <aditya.to= shniwal@enterprisedb.com> wrote:
>> >>>
>> >>> Hi Dave,
>> >>>
>> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page <dpage@pgadmin.org> w= rote:
>> >>>>
>> >>>>
>> >>>> A few other things that I noticed (or have been b= ugging me):
>> >>>>
>> >>>> - The menu bar seems a little cramped. Taking pg-= navbar from 32 to 40px and setting the font-weight to normal on the menu op= tions (but not the product name) seems much better to me (and adjusting eve= rything else as required of course).
>> >>>
>> >>> Giving too much space for the navbar will reduce the = usable space for other things. It is good enough(32) to be used easily, and= is equal to all the other headers in app (including tabs) giving a feel of= native desktop application. You'll find even smaller menu heights in n= ative desktop application. We can make font weight to normal and may be sli= ghtly increase horizontal spacing between the menu links.
>> >>
>> >>
>> >> 8 pixels isn't going to make a noticeable difference = to the workspace for users, and would leave the bar smaller than the 50px i= t's been for the last couple of years (iirc). I think it needs it to av= oid looking cramped - please make the change.
>> >
>> > Will do.
>> > One more doubt regarding bold headers, should I remove bold h= eaders in dashboard graph header, subnode headers (eg.table->columns), p= roperties tab accrordian headers ?
>>
>> No, please don't. I left them bold and the styling seemed like= it
>> worked. We can tweak again if others disagree later.
>>
>> Thanks!
>>
>> BTW - Chrome 71 shows the offset headers in the file dialogue as w= ell.
>>
>> >>>>
>> >>>> - In the file dialogue, the column headers don= 9;t line up with the columns in the rows.
>> >>>
>> >>> I could not see this on my machine (screenshot attach= ed). Could you please share the screenshot.
>> >>
>> >>
>> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS.=
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,Aditya Toshniwal
Software Enginee= r |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don&#= 39;t Complain about Heat, Plant a tree"


--
Thanks a= nd Regards,
Aditya T= oshniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't Complain about Heat, Plant a tree"<= /div>


--
Akshay Joshi
Sr. Software Ar= chitect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=


--
Dave Page
VP, Chief Architect, Tools & In= stallers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny

Blog: h= ttp://pgsnake.blogspot.com
Twitter: @pgsnake
--0000000000002face9057f9488d5--